You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by hzbarcea <gi...@git.apache.org> on 2015/06/27 15:45:19 UTC
[GitHub] incubator-brooklyn pull request: Remove unnecessary use of snapsho...
GitHub user hzbarcea opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/724
Remove unnecessary use of snapshot repositories
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzbarcea/incubator-brooklyn master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/724.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #724
----
commit 474f8fc59728e24b205dfad6feb321fecbeda99d
Author: Hadrian Zbarcea <ha...@apache.org>
Date: 2015-06-27T13:43:29Z
Remove unnecessary use of snapshot repositories
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove unnecessary use of snapsho...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/724#issuecomment-117995613
@hzbarcea Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove unnecessary use of snapsho...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/724#issuecomment-116106602
While this fix is necessary, I am not sure if it's sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove unnecessary use of snapsho...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/724#issuecomment-116612979
I see the point about the snapshots repo added as a comment in the archetypes.
Depending on what we decide to do with the downstream-parent however, it may not be necessary, because if the generated archetype ultimately derives from org.apache:apache:17 there is a snapshot repository <id>apache.snapshots.https</id> in there.
Do you prefer to add the snapshot repo as a comment anyway?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove unnecessary use of snapsho...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/724
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove unnecessary use of snapsho...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/724#issuecomment-116108980
This pull request included a patch that changed the parent in usage/downstream-parent/pom.xml to change the parent from oss.sonatype to apache.
Unfortunately, while it is something that needs to be done, it's not as simple as just changing the parent. I'll have to come back with a better, separate patch for that.
This PR can be merged though as it does not depend on that fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove unnecessary use of snapsho...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/724#issuecomment-116588358
@hzbarcea what's the problem with changing the parent pom of "downstream"?
and when you say "this is necessary", do you mean it's an apache requirement for a release? (that makes sense...)
finally -- can you put the snapshot repos into the archetype's sample pom, commented out, but at least this gives an easy way for people to enable them if required? (it is a common desire.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove unnecessary use of snapsho...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/724#issuecomment-116589072
BTW once the repos are in a comment in the archetype sample pom, i think this is good to merge.
And I think we want to **backport to the 0.7.0** release branch, with versions adjusted as appropriate if required (possibly not required).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove unnecessary use of snapsho...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/724#issuecomment-116909725
I added the ref to the snapshot repository, although after fixing the poms it'll be unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---