You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/04 19:10:02 UTC

[GitHub] [arrow-datafusion] andygrove commented on a change in pull request #676: Implement metrics for shuffle read and write

andygrove commented on a change in pull request #676:
URL: https://github.com/apache/arrow-datafusion/pull/676#discussion_r663544711



##########
File path: ballista/rust/core/Cargo.toml
##########
@@ -33,6 +33,7 @@ simd = ["datafusion/simd"]
 ahash = "0.7"
 async-trait = "0.1.36"
 futures = "0.3"
+hashbrown = "0.11"

Review comment:
       It looks like the dependency was added to DataFusion for a performance optimization in https://github.com/apache/arrow-datafusion/commit/ec062075cd03fc68e22b96d6f8bf0ed291e30d93 and when the `metrics` method was added in DataFusion is used this hashmap as well, but perhaps we should have had it use the std hashmap instead?
   
   @Dandandan what do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org