You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/06 21:55:52 UTC
Review Request 24418: Fixed two flaky tests in AllocatorTest.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24418/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1677
https://issues.apache.org/jira/browse/MESOS-1677
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/allocator_tests.cpp b920533
Diff: https://reviews.apache.org/r/24418/diff/
Testing
-------
make check
bin/mesos-tests.sh --gtest_filter=AllocatorTest* --gtest_repeat=10
Thanks,
Jie Yu
Re: Review Request 24418: Fixed two flaky tests in AllocatorTest.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 6, 2014, 9:01 p.m., Vinod Kone wrote:
> > src/tests/allocator_tests.cpp, lines 757-758
> > <https://reviews.apache.org/r/24418/diff/1/?file=654066#file654066line757>
> >
> > calling process::teriminate() and ::wait() multiple times is safe i assume?
> >
Yes, it is.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24418/#review49804
-----------------------------------------------------------
On Aug. 6, 2014, 7:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24418/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 7:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1677
> https://issues.apache.org/jira/browse/MESOS-1677
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp b920533
>
> Diff: https://reviews.apache.org/r/24418/diff/
>
>
> Testing
> -------
>
> make check
> bin/mesos-tests.sh --gtest_filter=AllocatorTest* --gtest_repeat=10
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24418: Fixed two flaky tests in AllocatorTest.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24418/#review49804
-----------------------------------------------------------
Ship it!
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/24418/#comment87160>
calling process::teriminate() and ::wait() multiple times is safe i assume?
- Vinod Kone
On Aug. 6, 2014, 7:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24418/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 7:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1677
> https://issues.apache.org/jira/browse/MESOS-1677
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp b920533
>
> Diff: https://reviews.apache.org/r/24418/diff/
>
>
> Testing
> -------
>
> make check
> bin/mesos-tests.sh --gtest_filter=AllocatorTest* --gtest_repeat=10
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24418: Fixed two flaky tests in AllocatorTest.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24418/#review49798
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Aug. 6, 2014, 12:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24418/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 12:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1677
> https://issues.apache.org/jira/browse/MESOS-1677
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp b920533
>
> Diff: https://reviews.apache.org/r/24418/diff/
>
>
> Testing
> -------
>
> make check
> bin/mesos-tests.sh --gtest_filter=AllocatorTest* --gtest_repeat=10
>
>
> Thanks,
>
> Jie Yu
>
>