[jira] [Closed] (OFBIZ-9451) [FB] Package org.apache.ofbiz.accounting.payment

["Michael Brohl (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Brohl closed OFBIZ-9451.
--------------------------------
       Resolution: Implemented
    Fix Version/s: Upcoming Release

The patch for BillingAccountComparator is in r1801168.
The patch for GiftCertificateServices is in r1801171.
The patch for PaymentMethodServices is in r1801183.
The patch for PaymentGatewayServices is in r1801185.

> [FB] Package org.apache.ofbiz.accounting.payment
> ------------------------------------------------
>
>                 Key: OFBIZ-9451
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9451
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-9451_payment.BillingAccountWorker_bugfixes.patch, OFBIZ-9451_payment.GiftCerificateServices_bugfixes.patch, OFBIZ-9451_payment.PaymentGatewayServices_bugfixes.patch, OFBIZ-9451_payment.PaymentGatewayServices_bugfixes.patch, OFBIZ-9451_payment.PaymentMethodServices_bugfixes.patch
>
>
> BillingAccountWorker:
> * Implement Serializable for class BillingAccountComparator and suppress Warnings (following the discussion on warnings for serializable classes: http://ofbiz.135035.n4.nabble.com/Usage-of-SuppressWarnings-quot-serial-quot-td361041.html)
> GiftCertificateServices:
> * Set BigDecimal zero to final to avoid changes by malicious code from the outside or changes that happen by accident from another package.
>     ReturnHeaderResp in RefundGcPurchase() is unnecessarily checked for null value.
> PaymentGatewayServices:
> * At two occurrences, an Error is logged which contains the variable processorResult. At that point however processorResult is certain to be null. Remove the variable from the log.
> * Remove unreachable else condition in processAuthResult(). authResult can only be true or false, no third condition needed.
> PaymentMethodServices:
> * Use a StringBuilder to append a certain amount of '*'s to origMaskedNumber. When using concatenation inside the loop, the String is converted to a new StringBuilder, appended to, and then converted back to a String anyway. Therefor the performance is improved by avoiding many StringBuilder initializations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)