You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/01/20 20:06:55 UTC
[GitHub] [sling-org-apache-sling-repoinit-parser] klcodanr opened a new pull request #16: SLING-11078 - Describe and Validate asRepoInitString Line Separator Requirement
klcodanr opened a new pull request #16:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16
## Changes
- Resolves the regression introduced with SLING-10952 where DeleteGroup.asRepoInitString() no longer has a newline
- Adds JavaDoc to describe the intended format for the Operation.asRepoInitString() representation
- Add a new method to the ParserTestCase to get a supplier of test cases as the ParserTestCase objects are not reusable for multiple tests within a parameterized test
- Adds a test to check the presence of a line separator in the representation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] removed a comment on pull request #16: SLING-11078 - Describe and Validate asRepoInitString Line Separator Requirement
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #16:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#issuecomment-1017878764
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #16: SLING-11078 - Describe and Validate asRepoInitString Line Separator Requirement
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #16:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#issuecomment-1018499261
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #16: SLING-11078 - Describe and Validate asRepoInitString Line Separator Requirement
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #16:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#issuecomment-1017878764
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=16&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] anchela commented on pull request #16: SLING-11078 - Describe and Validate asRepoInitString Line Separator Requirement
Posted by GitBox <gi...@apache.org>.
anchela commented on pull request #16:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#issuecomment-1018502274
@klcodanr , lgtm. thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] klcodanr commented on pull request #16: SLING-11078 - Describe and Validate asRepoInitString Line Separator Requirement
Posted by GitBox <gi...@apache.org>.
klcodanr commented on pull request #16:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#issuecomment-1018500235
Thanks @anchela! I agree and thanks for spotting. I believe I've addressed all of the points you raised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] klcodanr merged pull request #16: SLING-11078 - Describe and Validate asRepoInitString Line Separator Requirement
Posted by GitBox <gi...@apache.org>.
klcodanr merged pull request #16:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] anchela commented on a change in pull request #16: SLING-11078 - Describe and Validate asRepoInitString Line Separator Requirement
Posted by GitBox <gi...@apache.org>.
anchela commented on a change in pull request #16:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#discussion_r789437145
##########
File path: src/test/java/org/apache/sling/repoinit/parser/operations/AsRepoInitTest.java
##########
@@ -59,6 +62,21 @@ private static Reader rebuildInputScript(Reader input) throws Exception {
@Test
public void checkResultAsRepoInit() throws Exception {
- ParserTestCase.validate(rebuildInputScript(tc.input), tc.expected, tc);
+ try(ParserTestCase tc = testCaseSupplier.get()){
Review comment:
@klcodanr , minor nitpicking: there are 2 whitespaces missing. should be
`try (ParserTestCase tc = testCaseSupplier.get()) {`
instead of
`try(ParserTestCase tc = testCaseSupplier.get()){`
##########
File path: src/test/java/org/apache/sling/repoinit/parser/operations/AsRepoInitTest.java
##########
@@ -59,6 +62,21 @@ private static Reader rebuildInputScript(Reader input) throws Exception {
@Test
public void checkResultAsRepoInit() throws Exception {
- ParserTestCase.validate(rebuildInputScript(tc.input), tc.expected, tc);
+ try(ParserTestCase tc = testCaseSupplier.get()){
+ ParserTestCase.validate(rebuildInputScript(tc.input), tc.expected, tc);
+ }
+ }
+
+ @Test
+ public void checkRepoInitStatementNewline() throws Exception {
+ try (ParserTestCase tc = testCaseSupplier.get()) {
+ for (Operation o : new RepoInitParserService().parse(tc.input)) {
+ String repoinitStatement = o.asRepoInitString();
+ assertTrue(
Review comment:
same here. please add a whitespace before the (
##########
File path: src/test/java/org/apache/sling/repoinit/parser/test/ParserTestCase.java
##########
@@ -118,4 +123,27 @@ public static void validate(Reader validateInput, InputStream validateExpected,
}
return result;
}
+
+ public static Collection<Object[]> buildTestDataSuppliers() throws IOException {
+ final List<Object[]> result = new ArrayList<>();
+ for (int i = 0; i <= MAX_TEST_INDEX; i++) {
+ final int currentIdx = i;
+ Supplier<ParserTestCase> supplier = () -> {
+ try {
+ return ParserTestCase.build(currentIdx);
+ } catch (IOException e) {
+ return null;
+ }
+ };
+ try (ParserTestCase tc = supplier.get()) {
+ if(tc != null){
Review comment:
same here..... should be
`if (tc != null) {`
instead of
`if(tc != null){`
having consistent formatting helps the readability of the code and prevents broken window syndrom that happen when code looks bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org