You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "desaikomal (via GitHub)" <gi...@apache.org> on 2023/05/01 15:31:53 UTC

[GitHub] [helix] desaikomal opened a new pull request, #2467: Small change for performance optimization.

desaikomal opened a new pull request, #2467:
URL: https://github.com/apache/helix/pull/2467

   ### Issues
   
   - [ ] My PR addresses the following Helix issues and references them in the PR description:
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   String.format() is a very expensive call compare to regular '+'. I wrote a small program which did benchmarking for 10K property path creation.
   
   java testStringPerformance
   StringFormat = 107 millisecond
   String Concat = 41 millisecond
   String Builder = 5 millisecond
   String Replace = 22 millisecond
   
   So using StringBuilder for any path which has more than 2 variables and String concat for just 1 variable.
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   (List the names of added unit/integration tests)
   
   - The following is the result of the "mvn test" command on the appropriate module:
   
   
   Testing done:
   Local test completed:
   [ERROR] Failures:
   [ERROR]   TestNoThrottleDisabledPartitions.testDisablingTopStateReplicaByDisablingInstance:98 expected:<false> but was:<true>
   [ERROR]   TestNoThrottleDisabledPartitions.testNoThrottleOnDisabledInstance:231->setupEnvironment:317->setupCluster:436 ยป ZkClient
   [ERROR]   TestP2PNoDuplicatedMessage.testP2PStateTransitionEnabled:180 expected:<true> but was:<false>
   [ERROR]   TestRoutingTableProvider.testCustomizedViewCorrectConstructor:315 expected:<true> but was:<false>
   [ERROR]   TestResourceThreadpoolSize.testBatchMessageThreadPoolSize:206 expected:<true> but was:<false>
   [ERROR] Tests run: 1326, Failures: 5, Errors: 0, Skipped: 1
   
   (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
   
   ### Changes that Break Backward Compatibility (Optional)
   
   - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
   
   (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] xyuanlu merged pull request #2467: Small change for performance optimization.

Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #2467:
URL: https://github.com/apache/helix/pull/2467


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] desaikomal commented on pull request #2467: Small change for performance optimization.

Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2467:
URL: https://github.com/apache/helix/pull/2467#issuecomment-1530047146

   Thanks @qqu0127 and @xyuanlu for reviewing and approving the change.
   Commit message
   Small performance optimization wrt using String.format(). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org