You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "Victor J. Orlikowski" <v....@gte.net> on 2000/08/31 19:28:57 UTC

[PATCH] Bunches upon bunches of type clean-ups.

These type clean-ups are needed to build on AIX using xlC.

Index: src/ap/ap_buckets.c
===================================================================
RCS file: /cvs/apache/apache-2.0/src/ap/ap_buckets.c,v
retrieving revision 1.11
diff -u -r1.11 ap_buckets.c
--- ap_buckets.c	2000/08/20 03:33:08	1.11
+++ ap_buckets.c	2000/08/31 17:15:49
@@ -208,7 +208,8 @@
      */
     char buf[4096];
     ap_bucket *r;
-    int res, i;
+    int res;
+    long i;
 
     res = apr_vsnprintf(buf, 4096, fmt, va);
 
Index: src/main/http_core.c
===================================================================
RCS file: /cvs/apache/apache-2.0/src/main/http_core.c,v
retrieving revision 1.111
diff -u -r1.111 http_core.c
--- http_core.c	2000/08/30 01:09:02	1.111
+++ http_core.c	2000/08/31 17:15:53
@@ -2922,7 +2922,8 @@
 static apr_status_t chunk_filter(ap_filter_t *f, ap_bucket_brigade *b)
 {
     ap_bucket *dptr = b->head, *lb, *next, *tail;
-    int len = 0, cur_len;
+    int len = 0;
+    long cur_len;
     char lenstr[sizeof("ffffffff\r\n")];
     const char *cur_str;
     int hit_eos = 0;
@@ -3019,7 +3020,7 @@
     apr_status_t rv;
     apr_ssize_t bytes_sent = 0;
     ap_bucket *dptr = b->head;
-    int len = 0, written;
+    long len = 0, written;
     const char *str;
 
 #if 0

Victor
-- 
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
vjo@raleigh.ibm.com
vjo@us.ibm.com


Re: [PATCH] Bunches upon bunches of type clean-ups.

Posted by "Victor J. Orlikowski" <v....@gte.net>.
Yeah, apr_ssize_t does seem right. My apologies.

Victor
-- 
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
vjo@raleigh.ibm.com
vjo@us.ibm.com


Re: [PATCH] Bunches upon bunches of type clean-ups.

Posted by Jeff Trawick <tr...@bellsouth.net>.
"Victor J. Orlikowski" <v....@gte.net> writes:

> These type clean-ups are needed to build on AIX using xlC.
> 
> Index: src/ap/ap_buckets.c
> ===================================================================
> RCS file: /cvs/apache/apache-2.0/src/ap/ap_buckets.c,v
> retrieving revision 1.11
> diff -u -r1.11 ap_buckets.c
> --- ap_buckets.c	2000/08/20 03:33:08	1.11
> +++ ap_buckets.c	2000/08/31 17:15:49
> @@ -208,7 +208,8 @@
>       */
>      char buf[4096];
>      ap_bucket *r;
> -    int res, i;
> +    int res;
> +    long i;

Shouldn't i be apr_ssize_t instead of long?  The last parm of
ap_bucket_create_heap() is declared as apr_ssize_t (I believe you if
you say that apr_ssize_t is long on your platform, but I don't care :)
).

I think the same comment applies to your proposed changes to
http_core.c.

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...