You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Frank Bille <fr...@gmail.com> on 2007/03/03 15:37:56 UTC

Re: Bug in new serialization?

... and you reproduce the bug by doing:


   1. Start quickstart, (duh)
   2. Click on first link
   3. browser back
   4. Click on first link again (or second link.... second link isn't
   really part of the problem. Perhaps I should just have removed it)


Frank


On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
>
> Hey guys
>
> I haven't really followed the custom serialization discussion, but I think
> I have found a bug. Johan if you already knows about it, please ignore this
> mail :).
>
> If one of the classes which are going to be serialized doesn't have a
> default constructor the de-serialization fails with a nullpointer exception.
> I have created a quickstart which shows this (using java.util.Locale as
> the "sinner").
>
>
> Frank
>
> P.s. based on latest wicket 1.x (rev: 514156)
>
>

Re: Bug in new serialization?

Posted by Johan Compagner <jc...@gmail.com>.
thats fine by me that we don't have it in a release
But i will try to look at it ASAP.

johan


On 3/4/07, Frank Bille <fr...@gmail.com> wrote:
>
> If this is not fixed before we release 1.3 alphabeta, I think we have to
> turn it of per default.
>
> Frank
>
>
> On 3/3/07, Johan Compagner <jc...@gmail.com> wrote:
> >
> > The serialization is not enabled by default. So maybe it is the
> > filepagestore that is causing this problem
> > Will look into this.
> >
> > johan
> >
> >
> > On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> > >
> > > I have created this issue because I'm not sure my email reached the
> > > mailing
> > > list:
> > >
> > > https://issues.apache.org/jira/browse/WICKET-351
> > >
> > >
> > > On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> > > >
> > > > ... and you reproduce the bug by doing:
> > > >
> > > >
> > > >    1. Start quickstart, (duh)
> > > >    2. Click on first link
> > > >    3. browser back
> > > >    4. Click on first link again (or second link.... second link
> isn't
> > > >    really part of the problem. Perhaps I should just have removed
> it)
> > > >
> > > >
> > > > Frank
> > > >
> > > >
> > > > On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> > > > >
> > > > > Hey guys
> > > > >
> > > > > I haven't really followed the custom serialization discussion, but
> I
> > > > > think I have found a bug. Johan if you already knows about it,
> > please
> > > ignore
> > > > > this mail :).
> > > > >
> > > > > If one of the classes which are going to be serialized doesn't
> have
> > a
> > > > > default constructor the de-serialization fails with a nullpointer
> > > exception.
> > > > > I have created a quickstart which shows this (using
> > java.util.Localeas
> > > > > the "sinner").
> > > > >
> > > > >
> > > > > Frank
> > > > >
> > > > > P.s. based on latest wicket 1.x (rev: 514156)
> > > > >
> > > > >
> > > >
> > >
> >
>

Re: Bug in new serialization?

Posted by Frank Bille <fr...@gmail.com>.
If this is not fixed before we release 1.3 alphabeta, I think we have to
turn it of per default.

Frank


On 3/3/07, Johan Compagner <jc...@gmail.com> wrote:
>
> The serialization is not enabled by default. So maybe it is the
> filepagestore that is causing this problem
> Will look into this.
>
> johan
>
>
> On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> >
> > I have created this issue because I'm not sure my email reached the
> > mailing
> > list:
> >
> > https://issues.apache.org/jira/browse/WICKET-351
> >
> >
> > On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> > >
> > > ... and you reproduce the bug by doing:
> > >
> > >
> > >    1. Start quickstart, (duh)
> > >    2. Click on first link
> > >    3. browser back
> > >    4. Click on first link again (or second link.... second link isn't
> > >    really part of the problem. Perhaps I should just have removed it)
> > >
> > >
> > > Frank
> > >
> > >
> > > On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> > > >
> > > > Hey guys
> > > >
> > > > I haven't really followed the custom serialization discussion, but I
> > > > think I have found a bug. Johan if you already knows about it,
> please
> > ignore
> > > > this mail :).
> > > >
> > > > If one of the classes which are going to be serialized doesn't have
> a
> > > > default constructor the de-serialization fails with a nullpointer
> > exception.
> > > > I have created a quickstart which shows this (using
> java.util.Localeas
> > > > the "sinner").
> > > >
> > > >
> > > > Frank
> > > >
> > > > P.s. based on latest wicket 1.x (rev: 514156)
> > > >
> > > >
> > >
> >
>

Re: Bug in new serialization?

Posted by Eelco Hillenius <ee...@gmail.com>.
Fixed.

Eelco

On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> On 3/3/07, Eelco Hillenius <ee...@gmail.com> wrote:
> >
> > It is! I changed it back for you (even though I didn't agree, but
> > that's how the voting works) after I changed the error message to
> > include instructions on how to turn it off.
> >
>
> .. and that is actually pretty nice. I have turned it of for a live system
> for now until it is fixed.
>
> There is a typo in the exception (I don't have the code checked out right
> now)
>
> java.util.Objects => wicket.util.Objects
>
> Frank
>

Re: Bug in new serialization?

Posted by Frank Bille <fr...@gmail.com>.
On 3/3/07, Eelco Hillenius <ee...@gmail.com> wrote:
>
> It is! I changed it back for you (even though I didn't agree, but
> that's how the voting works) after I changed the error message to
> include instructions on how to turn it off.
>

.. and that is actually pretty nice. I have turned it of for a live system
for now until it is fixed.

There is a typo in the exception (I don't have the code checked out right
now)

java.util.Objects => wicket.util.Objects

Frank

Re: Bug in new serialization?

Posted by Eelco Hillenius <ee...@gmail.com>.
It is! I changed it back for you (even though I didn't agree, but
that's how the voting works) after I changed the error message to
include instructions on how to turn it off.

Eelco

On 3/3/07, Johan Compagner <jc...@gmail.com> wrote:
> The serialization is not enabled by default. So maybe it is the
> filepagestore that is causing this problem
> Will look into this.
>
> johan
>
>
> On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> >
> > I have created this issue because I'm not sure my email reached the
> > mailing
> > list:
> >
> > https://issues.apache.org/jira/browse/WICKET-351
> >
> >
> > On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> > >
> > > ... and you reproduce the bug by doing:
> > >
> > >
> > >    1. Start quickstart, (duh)
> > >    2. Click on first link
> > >    3. browser back
> > >    4. Click on first link again (or second link.... second link isn't
> > >    really part of the problem. Perhaps I should just have removed it)
> > >
> > >
> > > Frank
> > >
> > >
> > > On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> > > >
> > > > Hey guys
> > > >
> > > > I haven't really followed the custom serialization discussion, but I
> > > > think I have found a bug. Johan if you already knows about it, please
> > ignore
> > > > this mail :).
> > > >
> > > > If one of the classes which are going to be serialized doesn't have a
> > > > default constructor the de-serialization fails with a nullpointer
> > exception.
> > > > I have created a quickstart which shows this (using java.util.Localeas
> > > > the "sinner").
> > > >
> > > >
> > > > Frank
> > > >
> > > > P.s. based on latest wicket 1.x (rev: 514156)
> > > >
> > > >
> > >
> >
>

Re: Bug in new serialization?

Posted by Johan Compagner <jc...@gmail.com>.
The serialization is not enabled by default. So maybe it is the
filepagestore that is causing this problem
Will look into this.

johan


On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
>
> I have created this issue because I'm not sure my email reached the
> mailing
> list:
>
> https://issues.apache.org/jira/browse/WICKET-351
>
>
> On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> >
> > ... and you reproduce the bug by doing:
> >
> >
> >    1. Start quickstart, (duh)
> >    2. Click on first link
> >    3. browser back
> >    4. Click on first link again (or second link.... second link isn't
> >    really part of the problem. Perhaps I should just have removed it)
> >
> >
> > Frank
> >
> >
> > On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> > >
> > > Hey guys
> > >
> > > I haven't really followed the custom serialization discussion, but I
> > > think I have found a bug. Johan if you already knows about it, please
> ignore
> > > this mail :).
> > >
> > > If one of the classes which are going to be serialized doesn't have a
> > > default constructor the de-serialization fails with a nullpointer
> exception.
> > > I have created a quickstart which shows this (using java.util.Localeas
> > > the "sinner").
> > >
> > >
> > > Frank
> > >
> > > P.s. based on latest wicket 1.x (rev: 514156)
> > >
> > >
> >
>

Re: Bug in new serialization?

Posted by Frank Bille <fr...@gmail.com>.
I have created this issue because I'm not sure my email reached the mailing
list:

https://issues.apache.org/jira/browse/WICKET-351


On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
>
> ... and you reproduce the bug by doing:
>
>
>    1. Start quickstart, (duh)
>    2. Click on first link
>    3. browser back
>    4. Click on first link again (or second link.... second link isn't
>    really part of the problem. Perhaps I should just have removed it)
>
>
> Frank
>
>
> On 3/3/07, Frank Bille <fr...@gmail.com> wrote:
> >
> > Hey guys
> >
> > I haven't really followed the custom serialization discussion, but I
> > think I have found a bug. Johan if you already knows about it, please ignore
> > this mail :).
> >
> > If one of the classes which are going to be serialized doesn't have a
> > default constructor the de-serialization fails with a nullpointer exception.
> > I have created a quickstart which shows this (using java.util.Locale as
> > the "sinner").
> >
> >
> > Frank
> >
> > P.s. based on latest wicket 1.x (rev: 514156)
> >
> >
>