[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #641: tools/testbuild.sh: Make blacklist work on macOS

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #641: tools/testbuild.sh: Make blacklist work on macOS
URL: https://github.com/apache/incubator-nuttx/pull/641#discussion_r399668324
 
 

 ##########
 File path: tools/testbuild.sh
 ##########
 @@ -198,8 +198,8 @@ function build {
 function dotest {
   echo "===================================================================================="
   config=`echo $1 | cut -d',' -f1`
-  re=\\b${config/\//:}\\b
-  if [[ $blacklist =~ $re ]]; then
+  re="-${config/\//:}[[:space:]]"
+  if [[ "${blacklist} " =~ $re ]]; then
     echo "Skipping: $1"
 
 Review comment:
   Isn't the test redundant anyway?
   `dotest` is called with configs from `testlist` which is the opposite of `blacklist`.
   
   > I couldn't find where "\b" was documented.
   
   How about this one: https://www.rexegg.com/regex-boundaries.html#wordboundary

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services