[jira] Created: (MYFACES-165) exception handling in HtmlGridRenderer.renderChildren(..)

["Mathias Broekelmann (JIRA)" <in...@incubator.apache.org>]

exception handling in HtmlGridRenderer.renderChildren(..)
---------------------------------------------------------

         Key: MYFACES-165
         URL: http://issues.apache.org/jira/browse/MYFACES-165
     Project: MyFaces
        Type: Wish
    Versions: Nightly Build    
    Reporter: Mathias Broekelmann
    Priority: Trivial


IOException and rethrown without any action (seems to be a debug point)
RuntimeException is  catched, logged and rethrown.

At least the log.error(...) call should be removed to avoid large stacktraces.

Here is a patch:

Index: HtmlGridRenderer.java
===================================================================
RCS file: /home/cvspublic/incubator-myfaces/src/myfaces/org/apache/myfaces/renderkit/html/HtmlGridRenderer.java,v
retrieving revision 1.16
diff -u -r1.16 HtmlGridRenderer.java
--- HtmlGridRenderer.java	23 Dec 2004 13:03:08 -0000	1.16
+++ HtmlGridRenderer.java	5 Apr 2005 07:51:35 -0000
@@ -187,8 +187,6 @@
                                 int columns)
         throws IOException
     {
-        try
-        {
             writer.startElement(HTML.TBODY_ELEM, component);
 
             String columnClasses;
@@ -282,16 +280,6 @@
             }
 
             writer.endElement(HTML.TBODY_ELEM);
-        }
-        catch(IOException ex)
-        {
-            throw ex;
-        }
-        catch(RuntimeException ex2)
-        {
-            log.error("Exception while rendering children of panel-grid.",ex2);
-            throw ex2;
-        }
     }
 
 }


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira