You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@seata.apache.org by "YongGoose (via GitHub)" <gi...@apache.org> on 2025/06/15 04:49:51 UTC

[I] Some tests were skipped after recent changes(#7435) [incubator-seata]

YongGoose opened a new issue, #7440:
URL: https://github.com/apache/incubator-seata/issues/7440

### Check Ahead

- [x] I have searched the [issues](https://github.com/seata/seata/issues) of this repository and believe that this is not a duplicate.

### Ⅰ. Issue Description

It seems that some tests in the core module were skipped.

After reviewing the classes indirectly affected by the recent changes, most of them are located in the core module.

It might be necessary to investigate the relationship between
- The modified ports
- Test classes covering the related core module classes.

### Ⅱ. Describe what happened

See
https://app.codecov.io/gh/apache/incubator-seata/pull/7435/indirect-changes

### Ⅲ. Describe what you expected to happen

_No response_

### Ⅳ. How to reproduce it (as minimally and precisely as possible)

_No response_

### Ⅴ. Anything else we need to know?

It would be good to briefly analyze the current situation first, and then proceed with the task.
If you share your analysis in a comment, I’ll provide feedback.

### Ⅵ. Environment

_No response_

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [I] Some tests were skipped after recent changes(#7435) [incubator-seata]

Posted by "WangzJi (via GitHub)" <gi...@apache.org>.

WangzJi commented on issue #7440:
URL: https://github.com/apache/incubator-seata/issues/7440#issuecomment-2987940434

   After analyzing the code more carefully, I found that `TmNettyClientTest` creates its own embedded server internally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [I] Some tests were skipped after recent changes(#7435) [incubator-seata]

Posted by "WangzJi (via GitHub)" <gi...@apache.org>.

WangzJi commented on issue #7440:
URL: https://github.com/apache/incubator-seata/issues/7440#issuecomment-2987893557

   As you mentioned, it seems there's a port configuration mismatch between modules, which might be causing the connection issues during test execution.
   
   - https://github.com/apache/incubator-seata/blob/ac9c8bab0f3c329d39f87f920d4bc978d8a45d3d/test/src/test/java/org/apache/seata/core/rpc/netty/TmNettyClientTest.java#L51-L54
   - https://github.com/apache/incubator-seata/blob/ac9c8bab0f3c329d39f87f920d4bc978d8a45d3d/core/src/test/java/org/apache/seata/core/rpc/netty/TmNettyClientTest.java#L78-L111


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [I] Some tests were skipped after recent changes(#7435) [incubator-seata]

Posted by "YongGoose (via GitHub)" <gi...@apache.org>.

YongGoose commented on issue #7440:
URL: https://github.com/apache/incubator-seata/issues/7440#issuecomment-2987598762

   > [@YongGoose](https://github.com/YongGoose) Hi
   > 
   > Based on my investigation of the build logs, the coverage drop in core module after PR [#7435](https://github.com/apache/incubator-seata/pull/7435) appears to be caused by port conflicts.
   > 
   > From the CI build logs, I found connection failures in core module tests:
   > 
   > ```
   > 2025-06-13T09:23:25.4242455Z 09:23:25.402 [main] INFO org.apache.seata.core.rpc.netty.NettyClientChannelManager -- will connect to 127.0.0.1:8091
   > 2025-06-13T09:23:25.4247915Z 09:23:25.403 [main] INFO org.apache.seata.core.rpc.netty.RmNettyRemotingClient -- RM will register :jdbc:xx://localhost/test
   > 2025-06-13T09:23:25.4250828Z 09:23:25.404 [main] INFO org.apache.seata.core.rpc.netty.NettyPoolableFactory -- NettyPool create channel to transactionRole:RMROLE,address:127.0.0.1:8091,msg:< RegisterRMRequest{resourceIds='jdbc:xx://localhost/test', version='2.5.0-SNAPSHOT', applicationId='fail_fast', transactionServiceGroup='default_tx_group', extraData='null'} >
   > 2025-06-13T09:23:25.4280752Z 09:23:25.410 [configOperate_2_1_2] DEBUG org.apache.seata.config.FileConfiguration -- Could not found property transport.protocol, try to use default value instead. exception:No configuration setting found for key 'transport.protocol'
   > 2025-06-13T09:23:25.4283719Z 09:23:25.413 [configOperate_2_1_2] DEBUG org.apache.seata.config.FileConfiguration -- Could not found property transport.serialization, try to use default value instead. exception:No configuration setting found for key 'transport.serialization'
   > 2025-06-13T09:23:25.4286192Z 09:23:25.415 [NettyClientSelector_RMROLE_4_1_8] INFO org.apache.seata.core.rpc.netty.AbstractNettyRemotingClient -- ChannelHandlerContext(AbstractNettyRemotingClient$ClientHandler#0, [id: 0x63cf5273]) will closed
   > 2025-06-13T09:23:25.4288158Z 09:23:25.415 [main] ERROR org.apache.seata.core.rpc.netty.NettyClientChannelManager -- 0304 register RM failed.
   > 2025-06-13T09:23:25.4289460Z org.apache.seata.common.exception.FrameworkException: can not connect to services-server.
   > 2025-06-13T09:23:25.4290693Z 	at org.apache.seata.core.rpc.netty.NettyClientBootstrap.getNewChannel(NettyClientBootstrap.java:212)
   > ```
   > 
   > PR [#7435](https://github.com/apache/incubator-seata/pull/7435): Introduced dynamic port allocation in server module Core Module: Still uses hardcoded port 8091 for client connections
   
   Would you mind sharing where the port conflict occurred?
   
   From the logs, it seems that the RM failed to connect to the server. This could be because the server’s port was dynamically assigned and not actually listening on 8091 — or, as you mentioned, there might have been a conflict on port 8091 that prevented the connection.
   
   Do you happen to see any additional information in the logs?
   
   - https://github.com/apache/incubator-seata/blob/2.x/core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientBootstrap.java#L179-#L208


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [I] Some tests were skipped after recent changes(#7435) [incubator-seata]

Posted by "WangzJi (via GitHub)" <gi...@apache.org>.

WangzJi commented on issue #7440:
URL: https://github.com/apache/incubator-seata/issues/7440#issuecomment-2988102988

   Got it, please assign it to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [I] Some tests were skipped after recent changes(#7435) [incubator-seata]

Posted by "YongGoose (via GitHub)" <gi...@apache.org>.

YongGoose commented on issue #7440:
URL: https://github.com/apache/incubator-seata/issues/7440#issuecomment-2988215475

   @funky-eyes 
   
   We’ve made some progress on the issue we talked about previously, thanks in large part to @WangzJi's efforts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [I] Some tests were skipped after recent changes(#7435) [incubator-seata]

Posted by "YongGoose (via GitHub)" <gi...@apache.org>.

YongGoose commented on issue #7440:
URL: https://github.com/apache/incubator-seata/issues/7440#issuecomment-2987953094

   > As you mentioned, it seems there's a port configuration mismatch between modules, which might be causing the connection issues during test execution.
   
   ![Image](https://github.com/user-attachments/assets/9a4453fd-e95c-480c-be35-45c8f968bba3)
   
   Hmm… `SERVER_SERVICE_PORT_CAMEL` refers to "`server.servicePort`".
   Since the port number is already set dynamically as a system property, I don’t think there’s a need to explicitly set it to `8091` during initialization.
   
   How about removing the line that sets it to 8091(init method), creating a PR, and comparing the logs?
   
   If you’re able to take this on, I’ll assign it to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [I] Some tests were skipped after recent changes(#7435) [incubator-seata]

Posted by "WangzJi (via GitHub)" <gi...@apache.org>.

WangzJi commented on issue #7440:
URL: https://github.com/apache/incubator-seata/issues/7440#issuecomment-2987563934

   @YongGoose Hi
   
   Based on my investigation of the build logs, the coverage drop in core module after PR #7435 appears to be caused by port conflicts.
   
   From the CI build logs, I found connection failures in core module tests:
   ```
   2025-06-13T09:23:25.4242455Z 09:23:25.402 [main] INFO org.apache.seata.core.rpc.netty.NettyClientChannelManager -- will connect to 127.0.0.1:8091
   2025-06-13T09:23:25.4247915Z 09:23:25.403 [main] INFO org.apache.seata.core.rpc.netty.RmNettyRemotingClient -- RM will register :jdbc:xx://localhost/test
   2025-06-13T09:23:25.4250828Z 09:23:25.404 [main] INFO org.apache.seata.core.rpc.netty.NettyPoolableFactory -- NettyPool create channel to transactionRole:RMROLE,address:127.0.0.1:8091,msg:< RegisterRMRequest{resourceIds='jdbc:xx://localhost/test', version='2.5.0-SNAPSHOT', applicationId='fail_fast', transactionServiceGroup='default_tx_group', extraData='null'} >
   2025-06-13T09:23:25.4280752Z 09:23:25.410 [configOperate_2_1_2] DEBUG org.apache.seata.config.FileConfiguration -- Could not found property transport.protocol, try to use default value instead. exception:No configuration setting found for key 'transport.protocol'
   2025-06-13T09:23:25.4283719Z 09:23:25.413 [configOperate_2_1_2] DEBUG org.apache.seata.config.FileConfiguration -- Could not found property transport.serialization, try to use default value instead. exception:No configuration setting found for key 'transport.serialization'
   2025-06-13T09:23:25.4286192Z 09:23:25.415 [NettyClientSelector_RMROLE_4_1_8] INFO org.apache.seata.core.rpc.netty.AbstractNettyRemotingClient -- ChannelHandlerContext(AbstractNettyRemotingClient$ClientHandler#0, [id: 0x63cf5273]) will closed
   2025-06-13T09:23:25.4288158Z 09:23:25.415 [main] ERROR org.apache.seata.core.rpc.netty.NettyClientChannelManager -- 0304 register RM failed.
   2025-06-13T09:23:25.4289460Z org.apache.seata.common.exception.FrameworkException: can not connect to services-server.
   2025-06-13T09:23:25.4290693Z 	at org.apache.seata.core.rpc.netty.NettyClientBootstrap.getNewChannel(NettyClientBootstrap.java:212)
   ```
   PR #7435: Introduced dynamic port allocation in server module
   Core Module: Still uses hardcoded port 8091 for client connections
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [I] Some tests were skipped after recent changes(#7435) [incubator-seata]

Posted by "slievrly (via GitHub)" <gi...@apache.org>.

slievrly closed issue #7440: Some tests were skipped after recent changes(#7435)
URL: https://github.com/apache/incubator-seata/issues/7440


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org