You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2017/09/19 18:19:52 UTC
[incubator-superset] branch master updated: Removing dependency on
pythrifthiveapi (#3494)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new ccd5fd4 Removing dependency on pythrifthiveapi (#3494)
ccd5fd4 is described below
commit ccd5fd44cf33227dca4ac2280f5633719323b56e
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Sep 19 11:19:49 2017 -0700
Removing dependency on pythrifthiveapi (#3494)
Since the latest pyhive, we don't need pythrifthiveapi as they ship with
the latest version.
There's actually a conflict between the new pyhive and pythrifthiveapi
and this fixes it.
---
dev-reqs.txt | 1 -
superset/db_engine_specs.py | 2 +-
superset/db_engines/hive.py | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/dev-reqs.txt b/dev-reqs.txt
index c53fdef..0705bd2 100644
--- a/dev-reqs.txt
+++ b/dev-reqs.txt
@@ -7,7 +7,6 @@ mysqlclient
nose
psycopg2
pylint
-pythrifthiveapi
pyyaml
redis
statsd
diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py
index d44ba55..71c6ab2 100644
--- a/superset/db_engine_specs.py
+++ b/superset/db_engine_specs.py
@@ -668,7 +668,7 @@ class HiveEngineSpec(PrestoEngineSpec):
def patch(cls):
from pyhive import hive
from superset.db_engines import hive as patched_hive
- from pythrifthiveapi.TCLIService import (
+ from TCLIService import (
constants as patched_constants,
ttypes as patched_ttypes,
TCLIService as patched_TCLIService)
diff --git a/superset/db_engines/hive.py b/superset/db_engines/hive.py
index a31b4d7..f146084 100644
--- a/superset/db_engines/hive.py
+++ b/superset/db_engines/hive.py
@@ -1,5 +1,5 @@
from pyhive import hive
-from pythrifthiveapi.TCLIService import ttypes
+from TCLIService import ttypes
from thrift import Thrift
--
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <co...@superset.apache.org>'].