[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4745: [SegmentGeneratorConfig Cleanup] Replace checkTimeColumnValidityDuringGeneration with skipTimeValueCheck

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4745: [SegmentGeneratorConfig Cleanup] Replace checkTimeColumnValidityDuringGeneration with skipTimeValueCheck
URL: https://github.com/apache/incubator-pinot/pull/4745#discussion_r339715210
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/generator/SegmentGeneratorConfig.java
 ##########
 @@ -112,7 +112,7 @@
   private String _simpleDateFormat = null;
   // Use on-heap or off-heap memory to generate index (currently only affect inverted index and star-tree v2)
   private boolean _onHeap = false;
-  private boolean _checkTimeColumnValidityDuringGeneration = true;
+  private boolean _skipTimeValueCheck = false;
 
 Review comment:
   @siddharthteotia @mcvsubbu What I am saying is that for a config, the default value for boolean should be false (easier to use because user usually assumes that), and that is the reason why I changed the variable from `_checkTimeColumnValidityDuringGeneration` to `_skipTimeValueCheck`. I agree we should check time value by default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org