[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5896: fix: like and ilike not supported for LargeUtf8

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #5896:
URL: https://github.com/apache/arrow-datafusion/pull/5896#discussion_r1159870304


##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -233,7 +233,9 @@ macro_rules! compute_utf8_op_scalar {
             .as_any()
             .downcast_ref::<$DT>()
             .expect("compute_op failed to downcast left side array");
-        if let ScalarValue::Utf8(Some(string_value)) = $RIGHT {
+        if let ScalarValue::Utf8(Some(string_value))
+        | ScalarValue::LargeUtf8(Some(string_value)) = $RIGHT
+        {

Review Comment:
   I'm not sure if we should add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org