You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2013/06/16 18:52:27 UTC

Review Request: Removed-junk-characters-from-test_netscaler_lb.py.patch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11901/
-----------------------------------------------------------

Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Description
-------

Test case failed, due to some junk character in script

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/unittest/case.py", line 318, in run
    testMethod()
  File "/usr/local/lib/python2.7/site-packages/nose/loader.py", line 413, in loadTestsFromName
    addr.filename, addr.module)
  File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py", line 1089
SyntaxError: Non-ASCII character '\xe2' in file /Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py on line 1089, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details


Diffs
-----


Diff: https://reviews.apache.org/r/11901/diff/


Testing
-------

Tested


Thanks,

Rayees Namathponnan


Re: Review Request: Removed-junk-characters-from-test_netscaler_lb.py.patch

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11901/#review22048
-----------------------------------------------------------

Ship it!


85ed2160876826fa28088a716657f6c7bcbf84ec

- Prasanna Santhanam


On June 17, 2013, 11:47 p.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11901/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 11:47 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Test case failed, due to some junk character in script
> 
> Traceback (most recent call last):
>   File "/usr/local/lib/python2.7/unittest/case.py", line 318, in run
>     testMethod()
>   File "/usr/local/lib/python2.7/site-packages/nose/loader.py", line 413, in loadTestsFromName
>     addr.filename, addr.module)
>   File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
>     return self.importFromDir(dir_path, fqname)
>   File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
>     mod = load_module(part_fqname, fh, filename, desc)
>   File "/Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py", line 1089
> SyntaxError: Non-ASCII character '\xe2' in file /Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py on line 1089, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/11901/diff/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>


Re: Review Request: Removed-junk-characters-from-test_netscaler_lb.py.patch

Posted by Rayees Namathponnan <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11901/
-----------------------------------------------------------

(Updated June 17, 2013, 11:47 p.m.)


Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Changes
-------

Attaching Patch file


Description
-------

Test case failed, due to some junk character in script

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/unittest/case.py", line 318, in run
    testMethod()
  File "/usr/local/lib/python2.7/site-packages/nose/loader.py", line 413, in loadTestsFromName
    addr.filename, addr.module)
  File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py", line 1089
SyntaxError: Non-ASCII character '\xe2' in file /Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py on line 1089, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details


Diffs
-----


Diff: https://reviews.apache.org/r/11901/diff/


Testing
-------

Tested


Thanks,

Rayees Namathponnan


Re: Review Request: Removed-junk-characters-from-test_netscaler_lb.py.patch

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11901/#review21964
-----------------------------------------------------------


I think you've forgotten to attach the diff

- Prasanna Santhanam


On June 16, 2013, 4:52 p.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11901/
> -----------------------------------------------------------
> 
> (Updated June 16, 2013, 4:52 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Test case failed, due to some junk character in script
> 
> Traceback (most recent call last):
>   File "/usr/local/lib/python2.7/unittest/case.py", line 318, in run
>     testMethod()
>   File "/usr/local/lib/python2.7/site-packages/nose/loader.py", line 413, in loadTestsFromName
>     addr.filename, addr.module)
>   File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
>     return self.importFromDir(dir_path, fqname)
>   File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
>     mod = load_module(part_fqname, fh, filename, desc)
>   File "/Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py", line 1089
> SyntaxError: Non-ASCII character '\xe2' in file /Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py on line 1089, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/11901/diff/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>