You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/01/30 15:18:21 UTC

[13/44] hbase-site git commit: Published site at .

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/a3fb6d74/testdevapidocs/src-html/org/apache/hadoop/hbase/procedure/TestZKProcedure.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/procedure/TestZKProcedure.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/procedure/TestZKProcedure.html
index cc0fc25..c883e7f 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/procedure/TestZKProcedure.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/procedure/TestZKProcedure.html
@@ -26,398 +26,399 @@
 <span class="sourceLineNo">018</span>package org.apache.hadoop.hbase.procedure;<a name="line.18"></a>
 <span class="sourceLineNo">019</span><a name="line.19"></a>
 <span class="sourceLineNo">020</span>import static org.junit.Assert.assertEquals;<a name="line.20"></a>
-<span class="sourceLineNo">021</span>import static org.mockito.Matchers.any;<a name="line.21"></a>
-<span class="sourceLineNo">022</span>import static org.mockito.Matchers.anyListOf;<a name="line.22"></a>
-<span class="sourceLineNo">023</span>import static org.mockito.Matchers.eq;<a name="line.23"></a>
-<span class="sourceLineNo">024</span>import static org.mockito.Mockito.atMost;<a name="line.24"></a>
-<span class="sourceLineNo">025</span>import static org.mockito.Mockito.never;<a name="line.25"></a>
-<span class="sourceLineNo">026</span>import static org.mockito.Mockito.spy;<a name="line.26"></a>
-<span class="sourceLineNo">027</span>import static org.mockito.Mockito.when;<a name="line.27"></a>
-<span class="sourceLineNo">028</span><a name="line.28"></a>
-<span class="sourceLineNo">029</span>import java.io.IOException;<a name="line.29"></a>
-<span class="sourceLineNo">030</span>import java.util.ArrayList;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import java.util.Arrays;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import java.util.List;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import java.util.concurrent.CountDownLatch;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import java.util.concurrent.ThreadPoolExecutor;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import java.util.concurrent.atomic.AtomicInteger;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.Abortable;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.errorhandling.ForeignException;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.errorhandling.ForeignExceptionDispatcher;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.errorhandling.TimeoutException;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.procedure.Subprocedure.SubprocedureImpl;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.testclassification.MasterTests;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.util.Pair;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.zookeeper.ZKWatcher;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import org.junit.AfterClass;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.junit.BeforeClass;<a name="line.48"></a>
-<span class="sourceLineNo">049</span>import org.junit.ClassRule;<a name="line.49"></a>
-<span class="sourceLineNo">050</span>import org.junit.Test;<a name="line.50"></a>
-<span class="sourceLineNo">051</span>import org.junit.experimental.categories.Category;<a name="line.51"></a>
-<span class="sourceLineNo">052</span>import org.mockito.Mockito;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>import org.mockito.internal.matchers.ArrayEquals;<a name="line.53"></a>
-<span class="sourceLineNo">054</span>import org.mockito.invocation.InvocationOnMock;<a name="line.54"></a>
-<span class="sourceLineNo">055</span>import org.mockito.stubbing.Answer;<a name="line.55"></a>
-<span class="sourceLineNo">056</span>import org.mockito.verification.VerificationMode;<a name="line.56"></a>
-<span class="sourceLineNo">057</span>import org.slf4j.Logger;<a name="line.57"></a>
-<span class="sourceLineNo">058</span>import org.slf4j.LoggerFactory;<a name="line.58"></a>
-<span class="sourceLineNo">059</span><a name="line.59"></a>
-<span class="sourceLineNo">060</span>import org.apache.hbase.thirdparty.com.google.common.collect.Lists;<a name="line.60"></a>
-<span class="sourceLineNo">061</span><a name="line.61"></a>
-<span class="sourceLineNo">062</span>/**<a name="line.62"></a>
-<span class="sourceLineNo">063</span> * Cluster-wide testing of a distributed three-phase commit using a 'real' zookeeper cluster<a name="line.63"></a>
-<span class="sourceLineNo">064</span> */<a name="line.64"></a>
-<span class="sourceLineNo">065</span>@Category({MasterTests.class, MediumTests.class})<a name="line.65"></a>
-<span class="sourceLineNo">066</span>public class TestZKProcedure {<a name="line.66"></a>
-<span class="sourceLineNo">067</span><a name="line.67"></a>
-<span class="sourceLineNo">068</span>  @ClassRule<a name="line.68"></a>
-<span class="sourceLineNo">069</span>  public static final HBaseClassTestRule CLASS_RULE =<a name="line.69"></a>
-<span class="sourceLineNo">070</span>      HBaseClassTestRule.forClass(TestZKProcedure.class);<a name="line.70"></a>
-<span class="sourceLineNo">071</span><a name="line.71"></a>
-<span class="sourceLineNo">072</span>  private static final Logger LOG = LoggerFactory.getLogger(TestZKProcedure.class);<a name="line.72"></a>
-<span class="sourceLineNo">073</span>  private static HBaseTestingUtility UTIL = new HBaseTestingUtility();<a name="line.73"></a>
-<span class="sourceLineNo">074</span>  private static final String COORDINATOR_NODE_NAME = "coordinator";<a name="line.74"></a>
-<span class="sourceLineNo">075</span>  private static final long KEEP_ALIVE = 100; // seconds<a name="line.75"></a>
-<span class="sourceLineNo">076</span>  private static final int POOL_SIZE = 1;<a name="line.76"></a>
-<span class="sourceLineNo">077</span>  private static final long TIMEOUT = 10000; // when debugging make this larger for debugging<a name="line.77"></a>
-<span class="sourceLineNo">078</span>  private static final long WAKE_FREQUENCY = 500;<a name="line.78"></a>
-<span class="sourceLineNo">079</span>  private static final String opName = "op";<a name="line.79"></a>
-<span class="sourceLineNo">080</span>  private static final byte[] data = new byte[] { 1, 2 }; // TODO what is this used for?<a name="line.80"></a>
-<span class="sourceLineNo">081</span>  private static final VerificationMode once = Mockito.times(1);<a name="line.81"></a>
-<span class="sourceLineNo">082</span><a name="line.82"></a>
-<span class="sourceLineNo">083</span>  @BeforeClass<a name="line.83"></a>
-<span class="sourceLineNo">084</span>  public static void setupTest() throws Exception {<a name="line.84"></a>
-<span class="sourceLineNo">085</span>    UTIL.startMiniZKCluster();<a name="line.85"></a>
-<span class="sourceLineNo">086</span>  }<a name="line.86"></a>
-<span class="sourceLineNo">087</span><a name="line.87"></a>
-<span class="sourceLineNo">088</span>  @AfterClass<a name="line.88"></a>
-<span class="sourceLineNo">089</span>  public static void cleanupTest() throws Exception {<a name="line.89"></a>
-<span class="sourceLineNo">090</span>    UTIL.shutdownMiniZKCluster();<a name="line.90"></a>
-<span class="sourceLineNo">091</span>  }<a name="line.91"></a>
-<span class="sourceLineNo">092</span><a name="line.92"></a>
-<span class="sourceLineNo">093</span>  private static ZKWatcher newZooKeeperWatcher() throws IOException {<a name="line.93"></a>
-<span class="sourceLineNo">094</span>    return new ZKWatcher(UTIL.getConfiguration(), "testing utility", new Abortable() {<a name="line.94"></a>
-<span class="sourceLineNo">095</span>      @Override<a name="line.95"></a>
-<span class="sourceLineNo">096</span>      public void abort(String why, Throwable e) {<a name="line.96"></a>
-<span class="sourceLineNo">097</span>        throw new RuntimeException(<a name="line.97"></a>
-<span class="sourceLineNo">098</span>            "Unexpected abort in distributed three phase commit test:" + why, e);<a name="line.98"></a>
-<span class="sourceLineNo">099</span>      }<a name="line.99"></a>
-<span class="sourceLineNo">100</span><a name="line.100"></a>
-<span class="sourceLineNo">101</span>      @Override<a name="line.101"></a>
-<span class="sourceLineNo">102</span>      public boolean isAborted() {<a name="line.102"></a>
-<span class="sourceLineNo">103</span>        return false;<a name="line.103"></a>
-<span class="sourceLineNo">104</span>      }<a name="line.104"></a>
-<span class="sourceLineNo">105</span>    });<a name="line.105"></a>
-<span class="sourceLineNo">106</span>  }<a name="line.106"></a>
-<span class="sourceLineNo">107</span><a name="line.107"></a>
-<span class="sourceLineNo">108</span>  @Test<a name="line.108"></a>
-<span class="sourceLineNo">109</span>  public void testEmptyMemberSet() throws Exception {<a name="line.109"></a>
-<span class="sourceLineNo">110</span>    runCommit();<a name="line.110"></a>
-<span class="sourceLineNo">111</span>  }<a name="line.111"></a>
-<span class="sourceLineNo">112</span><a name="line.112"></a>
-<span class="sourceLineNo">113</span>  @Test<a name="line.113"></a>
-<span class="sourceLineNo">114</span>  public void testSingleMember() throws Exception {<a name="line.114"></a>
-<span class="sourceLineNo">115</span>    runCommit("one");<a name="line.115"></a>
-<span class="sourceLineNo">116</span>  }<a name="line.116"></a>
-<span class="sourceLineNo">117</span><a name="line.117"></a>
-<span class="sourceLineNo">118</span>  @Test<a name="line.118"></a>
-<span class="sourceLineNo">119</span>  public void testMultipleMembers() throws Exception {<a name="line.119"></a>
-<span class="sourceLineNo">120</span>    runCommit("one", "two", "three", "four" );<a name="line.120"></a>
-<span class="sourceLineNo">121</span>  }<a name="line.121"></a>
-<span class="sourceLineNo">122</span><a name="line.122"></a>
-<span class="sourceLineNo">123</span>  private void runCommit(String... members) throws Exception {<a name="line.123"></a>
-<span class="sourceLineNo">124</span>    // make sure we just have an empty list<a name="line.124"></a>
-<span class="sourceLineNo">125</span>    if (members == null) {<a name="line.125"></a>
-<span class="sourceLineNo">126</span>      members = new String[0];<a name="line.126"></a>
-<span class="sourceLineNo">127</span>    }<a name="line.127"></a>
-<span class="sourceLineNo">128</span>    List&lt;String&gt; expected = Arrays.asList(members);<a name="line.128"></a>
-<span class="sourceLineNo">129</span><a name="line.129"></a>
-<span class="sourceLineNo">130</span>    // setup the constants<a name="line.130"></a>
-<span class="sourceLineNo">131</span>    ZKWatcher coordZkw = newZooKeeperWatcher();<a name="line.131"></a>
-<span class="sourceLineNo">132</span>    String opDescription = "coordination test - " + members.length + " cohort members";<a name="line.132"></a>
-<span class="sourceLineNo">133</span><a name="line.133"></a>
-<span class="sourceLineNo">134</span>    // start running the controller<a name="line.134"></a>
-<span class="sourceLineNo">135</span>    ZKProcedureCoordinator coordinatorComms = new ZKProcedureCoordinator(<a name="line.135"></a>
-<span class="sourceLineNo">136</span>        coordZkw, opDescription, COORDINATOR_NODE_NAME);<a name="line.136"></a>
-<span class="sourceLineNo">137</span>    ThreadPoolExecutor pool = ProcedureCoordinator.defaultPool(COORDINATOR_NODE_NAME, POOL_SIZE, KEEP_ALIVE);<a name="line.137"></a>
-<span class="sourceLineNo">138</span>    ProcedureCoordinator coordinator = new ProcedureCoordinator(coordinatorComms, pool) {<a name="line.138"></a>
-<span class="sourceLineNo">139</span>      @Override<a name="line.139"></a>
-<span class="sourceLineNo">140</span>      public Procedure createProcedure(ForeignExceptionDispatcher fed, String procName, byte[] procArgs,<a name="line.140"></a>
-<span class="sourceLineNo">141</span>          List&lt;String&gt; expectedMembers) {<a name="line.141"></a>
-<span class="sourceLineNo">142</span>        return Mockito.spy(super.createProcedure(fed, procName, procArgs, expectedMembers));<a name="line.142"></a>
-<span class="sourceLineNo">143</span>      }<a name="line.143"></a>
-<span class="sourceLineNo">144</span>    };<a name="line.144"></a>
-<span class="sourceLineNo">145</span><a name="line.145"></a>
-<span class="sourceLineNo">146</span>    // build and start members<a name="line.146"></a>
-<span class="sourceLineNo">147</span>    // NOTE: There is a single subprocedure builder for all members here.<a name="line.147"></a>
-<span class="sourceLineNo">148</span>    SubprocedureFactory subprocFactory = Mockito.mock(SubprocedureFactory.class);<a name="line.148"></a>
-<span class="sourceLineNo">149</span>    List&lt;Pair&lt;ProcedureMember, ZKProcedureMemberRpcs&gt;&gt; procMembers = new ArrayList&lt;&gt;(members.length);<a name="line.149"></a>
-<span class="sourceLineNo">150</span>    // start each member<a name="line.150"></a>
-<span class="sourceLineNo">151</span>    for (String member : members) {<a name="line.151"></a>
-<span class="sourceLineNo">152</span>      ZKWatcher watcher = newZooKeeperWatcher();<a name="line.152"></a>
-<span class="sourceLineNo">153</span>      ZKProcedureMemberRpcs comms = new ZKProcedureMemberRpcs(watcher, opDescription);<a name="line.153"></a>
-<span class="sourceLineNo">154</span>      ThreadPoolExecutor pool2 = ProcedureMember.defaultPool(member, 1, KEEP_ALIVE);<a name="line.154"></a>
-<span class="sourceLineNo">155</span>      ProcedureMember procMember = new ProcedureMember(comms, pool2, subprocFactory);<a name="line.155"></a>
-<span class="sourceLineNo">156</span>      procMembers.add(new Pair&lt;&gt;(procMember, comms));<a name="line.156"></a>
-<span class="sourceLineNo">157</span>      comms.start(member, procMember);<a name="line.157"></a>
-<span class="sourceLineNo">158</span>    }<a name="line.158"></a>
-<span class="sourceLineNo">159</span><a name="line.159"></a>
-<span class="sourceLineNo">160</span>    // setup mock member subprocedures<a name="line.160"></a>
-<span class="sourceLineNo">161</span>    final List&lt;Subprocedure&gt; subprocs = new ArrayList&lt;&gt;();<a name="line.161"></a>
-<span class="sourceLineNo">162</span>    for (int i = 0; i &lt; procMembers.size(); i++) {<a name="line.162"></a>
-<span class="sourceLineNo">163</span>      ForeignExceptionDispatcher cohortMonitor = new ForeignExceptionDispatcher();<a name="line.163"></a>
-<span class="sourceLineNo">164</span>      Subprocedure commit = Mockito<a name="line.164"></a>
-<span class="sourceLineNo">165</span>      .spy(new SubprocedureImpl(procMembers.get(i).getFirst(), opName, cohortMonitor,<a name="line.165"></a>
-<span class="sourceLineNo">166</span>          WAKE_FREQUENCY, TIMEOUT));<a name="line.166"></a>
-<span class="sourceLineNo">167</span>      subprocs.add(commit);<a name="line.167"></a>
-<span class="sourceLineNo">168</span>    }<a name="line.168"></a>
-<span class="sourceLineNo">169</span><a name="line.169"></a>
-<span class="sourceLineNo">170</span>    // link subprocedure to buildNewOperation invocation.<a name="line.170"></a>
-<span class="sourceLineNo">171</span>    final AtomicInteger i = new AtomicInteger(0); // NOTE: would be racy if not an AtomicInteger<a name="line.171"></a>
-<span class="sourceLineNo">172</span>    Mockito.when(subprocFactory.buildSubprocedure(Mockito.eq(opName),<a name="line.172"></a>
-<span class="sourceLineNo">173</span>        (byte[]) Mockito.argThat(new ArrayEquals(data)))).thenAnswer(<a name="line.173"></a>
-<span class="sourceLineNo">174</span>      new Answer&lt;Subprocedure&gt;() {<a name="line.174"></a>
-<span class="sourceLineNo">175</span>        @Override<a name="line.175"></a>
-<span class="sourceLineNo">176</span>        public Subprocedure answer(InvocationOnMock invocation) throws Throwable {<a name="line.176"></a>
-<span class="sourceLineNo">177</span>          int index = i.getAndIncrement();<a name="line.177"></a>
-<span class="sourceLineNo">178</span>          LOG.debug("Task size:" + subprocs.size() + ", getting:" + index);<a name="line.178"></a>
-<span class="sourceLineNo">179</span>          Subprocedure commit = subprocs.get(index);<a name="line.179"></a>
-<span class="sourceLineNo">180</span>          return commit;<a name="line.180"></a>
-<span class="sourceLineNo">181</span>        }<a name="line.181"></a>
-<span class="sourceLineNo">182</span>      });<a name="line.182"></a>
-<span class="sourceLineNo">183</span><a name="line.183"></a>
-<span class="sourceLineNo">184</span>    // setup spying on the coordinator<a name="line.184"></a>
-<span class="sourceLineNo">185</span>//    Procedure proc = Mockito.spy(procBuilder.createProcedure(coordinator, opName, data, expected));<a name="line.185"></a>
-<span class="sourceLineNo">186</span>//    Mockito.when(procBuilder.build(coordinator, opName, data, expected)).thenReturn(proc);<a name="line.186"></a>
-<span class="sourceLineNo">187</span><a name="line.187"></a>
-<span class="sourceLineNo">188</span>    // start running the operation<a name="line.188"></a>
-<span class="sourceLineNo">189</span>    Procedure task = coordinator.startProcedure(new ForeignExceptionDispatcher(), opName, data, expected);<a name="line.189"></a>
-<span class="sourceLineNo">190</span>//    assertEquals("Didn't mock coordinator task", proc, task);<a name="line.190"></a>
-<span class="sourceLineNo">191</span><a name="line.191"></a>
-<span class="sourceLineNo">192</span>    // verify all things ran as expected<a name="line.192"></a>
-<span class="sourceLineNo">193</span>//    waitAndVerifyProc(proc, once, once, never(), once, false);<a name="line.193"></a>
-<span class="sourceLineNo">194</span>    waitAndVerifyProc(task, once, once, never(), once, false);<a name="line.194"></a>
-<span class="sourceLineNo">195</span>    verifyCohortSuccessful(expected, subprocFactory, subprocs, once, once, never(), once, false);<a name="line.195"></a>
-<span class="sourceLineNo">196</span><a name="line.196"></a>
-<span class="sourceLineNo">197</span>    // close all the things<a name="line.197"></a>
-<span class="sourceLineNo">198</span>    closeAll(coordinator, coordinatorComms, procMembers);<a name="line.198"></a>
-<span class="sourceLineNo">199</span>  }<a name="line.199"></a>
-<span class="sourceLineNo">200</span><a name="line.200"></a>
-<span class="sourceLineNo">201</span>  /**<a name="line.201"></a>
-<span class="sourceLineNo">202</span>   * Test a distributed commit with multiple cohort members, where one of the cohort members has a<a name="line.202"></a>
-<span class="sourceLineNo">203</span>   * timeout exception during the prepare stage.<a name="line.203"></a>
-<span class="sourceLineNo">204</span>   */<a name="line.204"></a>
-<span class="sourceLineNo">205</span>  @Test<a name="line.205"></a>
-<span class="sourceLineNo">206</span>  public void testMultiCohortWithMemberTimeoutDuringPrepare() throws Exception {<a name="line.206"></a>
-<span class="sourceLineNo">207</span>    String opDescription = "error injection coordination";<a name="line.207"></a>
-<span class="sourceLineNo">208</span>    String[] cohortMembers = new String[] { "one", "two", "three" };<a name="line.208"></a>
-<span class="sourceLineNo">209</span>    List&lt;String&gt; expected = Lists.newArrayList(cohortMembers);<a name="line.209"></a>
-<span class="sourceLineNo">210</span>    // error constants<a name="line.210"></a>
-<span class="sourceLineNo">211</span>    final int memberErrorIndex = 2;<a name="line.211"></a>
-<span class="sourceLineNo">212</span>    final CountDownLatch coordinatorReceivedErrorLatch = new CountDownLatch(1);<a name="line.212"></a>
-<span class="sourceLineNo">213</span><a name="line.213"></a>
-<span class="sourceLineNo">214</span>    // start running the coordinator and its controller<a name="line.214"></a>
-<span class="sourceLineNo">215</span>    ZKWatcher coordinatorWatcher = newZooKeeperWatcher();<a name="line.215"></a>
-<span class="sourceLineNo">216</span>    ZKProcedureCoordinator coordinatorController = new ZKProcedureCoordinator(<a name="line.216"></a>
-<span class="sourceLineNo">217</span>        coordinatorWatcher, opDescription, COORDINATOR_NODE_NAME);<a name="line.217"></a>
-<span class="sourceLineNo">218</span>    ThreadPoolExecutor pool = ProcedureCoordinator.defaultPool(COORDINATOR_NODE_NAME, POOL_SIZE, KEEP_ALIVE);<a name="line.218"></a>
-<span class="sourceLineNo">219</span>    ProcedureCoordinator coordinator = spy(new ProcedureCoordinator(coordinatorController, pool));<a name="line.219"></a>
-<span class="sourceLineNo">220</span><a name="line.220"></a>
-<span class="sourceLineNo">221</span>    // start a member for each node<a name="line.221"></a>
-<span class="sourceLineNo">222</span>    SubprocedureFactory subprocFactory = Mockito.mock(SubprocedureFactory.class);<a name="line.222"></a>
-<span class="sourceLineNo">223</span>    List&lt;Pair&lt;ProcedureMember, ZKProcedureMemberRpcs&gt;&gt; members = new ArrayList&lt;&gt;(expected.size());<a name="line.223"></a>
-<span class="sourceLineNo">224</span>    for (String member : expected) {<a name="line.224"></a>
-<span class="sourceLineNo">225</span>      ZKWatcher watcher = newZooKeeperWatcher();<a name="line.225"></a>
-<span class="sourceLineNo">226</span>      ZKProcedureMemberRpcs controller = new ZKProcedureMemberRpcs(watcher, opDescription);<a name="line.226"></a>
-<span class="sourceLineNo">227</span>      ThreadPoolExecutor pool2 = ProcedureMember.defaultPool(member, 1, KEEP_ALIVE);<a name="line.227"></a>
-<span class="sourceLineNo">228</span>      ProcedureMember mem = new ProcedureMember(controller, pool2, subprocFactory);<a name="line.228"></a>
-<span class="sourceLineNo">229</span>      members.add(new Pair&lt;&gt;(mem, controller));<a name="line.229"></a>
-<span class="sourceLineNo">230</span>      controller.start(member, mem);<a name="line.230"></a>
-<span class="sourceLineNo">231</span>    }<a name="line.231"></a>
-<span class="sourceLineNo">232</span><a name="line.232"></a>
-<span class="sourceLineNo">233</span>    // setup mock subprocedures<a name="line.233"></a>
-<span class="sourceLineNo">234</span>    final List&lt;Subprocedure&gt; cohortTasks = new ArrayList&lt;&gt;();<a name="line.234"></a>
-<span class="sourceLineNo">235</span>    final int[] elem = new int[1];<a name="line.235"></a>
-<span class="sourceLineNo">236</span>    for (int i = 0; i &lt; members.size(); i++) {<a name="line.236"></a>
-<span class="sourceLineNo">237</span>      ForeignExceptionDispatcher cohortMonitor = new ForeignExceptionDispatcher();<a name="line.237"></a>
-<span class="sourceLineNo">238</span>      final ProcedureMember comms = members.get(i).getFirst();<a name="line.238"></a>
-<span class="sourceLineNo">239</span>      Subprocedure commit = Mockito<a name="line.239"></a>
-<span class="sourceLineNo">240</span>      .spy(new SubprocedureImpl(comms, opName, cohortMonitor, WAKE_FREQUENCY, TIMEOUT));<a name="line.240"></a>
-<span class="sourceLineNo">241</span>      // This nasty bit has one of the impls throw a TimeoutException<a name="line.241"></a>
-<span class="sourceLineNo">242</span>      Mockito.doAnswer(new Answer&lt;Void&gt;() {<a name="line.242"></a>
-<span class="sourceLineNo">243</span>        @Override<a name="line.243"></a>
-<span class="sourceLineNo">244</span>        public Void answer(InvocationOnMock invocation) throws Throwable {<a name="line.244"></a>
-<span class="sourceLineNo">245</span>          int index = elem[0];<a name="line.245"></a>
-<span class="sourceLineNo">246</span>          if (index == memberErrorIndex) {<a name="line.246"></a>
-<span class="sourceLineNo">247</span>            LOG.debug("Sending error to coordinator");<a name="line.247"></a>
-<span class="sourceLineNo">248</span>            ForeignException remoteCause = new ForeignException("TIMER",<a name="line.248"></a>
-<span class="sourceLineNo">249</span>                new TimeoutException("subprocTimeout" , 1, 2, 0));<a name="line.249"></a>
-<span class="sourceLineNo">250</span>            Subprocedure r = ((Subprocedure) invocation.getMock());<a name="line.250"></a>
-<span class="sourceLineNo">251</span>            LOG.error("Remote commit failure, not propagating error:" + remoteCause);<a name="line.251"></a>
-<span class="sourceLineNo">252</span>            comms.receiveAbortProcedure(r.getName(), remoteCause);<a name="line.252"></a>
-<span class="sourceLineNo">253</span>            assertEquals(true, r.isComplete());<a name="line.253"></a>
-<span class="sourceLineNo">254</span>            // don't complete the error phase until the coordinator has gotten the error<a name="line.254"></a>
-<span class="sourceLineNo">255</span>            // notification (which ensures that we never progress past prepare)<a name="line.255"></a>
-<span class="sourceLineNo">256</span>            try {<a name="line.256"></a>
-<span class="sourceLineNo">257</span>              Procedure.waitForLatch(coordinatorReceivedErrorLatch, new ForeignExceptionDispatcher(),<a name="line.257"></a>
-<span class="sourceLineNo">258</span>                  WAKE_FREQUENCY, "coordinator received error");<a name="line.258"></a>
-<span class="sourceLineNo">259</span>            } catch (InterruptedException e) {<a name="line.259"></a>
-<span class="sourceLineNo">260</span>              LOG.debug("Wait for latch interrupted, done:" + (coordinatorReceivedErrorLatch.getCount() == 0));<a name="line.260"></a>
-<span class="sourceLineNo">261</span>              // reset the interrupt status on the thread<a name="line.261"></a>
-<span class="sourceLineNo">262</span>              Thread.currentThread().interrupt();<a name="line.262"></a>
-<span class="sourceLineNo">263</span>            }<a name="line.263"></a>
-<span class="sourceLineNo">264</span>          }<a name="line.264"></a>
-<span class="sourceLineNo">265</span>          elem[0] = ++index;<a name="line.265"></a>
-<span class="sourceLineNo">266</span>          return null;<a name="line.266"></a>
-<span class="sourceLineNo">267</span>        }<a name="line.267"></a>
-<span class="sourceLineNo">268</span>      }).when(commit).acquireBarrier();<a name="line.268"></a>
-<span class="sourceLineNo">269</span>      cohortTasks.add(commit);<a name="line.269"></a>
-<span class="sourceLineNo">270</span>    }<a name="line.270"></a>
-<span class="sourceLineNo">271</span><a name="line.271"></a>
-<span class="sourceLineNo">272</span>    // pass out a task per member<a name="line.272"></a>
-<span class="sourceLineNo">273</span>    final AtomicInteger taskIndex = new AtomicInteger();<a name="line.273"></a>
-<span class="sourceLineNo">274</span>    Mockito.when(<a name="line.274"></a>
-<span class="sourceLineNo">275</span>      subprocFactory.buildSubprocedure(Mockito.eq(opName),<a name="line.275"></a>
-<span class="sourceLineNo">276</span>        (byte[]) Mockito.argThat(new ArrayEquals(data)))).thenAnswer(<a name="line.276"></a>
-<span class="sourceLineNo">277</span>      new Answer&lt;Subprocedure&gt;() {<a name="line.277"></a>
-<span class="sourceLineNo">278</span>        @Override<a name="line.278"></a>
-<span class="sourceLineNo">279</span>        public Subprocedure answer(InvocationOnMock invocation) throws Throwable {<a name="line.279"></a>
-<span class="sourceLineNo">280</span>          int index = taskIndex.getAndIncrement();<a name="line.280"></a>
-<span class="sourceLineNo">281</span>          Subprocedure commit = cohortTasks.get(index);<a name="line.281"></a>
-<span class="sourceLineNo">282</span>          return commit;<a name="line.282"></a>
-<span class="sourceLineNo">283</span>        }<a name="line.283"></a>
-<span class="sourceLineNo">284</span>      });<a name="line.284"></a>
-<span class="sourceLineNo">285</span><a name="line.285"></a>
-<span class="sourceLineNo">286</span>    // setup spying on the coordinator<a name="line.286"></a>
-<span class="sourceLineNo">287</span>    ForeignExceptionDispatcher coordinatorTaskErrorMonitor = Mockito<a name="line.287"></a>
-<span class="sourceLineNo">288</span>        .spy(new ForeignExceptionDispatcher());<a name="line.288"></a>
-<span class="sourceLineNo">289</span>    Procedure coordinatorTask = Mockito.spy(new Procedure(coordinator,<a name="line.289"></a>
-<span class="sourceLineNo">290</span>        coordinatorTaskErrorMonitor, WAKE_FREQUENCY, TIMEOUT,<a name="line.290"></a>
-<span class="sourceLineNo">291</span>        opName, data, expected));<a name="line.291"></a>
-<span class="sourceLineNo">292</span>    when(coordinator.createProcedure(any(), eq(opName), eq(data), anyListOf(String.class)))<a name="line.292"></a>
-<span class="sourceLineNo">293</span>      .thenReturn(coordinatorTask);<a name="line.293"></a>
-<span class="sourceLineNo">294</span>    // count down the error latch when we get the remote error<a name="line.294"></a>
-<span class="sourceLineNo">295</span>    Mockito.doAnswer(new Answer&lt;Void&gt;() {<a name="line.295"></a>
-<span class="sourceLineNo">296</span>      @Override<a name="line.296"></a>
-<span class="sourceLineNo">297</span>      public Void answer(InvocationOnMock invocation) throws Throwable {<a name="line.297"></a>
-<span class="sourceLineNo">298</span>        // pass on the error to the master<a name="line.298"></a>
-<span class="sourceLineNo">299</span>        invocation.callRealMethod();<a name="line.299"></a>
-<span class="sourceLineNo">300</span>        // then count down the got error latch<a name="line.300"></a>
-<span class="sourceLineNo">301</span>        coordinatorReceivedErrorLatch.countDown();<a name="line.301"></a>
-<span class="sourceLineNo">302</span>        return null;<a name="line.302"></a>
-<span class="sourceLineNo">303</span>      }<a name="line.303"></a>
-<span class="sourceLineNo">304</span>    }).when(coordinatorTask).receive(Mockito.any());<a name="line.304"></a>
-<span class="sourceLineNo">305</span><a name="line.305"></a>
-<span class="sourceLineNo">306</span>    // ----------------------------<a name="line.306"></a>
-<span class="sourceLineNo">307</span>    // start running the operation<a name="line.307"></a>
-<span class="sourceLineNo">308</span>    // ----------------------------<a name="line.308"></a>
-<span class="sourceLineNo">309</span><a name="line.309"></a>
-<span class="sourceLineNo">310</span>    Procedure task = coordinator.startProcedure(coordinatorTaskErrorMonitor, opName, data, expected);<a name="line.310"></a>
-<span class="sourceLineNo">311</span>    assertEquals("Didn't mock coordinator task", coordinatorTask, task);<a name="line.311"></a>
-<span class="sourceLineNo">312</span><a name="line.312"></a>
-<span class="sourceLineNo">313</span>    // wait for the task to complete<a name="line.313"></a>
-<span class="sourceLineNo">314</span>    try {<a name="line.314"></a>
-<span class="sourceLineNo">315</span>      task.waitForCompleted();<a name="line.315"></a>
-<span class="sourceLineNo">316</span>    } catch (ForeignException fe) {<a name="line.316"></a>
-<span class="sourceLineNo">317</span>      // this may get caught or may not<a name="line.317"></a>
-<span class="sourceLineNo">318</span>    }<a name="line.318"></a>
-<span class="sourceLineNo">319</span><a name="line.319"></a>
-<span class="sourceLineNo">320</span>    // -------------<a name="line.320"></a>
-<span class="sourceLineNo">321</span>    // verification<a name="line.321"></a>
-<span class="sourceLineNo">322</span>    // -------------<a name="line.322"></a>
-<span class="sourceLineNo">323</span><a name="line.323"></a>
-<span class="sourceLineNo">324</span>    // always expect prepared, never committed, and possible to have cleanup and finish (racy since<a name="line.324"></a>
-<span class="sourceLineNo">325</span>    // error case)<a name="line.325"></a>
-<span class="sourceLineNo">326</span>    waitAndVerifyProc(coordinatorTask, once, never(), once, atMost(1), true);<a name="line.326"></a>
-<span class="sourceLineNo">327</span>    verifyCohortSuccessful(expected, subprocFactory, cohortTasks, once, never(), once,<a name="line.327"></a>
-<span class="sourceLineNo">328</span>      once, true);<a name="line.328"></a>
-<span class="sourceLineNo">329</span><a name="line.329"></a>
-<span class="sourceLineNo">330</span>    // close all the open things<a name="line.330"></a>
-<span class="sourceLineNo">331</span>    closeAll(coordinator, coordinatorController, members);<a name="line.331"></a>
-<span class="sourceLineNo">332</span>  }<a name="line.332"></a>
-<span class="sourceLineNo">333</span><a name="line.333"></a>
-<span class="sourceLineNo">334</span>  /**<a name="line.334"></a>
-<span class="sourceLineNo">335</span>   * Wait for the coordinator task to complete, and verify all the mocks<a name="line.335"></a>
-<span class="sourceLineNo">336</span>   * @param task to wait on<a name="line.336"></a>
-<span class="sourceLineNo">337</span>   * @throws Exception on unexpected failure<a name="line.337"></a>
-<span class="sourceLineNo">338</span>   */<a name="line.338"></a>
-<span class="sourceLineNo">339</span>  private void waitAndVerifyProc(Procedure proc, VerificationMode prepare,<a name="line.339"></a>
-<span class="sourceLineNo">340</span>      VerificationMode commit, VerificationMode cleanup, VerificationMode finish, boolean opHasError)<a name="line.340"></a>
-<span class="sourceLineNo">341</span>      throws Exception {<a name="line.341"></a>
-<span class="sourceLineNo">342</span>    boolean caughtError = false;<a name="line.342"></a>
-<span class="sourceLineNo">343</span>    try {<a name="line.343"></a>
-<span class="sourceLineNo">344</span>      proc.waitForCompleted();<a name="line.344"></a>
-<span class="sourceLineNo">345</span>    } catch (ForeignException fe) {<a name="line.345"></a>
-<span class="sourceLineNo">346</span>      caughtError = true;<a name="line.346"></a>
-<span class="sourceLineNo">347</span>    }<a name="line.347"></a>
-<span class="sourceLineNo">348</span>    // make sure that the task called all the expected phases<a name="line.348"></a>
-<span class="sourceLineNo">349</span>    Mockito.verify(proc, prepare).sendGlobalBarrierStart();<a name="line.349"></a>
-<span class="sourceLineNo">350</span>    Mockito.verify(proc, commit).sendGlobalBarrierReached();<a name="line.350"></a>
-<span class="sourceLineNo">351</span>    Mockito.verify(proc, finish).sendGlobalBarrierComplete();<a name="line.351"></a>
-<span class="sourceLineNo">352</span>    assertEquals("Operation error state was unexpected", opHasError, proc.getErrorMonitor()<a name="line.352"></a>
-<span class="sourceLineNo">353</span>        .hasException());<a name="line.353"></a>
-<span class="sourceLineNo">354</span>    assertEquals("Operation error state was unexpected", opHasError, caughtError);<a name="line.354"></a>
-<span class="sourceLineNo">355</span><a name="line.355"></a>
-<span class="sourceLineNo">356</span>  }<a name="line.356"></a>
-<span class="sourceLineNo">357</span><a name="line.357"></a>
-<span class="sourceLineNo">358</span>  /**<a name="line.358"></a>
-<span class="sourceLineNo">359</span>   * Wait for the coordinator task to complete, and verify all the mocks<a name="line.359"></a>
-<span class="sourceLineNo">360</span>   * @param task to wait on<a name="line.360"></a>
-<span class="sourceLineNo">361</span>   * @throws Exception on unexpected failure<a name="line.361"></a>
-<span class="sourceLineNo">362</span>   */<a name="line.362"></a>
-<span class="sourceLineNo">363</span>  private void waitAndVerifySubproc(Subprocedure op, VerificationMode prepare,<a name="line.363"></a>
-<span class="sourceLineNo">364</span>      VerificationMode commit, VerificationMode cleanup, VerificationMode finish, boolean opHasError)<a name="line.364"></a>
-<span class="sourceLineNo">365</span>      throws Exception {<a name="line.365"></a>
-<span class="sourceLineNo">366</span>    boolean caughtError = false;<a name="line.366"></a>
-<span class="sourceLineNo">367</span>    try {<a name="line.367"></a>
-<span class="sourceLineNo">368</span>      op.waitForLocallyCompleted();<a name="line.368"></a>
-<span class="sourceLineNo">369</span>    } catch (ForeignException fe) {<a name="line.369"></a>
-<span class="sourceLineNo">370</span>      caughtError = true;<a name="line.370"></a>
-<span class="sourceLineNo">371</span>    }<a name="line.371"></a>
-<span class="sourceLineNo">372</span>    // make sure that the task called all the expected phases<a name="line.372"></a>
-<span class="sourceLineNo">373</span>    Mockito.verify(op, prepare).acquireBarrier();<a name="line.373"></a>
-<span class="sourceLineNo">374</span>    Mockito.verify(op, commit).insideBarrier();<a name="line.374"></a>
-<span class="sourceLineNo">375</span>    // We cannot guarantee that cleanup has run so we don't check it.<a name="line.375"></a>
-<span class="sourceLineNo">376</span><a name="line.376"></a>
-<span class="sourceLineNo">377</span>    assertEquals("Operation error state was unexpected", opHasError, op.getErrorCheckable()<a name="line.377"></a>
-<span class="sourceLineNo">378</span>        .hasException());<a name="line.378"></a>
-<span class="sourceLineNo">379</span>    assertEquals("Operation error state was unexpected", opHasError, caughtError);<a name="line.379"></a>
-<span class="sourceLineNo">380</span><a name="line.380"></a>
-<span class="sourceLineNo">381</span>  }<a name="line.381"></a>
-<span class="sourceLineNo">382</span><a name="line.382"></a>
-<span class="sourceLineNo">383</span>  private void verifyCohortSuccessful(List&lt;String&gt; cohortNames,<a name="line.383"></a>
-<span class="sourceLineNo">384</span>      SubprocedureFactory subprocFactory, Iterable&lt;Subprocedure&gt; cohortTasks,<a name="line.384"></a>
-<span class="sourceLineNo">385</span>      VerificationMode prepare, VerificationMode commit, VerificationMode cleanup,<a name="line.385"></a>
-<span class="sourceLineNo">386</span>      VerificationMode finish, boolean opHasError) throws Exception {<a name="line.386"></a>
-<span class="sourceLineNo">387</span><a name="line.387"></a>
-<span class="sourceLineNo">388</span>    // make sure we build the correct number of cohort members<a name="line.388"></a>
-<span class="sourceLineNo">389</span>    Mockito.verify(subprocFactory, Mockito.times(cohortNames.size())).buildSubprocedure(<a name="line.389"></a>
-<span class="sourceLineNo">390</span>      Mockito.eq(opName), (byte[]) Mockito.argThat(new ArrayEquals(data)));<a name="line.390"></a>
-<span class="sourceLineNo">391</span>    // verify that we ran each of the operations cleanly<a name="line.391"></a>
-<span class="sourceLineNo">392</span>    int j = 0;<a name="line.392"></a>
-<span class="sourceLineNo">393</span>    for (Subprocedure op : cohortTasks) {<a name="line.393"></a>
-<span class="sourceLineNo">394</span>      LOG.debug("Checking mock:" + (j++));<a name="line.394"></a>
-<span class="sourceLineNo">395</span>      waitAndVerifySubproc(op, prepare, commit, cleanup, finish, opHasError);<a name="line.395"></a>
-<span class="sourceLineNo">396</span>    }<a name="line.396"></a>
-<span class="sourceLineNo">397</span>  }<a name="line.397"></a>
-<span class="sourceLineNo">398</span><a name="line.398"></a>
-<span class="sourceLineNo">399</span>  private void closeAll(<a name="line.399"></a>
-<span class="sourceLineNo">400</span>      ProcedureCoordinator coordinator,<a name="line.400"></a>
-<span class="sourceLineNo">401</span>      ZKProcedureCoordinator coordinatorController,<a name="line.401"></a>
-<span class="sourceLineNo">402</span>      List&lt;Pair&lt;ProcedureMember, ZKProcedureMemberRpcs&gt;&gt; cohort)<a name="line.402"></a>
-<span class="sourceLineNo">403</span>      throws IOException {<a name="line.403"></a>
-<span class="sourceLineNo">404</span>    // make sure we close all the resources<a name="line.404"></a>
-<span class="sourceLineNo">405</span>    for (Pair&lt;ProcedureMember, ZKProcedureMemberRpcs&gt; member : cohort) {<a name="line.405"></a>
-<span class="sourceLineNo">406</span>      member.getFirst().close();<a name="line.406"></a>
-<span class="sourceLineNo">407</span>      member.getSecond().close();<a name="line.407"></a>
-<span class="sourceLineNo">408</span>    }<a name="line.408"></a>
-<span class="sourceLineNo">409</span>    coordinator.close();<a name="line.409"></a>
-<span class="sourceLineNo">410</span>    coordinatorController.close();<a name="line.410"></a>
-<span class="sourceLineNo">411</span>  }<a name="line.411"></a>
-<span class="sourceLineNo">412</span>}<a name="line.412"></a>
+<span class="sourceLineNo">021</span>import static org.junit.Assert.assertTrue;<a name="line.21"></a>
+<span class="sourceLineNo">022</span>import static org.mockito.Matchers.any;<a name="line.22"></a>
+<span class="sourceLineNo">023</span>import static org.mockito.Matchers.anyListOf;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import static org.mockito.Matchers.eq;<a name="line.24"></a>
+<span class="sourceLineNo">025</span>import static org.mockito.Mockito.atMost;<a name="line.25"></a>
+<span class="sourceLineNo">026</span>import static org.mockito.Mockito.never;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import static org.mockito.Mockito.spy;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import static org.mockito.Mockito.when;<a name="line.28"></a>
+<span class="sourceLineNo">029</span><a name="line.29"></a>
+<span class="sourceLineNo">030</span>import java.io.IOException;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import java.util.ArrayList;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import java.util.Arrays;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import java.util.List;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import java.util.concurrent.CountDownLatch;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import java.util.concurrent.ThreadPoolExecutor;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import java.util.concurrent.atomic.AtomicInteger;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.Abortable;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.errorhandling.ForeignException;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.errorhandling.ForeignExceptionDispatcher;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.errorhandling.TimeoutException;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.procedure.Subprocedure.SubprocedureImpl;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.testclassification.MasterTests;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.util.Pair;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.zookeeper.ZKWatcher;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.junit.AfterClass;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.junit.BeforeClass;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.junit.ClassRule;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.junit.Test;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.junit.experimental.categories.Category;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>import org.mockito.Mockito;<a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.mockito.internal.matchers.ArrayEquals;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.mockito.invocation.InvocationOnMock;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>import org.mockito.stubbing.Answer;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import org.mockito.verification.VerificationMode;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import org.slf4j.Logger;<a name="line.58"></a>
+<span class="sourceLineNo">059</span>import org.slf4j.LoggerFactory;<a name="line.59"></a>
+<span class="sourceLineNo">060</span><a name="line.60"></a>
+<span class="sourceLineNo">061</span>import org.apache.hbase.thirdparty.com.google.common.collect.Lists;<a name="line.61"></a>
+<span class="sourceLineNo">062</span><a name="line.62"></a>
+<span class="sourceLineNo">063</span>/**<a name="line.63"></a>
+<span class="sourceLineNo">064</span> * Cluster-wide testing of a distributed three-phase commit using a 'real' zookeeper cluster<a name="line.64"></a>
+<span class="sourceLineNo">065</span> */<a name="line.65"></a>
+<span class="sourceLineNo">066</span>@Category({MasterTests.class, MediumTests.class})<a name="line.66"></a>
+<span class="sourceLineNo">067</span>public class TestZKProcedure {<a name="line.67"></a>
+<span class="sourceLineNo">068</span><a name="line.68"></a>
+<span class="sourceLineNo">069</span>  @ClassRule<a name="line.69"></a>
+<span class="sourceLineNo">070</span>  public static final HBaseClassTestRule CLASS_RULE =<a name="line.70"></a>
+<span class="sourceLineNo">071</span>      HBaseClassTestRule.forClass(TestZKProcedure.class);<a name="line.71"></a>
+<span class="sourceLineNo">072</span><a name="line.72"></a>
+<span class="sourceLineNo">073</span>  private static final Logger LOG = LoggerFactory.getLogger(TestZKProcedure.class);<a name="line.73"></a>
+<span class="sourceLineNo">074</span>  private static HBaseTestingUtility UTIL = new HBaseTestingUtility();<a name="line.74"></a>
+<span class="sourceLineNo">075</span>  private static final String COORDINATOR_NODE_NAME = "coordinator";<a name="line.75"></a>
+<span class="sourceLineNo">076</span>  private static final long KEEP_ALIVE = 100; // seconds<a name="line.76"></a>
+<span class="sourceLineNo">077</span>  private static final int POOL_SIZE = 1;<a name="line.77"></a>
+<span class="sourceLineNo">078</span>  private static final long TIMEOUT = 10000; // when debugging make this larger for debugging<a name="line.78"></a>
+<span class="sourceLineNo">079</span>  private static final long WAKE_FREQUENCY = 500;<a name="line.79"></a>
+<span class="sourceLineNo">080</span>  private static final String opName = "op";<a name="line.80"></a>
+<span class="sourceLineNo">081</span>  private static final byte[] data = new byte[] { 1, 2 }; // TODO what is this used for?<a name="line.81"></a>
+<span class="sourceLineNo">082</span>  private static final VerificationMode once = Mockito.times(1);<a name="line.82"></a>
+<span class="sourceLineNo">083</span><a name="line.83"></a>
+<span class="sourceLineNo">084</span>  @BeforeClass<a name="line.84"></a>
+<span class="sourceLineNo">085</span>  public static void setupTest() throws Exception {<a name="line.85"></a>
+<span class="sourceLineNo">086</span>    UTIL.startMiniZKCluster();<a name="line.86"></a>
+<span class="sourceLineNo">087</span>  }<a name="line.87"></a>
+<span class="sourceLineNo">088</span><a name="line.88"></a>
+<span class="sourceLineNo">089</span>  @AfterClass<a name="line.89"></a>
+<span class="sourceLineNo">090</span>  public static void cleanupTest() throws Exception {<a name="line.90"></a>
+<span class="sourceLineNo">091</span>    UTIL.shutdownMiniZKCluster();<a name="line.91"></a>
+<span class="sourceLineNo">092</span>  }<a name="line.92"></a>
+<span class="sourceLineNo">093</span><a name="line.93"></a>
+<span class="sourceLineNo">094</span>  private static ZKWatcher newZooKeeperWatcher() throws IOException {<a name="line.94"></a>
+<span class="sourceLineNo">095</span>    return new ZKWatcher(UTIL.getConfiguration(), "testing utility", new Abortable() {<a name="line.95"></a>
+<span class="sourceLineNo">096</span>      @Override<a name="line.96"></a>
+<span class="sourceLineNo">097</span>      public void abort(String why, Throwable e) {<a name="line.97"></a>
+<span class="sourceLineNo">098</span>        throw new RuntimeException(<a name="line.98"></a>
+<span class="sourceLineNo">099</span>            "Unexpected abort in distributed three phase commit test:" + why, e);<a name="line.99"></a>
+<span class="sourceLineNo">100</span>      }<a name="line.100"></a>
+<span class="sourceLineNo">101</span><a name="line.101"></a>
+<span class="sourceLineNo">102</span>      @Override<a name="line.102"></a>
+<span class="sourceLineNo">103</span>      public boolean isAborted() {<a name="line.103"></a>
+<span class="sourceLineNo">104</span>        return false;<a name="line.104"></a>
+<span class="sourceLineNo">105</span>      }<a name="line.105"></a>
+<span class="sourceLineNo">106</span>    });<a name="line.106"></a>
+<span class="sourceLineNo">107</span>  }<a name="line.107"></a>
+<span class="sourceLineNo">108</span><a name="line.108"></a>
+<span class="sourceLineNo">109</span>  @Test<a name="line.109"></a>
+<span class="sourceLineNo">110</span>  public void testEmptyMemberSet() throws Exception {<a name="line.110"></a>
+<span class="sourceLineNo">111</span>    runCommit();<a name="line.111"></a>
+<span class="sourceLineNo">112</span>  }<a name="line.112"></a>
+<span class="sourceLineNo">113</span><a name="line.113"></a>
+<span class="sourceLineNo">114</span>  @Test<a name="line.114"></a>
+<span class="sourceLineNo">115</span>  public void testSingleMember() throws Exception {<a name="line.115"></a>
+<span class="sourceLineNo">116</span>    runCommit("one");<a name="line.116"></a>
+<span class="sourceLineNo">117</span>  }<a name="line.117"></a>
+<span class="sourceLineNo">118</span><a name="line.118"></a>
+<span class="sourceLineNo">119</span>  @Test<a name="line.119"></a>
+<span class="sourceLineNo">120</span>  public void testMultipleMembers() throws Exception {<a name="line.120"></a>
+<span class="sourceLineNo">121</span>    runCommit("one", "two", "three", "four" );<a name="line.121"></a>
+<span class="sourceLineNo">122</span>  }<a name="line.122"></a>
+<span class="sourceLineNo">123</span><a name="line.123"></a>
+<span class="sourceLineNo">124</span>  private void runCommit(String... members) throws Exception {<a name="line.124"></a>
+<span class="sourceLineNo">125</span>    // make sure we just have an empty list<a name="line.125"></a>
+<span class="sourceLineNo">126</span>    if (members == null) {<a name="line.126"></a>
+<span class="sourceLineNo">127</span>      members = new String[0];<a name="line.127"></a>
+<span class="sourceLineNo">128</span>    }<a name="line.128"></a>
+<span class="sourceLineNo">129</span>    List&lt;String&gt; expected = Arrays.asList(members);<a name="line.129"></a>
+<span class="sourceLineNo">130</span><a name="line.130"></a>
+<span class="sourceLineNo">131</span>    // setup the constants<a name="line.131"></a>
+<span class="sourceLineNo">132</span>    ZKWatcher coordZkw = newZooKeeperWatcher();<a name="line.132"></a>
+<span class="sourceLineNo">133</span>    String opDescription = "coordination test - " + members.length + " cohort members";<a name="line.133"></a>
+<span class="sourceLineNo">134</span><a name="line.134"></a>
+<span class="sourceLineNo">135</span>    // start running the controller<a name="line.135"></a>
+<span class="sourceLineNo">136</span>    ZKProcedureCoordinator coordinatorComms = new ZKProcedureCoordinator(<a name="line.136"></a>
+<span class="sourceLineNo">137</span>        coordZkw, opDescription, COORDINATOR_NODE_NAME);<a name="line.137"></a>
+<span class="sourceLineNo">138</span>    ThreadPoolExecutor pool = ProcedureCoordinator.defaultPool(COORDINATOR_NODE_NAME, POOL_SIZE, KEEP_ALIVE);<a name="line.138"></a>
+<span class="sourceLineNo">139</span>    ProcedureCoordinator coordinator = new ProcedureCoordinator(coordinatorComms, pool) {<a name="line.139"></a>
+<span class="sourceLineNo">140</span>      @Override<a name="line.140"></a>
+<span class="sourceLineNo">141</span>      public Procedure createProcedure(ForeignExceptionDispatcher fed, String procName, byte[] procArgs,<a name="line.141"></a>
+<span class="sourceLineNo">142</span>          List&lt;String&gt; expectedMembers) {<a name="line.142"></a>
+<span class="sourceLineNo">143</span>        return Mockito.spy(super.createProcedure(fed, procName, procArgs, expectedMembers));<a name="line.143"></a>
+<span class="sourceLineNo">144</span>      }<a name="line.144"></a>
+<span class="sourceLineNo">145</span>    };<a name="line.145"></a>
+<span class="sourceLineNo">146</span><a name="line.146"></a>
+<span class="sourceLineNo">147</span>    // build and start members<a name="line.147"></a>
+<span class="sourceLineNo">148</span>    // NOTE: There is a single subprocedure builder for all members here.<a name="line.148"></a>
+<span class="sourceLineNo">149</span>    SubprocedureFactory subprocFactory = Mockito.mock(SubprocedureFactory.class);<a name="line.149"></a>
+<span class="sourceLineNo">150</span>    List&lt;Pair&lt;ProcedureMember, ZKProcedureMemberRpcs&gt;&gt; procMembers = new ArrayList&lt;&gt;(members.length);<a name="line.150"></a>
+<span class="sourceLineNo">151</span>    // start each member<a name="line.151"></a>
+<span class="sourceLineNo">152</span>    for (String member : members) {<a name="line.152"></a>
+<span class="sourceLineNo">153</span>      ZKWatcher watcher = newZooKeeperWatcher();<a name="line.153"></a>
+<span class="sourceLineNo">154</span>      ZKProcedureMemberRpcs comms = new ZKProcedureMemberRpcs(watcher, opDescription);<a name="line.154"></a>
+<span class="sourceLineNo">155</span>      ThreadPoolExecutor pool2 = ProcedureMember.defaultPool(member, 1, KEEP_ALIVE);<a name="line.155"></a>
+<span class="sourceLineNo">156</span>      ProcedureMember procMember = new ProcedureMember(comms, pool2, subprocFactory);<a name="line.156"></a>
+<span class="sourceLineNo">157</span>      procMembers.add(new Pair&lt;&gt;(procMember, comms));<a name="line.157"></a>
+<span class="sourceLineNo">158</span>      comms.start(member, procMember);<a name="line.158"></a>
+<span class="sourceLineNo">159</span>    }<a name="line.159"></a>
+<span class="sourceLineNo">160</span><a name="line.160"></a>
+<span class="sourceLineNo">161</span>    // setup mock member subprocedures<a name="line.161"></a>
+<span class="sourceLineNo">162</span>    final List&lt;Subprocedure&gt; subprocs = new ArrayList&lt;&gt;();<a name="line.162"></a>
+<span class="sourceLineNo">163</span>    for (int i = 0; i &lt; procMembers.size(); i++) {<a name="line.163"></a>
+<span class="sourceLineNo">164</span>      ForeignExceptionDispatcher cohortMonitor = new ForeignExceptionDispatcher();<a name="line.164"></a>
+<span class="sourceLineNo">165</span>      Subprocedure commit = Mockito<a name="line.165"></a>
+<span class="sourceLineNo">166</span>      .spy(new SubprocedureImpl(procMembers.get(i).getFirst(), opName, cohortMonitor,<a name="line.166"></a>
+<span class="sourceLineNo">167</span>          WAKE_FREQUENCY, TIMEOUT));<a name="line.167"></a>
+<span class="sourceLineNo">168</span>      subprocs.add(commit);<a name="line.168"></a>
+<span class="sourceLineNo">169</span>    }<a name="line.169"></a>
+<span class="sourceLineNo">170</span><a name="line.170"></a>
+<span class="sourceLineNo">171</span>    // link subprocedure to buildNewOperation invocation.<a name="line.171"></a>
+<span class="sourceLineNo">172</span>    final AtomicInteger i = new AtomicInteger(0); // NOTE: would be racy if not an AtomicInteger<a name="line.172"></a>
+<span class="sourceLineNo">173</span>    Mockito.when(subprocFactory.buildSubprocedure(Mockito.eq(opName),<a name="line.173"></a>
+<span class="sourceLineNo">174</span>        (byte[]) Mockito.argThat(new ArrayEquals(data)))).thenAnswer(<a name="line.174"></a>
+<span class="sourceLineNo">175</span>      new Answer&lt;Subprocedure&gt;() {<a name="line.175"></a>
+<span class="sourceLineNo">176</span>        @Override<a name="line.176"></a>
+<span class="sourceLineNo">177</span>        public Subprocedure answer(InvocationOnMock invocation) throws Throwable {<a name="line.177"></a>
+<span class="sourceLineNo">178</span>          int index = i.getAndIncrement();<a name="line.178"></a>
+<span class="sourceLineNo">179</span>          LOG.debug("Task size:" + subprocs.size() + ", getting:" + index);<a name="line.179"></a>
+<span class="sourceLineNo">180</span>          Subprocedure commit = subprocs.get(index);<a name="line.180"></a>
+<span class="sourceLineNo">181</span>          return commit;<a name="line.181"></a>
+<span class="sourceLineNo">182</span>        }<a name="line.182"></a>
+<span class="sourceLineNo">183</span>      });<a name="line.183"></a>
+<span class="sourceLineNo">184</span><a name="line.184"></a>
+<span class="sourceLineNo">185</span>    // setup spying on the coordinator<a name="line.185"></a>
+<span class="sourceLineNo">186</span>//    Procedure proc = Mockito.spy(procBuilder.createProcedure(coordinator, opName, data, expected));<a name="line.186"></a>
+<span class="sourceLineNo">187</span>//    Mockito.when(procBuilder.build(coordinator, opName, data, expected)).thenReturn(proc);<a name="line.187"></a>
+<span class="sourceLineNo">188</span><a name="line.188"></a>
+<span class="sourceLineNo">189</span>    // start running the operation<a name="line.189"></a>
+<span class="sourceLineNo">190</span>    Procedure task = coordinator.startProcedure(new ForeignExceptionDispatcher(), opName, data, expected);<a name="line.190"></a>
+<span class="sourceLineNo">191</span>//    assertEquals("Didn't mock coordinator task", proc, task);<a name="line.191"></a>
+<span class="sourceLineNo">192</span><a name="line.192"></a>
+<span class="sourceLineNo">193</span>    // verify all things ran as expected<a name="line.193"></a>
+<span class="sourceLineNo">194</span>//    waitAndVerifyProc(proc, once, once, never(), once, false);<a name="line.194"></a>
+<span class="sourceLineNo">195</span>    waitAndVerifyProc(task, once, once, never(), once, false);<a name="line.195"></a>
+<span class="sourceLineNo">196</span>    verifyCohortSuccessful(expected, subprocFactory, subprocs, once, once, never(), once, false);<a name="line.196"></a>
+<span class="sourceLineNo">197</span><a name="line.197"></a>
+<span class="sourceLineNo">198</span>    // close all the things<a name="line.198"></a>
+<span class="sourceLineNo">199</span>    closeAll(coordinator, coordinatorComms, procMembers);<a name="line.199"></a>
+<span class="sourceLineNo">200</span>  }<a name="line.200"></a>
+<span class="sourceLineNo">201</span><a name="line.201"></a>
+<span class="sourceLineNo">202</span>  /**<a name="line.202"></a>
+<span class="sourceLineNo">203</span>   * Test a distributed commit with multiple cohort members, where one of the cohort members has a<a name="line.203"></a>
+<span class="sourceLineNo">204</span>   * timeout exception during the prepare stage.<a name="line.204"></a>
+<span class="sourceLineNo">205</span>   */<a name="line.205"></a>
+<span class="sourceLineNo">206</span>  @Test<a name="line.206"></a>
+<span class="sourceLineNo">207</span>  public void testMultiCohortWithMemberTimeoutDuringPrepare() throws Exception {<a name="line.207"></a>
+<span class="sourceLineNo">208</span>    String opDescription = "error injection coordination";<a name="line.208"></a>
+<span class="sourceLineNo">209</span>    String[] cohortMembers = new String[] { "one", "two", "three" };<a name="line.209"></a>
+<span class="sourceLineNo">210</span>    List&lt;String&gt; expected = Lists.newArrayList(cohortMembers);<a name="line.210"></a>
+<span class="sourceLineNo">211</span>    // error constants<a name="line.211"></a>
+<span class="sourceLineNo">212</span>    final int memberErrorIndex = 2;<a name="line.212"></a>
+<span class="sourceLineNo">213</span>    final CountDownLatch coordinatorReceivedErrorLatch = new CountDownLatch(1);<a name="line.213"></a>
+<span class="sourceLineNo">214</span><a name="line.214"></a>
+<span class="sourceLineNo">215</span>    // start running the coordinator and its controller<a name="line.215"></a>
+<span class="sourceLineNo">216</span>    ZKWatcher coordinatorWatcher = newZooKeeperWatcher();<a name="line.216"></a>
+<span class="sourceLineNo">217</span>    ZKProcedureCoordinator coordinatorController = new ZKProcedureCoordinator(<a name="line.217"></a>
+<span class="sourceLineNo">218</span>        coordinatorWatcher, opDescription, COORDINATOR_NODE_NAME);<a name="line.218"></a>
+<span class="sourceLineNo">219</span>    ThreadPoolExecutor pool = ProcedureCoordinator.defaultPool(COORDINATOR_NODE_NAME, POOL_SIZE, KEEP_ALIVE);<a name="line.219"></a>
+<span class="sourceLineNo">220</span>    ProcedureCoordinator coordinator = spy(new ProcedureCoordinator(coordinatorController, pool));<a name="line.220"></a>
+<span class="sourceLineNo">221</span><a name="line.221"></a>
+<span class="sourceLineNo">222</span>    // start a member for each node<a name="line.222"></a>
+<span class="sourceLineNo">223</span>    SubprocedureFactory subprocFactory = Mockito.mock(SubprocedureFactory.class);<a name="line.223"></a>
+<span class="sourceLineNo">224</span>    List&lt;Pair&lt;ProcedureMember, ZKProcedureMemberRpcs&gt;&gt; members = new ArrayList&lt;&gt;(expected.size());<a name="line.224"></a>
+<span class="sourceLineNo">225</span>    for (String member : expected) {<a name="line.225"></a>
+<span class="sourceLineNo">226</span>      ZKWatcher watcher = newZooKeeperWatcher();<a name="line.226"></a>
+<span class="sourceLineNo">227</span>      ZKProcedureMemberRpcs controller = new ZKProcedureMemberRpcs(watcher, opDescription);<a name="line.227"></a>
+<span class="sourceLineNo">228</span>      ThreadPoolExecutor pool2 = ProcedureMember.defaultPool(member, 1, KEEP_ALIVE);<a name="line.228"></a>
+<span class="sourceLineNo">229</span>      ProcedureMember mem = new ProcedureMember(controller, pool2, subprocFactory);<a name="line.229"></a>
+<span class="sourceLineNo">230</span>      members.add(new Pair&lt;&gt;(mem, controller));<a name="line.230"></a>
+<span class="sourceLineNo">231</span>      controller.start(member, mem);<a name="line.231"></a>
+<span class="sourceLineNo">232</span>    }<a name="line.232"></a>
+<span class="sourceLineNo">233</span><a name="line.233"></a>
+<span class="sourceLineNo">234</span>    // setup mock subprocedures<a name="line.234"></a>
+<span class="sourceLineNo">235</span>    final List&lt;Subprocedure&gt; cohortTasks = new ArrayList&lt;&gt;();<a name="line.235"></a>
+<span class="sourceLineNo">236</span>    final int[] elem = new int[1];<a name="line.236"></a>
+<span class="sourceLineNo">237</span>    for (int i = 0; i &lt; members.size(); i++) {<a name="line.237"></a>
+<span class="sourceLineNo">238</span>      ForeignExceptionDispatcher cohortMonitor = new ForeignExceptionDispatcher();<a name="line.238"></a>
+<span class="sourceLineNo">239</span>      final ProcedureMember comms = members.get(i).getFirst();<a name="line.239"></a>
+<span class="sourceLineNo">240</span>      Subprocedure commit = Mockito<a name="line.240"></a>
+<span class="sourceLineNo">241</span>      .spy(new SubprocedureImpl(comms, opName, cohortMonitor, WAKE_FREQUENCY, TIMEOUT));<a name="line.241"></a>
+<span class="sourceLineNo">242</span>      // This nasty bit has one of the impls throw a TimeoutException<a name="line.242"></a>
+<span class="sourceLineNo">243</span>      Mockito.doAnswer(new Answer&lt;Void&gt;() {<a name="line.243"></a>
+<span class="sourceLineNo">244</span>        @Override<a name="line.244"></a>
+<span class="sourceLineNo">245</span>        public Void answer(InvocationOnMock invocation) throws Throwable {<a name="line.245"></a>
+<span class="sourceLineNo">246</span>          int index = elem[0];<a name="line.246"></a>
+<span class="sourceLineNo">247</span>          if (index == memberErrorIndex) {<a name="line.247"></a>
+<span class="sourceLineNo">248</span>            LOG.debug("Sending error to coordinator");<a name="line.248"></a>
+<span class="sourceLineNo">249</span>            ForeignException remoteCause = new ForeignException("TIMER",<a name="line.249"></a>
+<span class="sourceLineNo">250</span>                new TimeoutException("subprocTimeout" , 1, 2, 0));<a name="line.250"></a>
+<span class="sourceLineNo">251</span>            Subprocedure r = ((Subprocedure) invocation.getMock());<a name="line.251"></a>
+<span class="sourceLineNo">252</span>            LOG.error("Remote commit failure, not propagating error:" + remoteCause);<a name="line.252"></a>
+<span class="sourceLineNo">253</span>            comms.receiveAbortProcedure(r.getName(), remoteCause);<a name="line.253"></a>
+<span class="sourceLineNo">254</span>            assertTrue(r.isComplete());<a name="line.254"></a>
+<span class="sourceLineNo">255</span>            // don't complete the error phase until the coordinator has gotten the error<a name="line.255"></a>
+<span class="sourceLineNo">256</span>            // notification (which ensures that we never progress past prepare)<a name="line.256"></a>
+<span class="sourceLineNo">257</span>            try {<a name="line.257"></a>
+<span class="sourceLineNo">258</span>              Procedure.waitForLatch(coordinatorReceivedErrorLatch, new ForeignExceptionDispatcher(),<a name="line.258"></a>
+<span class="sourceLineNo">259</span>                  WAKE_FREQUENCY, "coordinator received error");<a name="line.259"></a>
+<span class="sourceLineNo">260</span>            } catch (InterruptedException e) {<a name="line.260"></a>
+<span class="sourceLineNo">261</span>              LOG.debug("Wait for latch interrupted, done:" + (coordinatorReceivedErrorLatch.getCount() == 0));<a name="line.261"></a>
+<span class="sourceLineNo">262</span>              // reset the interrupt status on the thread<a name="line.262"></a>
+<span class="sourceLineNo">263</span>              Thread.currentThread().interrupt();<a name="line.263"></a>
+<span class="sourceLineNo">264</span>            }<a name="line.264"></a>
+<span class="sourceLineNo">265</span>          }<a name="line.265"></a>
+<span class="sourceLineNo">266</span>          elem[0] = ++index;<a name="line.266"></a>
+<span class="sourceLineNo">267</span>          return null;<a name="line.267"></a>
+<span class="sourceLineNo">268</span>        }<a name="line.268"></a>
+<span class="sourceLineNo">269</span>      }).when(commit).acquireBarrier();<a name="line.269"></a>
+<span class="sourceLineNo">270</span>      cohortTasks.add(commit);<a name="line.270"></a>
+<span class="sourceLineNo">271</span>    }<a name="line.271"></a>
+<span class="sourceLineNo">272</span><a name="line.272"></a>
+<span class="sourceLineNo">273</span>    // pass out a task per member<a name="line.273"></a>
+<span class="sourceLineNo">274</span>    final AtomicInteger taskIndex = new AtomicInteger();<a name="line.274"></a>
+<span class="sourceLineNo">275</span>    Mockito.when(<a name="line.275"></a>
+<span class="sourceLineNo">276</span>      subprocFactory.buildSubprocedure(Mockito.eq(opName),<a name="line.276"></a>
+<span class="sourceLineNo">277</span>        (byte[]) Mockito.argThat(new ArrayEquals(data)))).thenAnswer(<a name="line.277"></a>
+<span class="sourceLineNo">278</span>      new Answer&lt;Subprocedure&gt;() {<a name="line.278"></a>
+<span class="sourceLineNo">279</span>        @Override<a name="line.279"></a>
+<span class="sourceLineNo">280</span>        public Subprocedure answer(InvocationOnMock invocation) throws Throwable {<a name="line.280"></a>
+<span class="sourceLineNo">281</span>          int index = taskIndex.getAndIncrement();<a name="line.281"></a>
+<span class="sourceLineNo">282</span>          Subprocedure commit = cohortTasks.get(index);<a name="line.282"></a>
+<span class="sourceLineNo">283</span>          return commit;<a name="line.283"></a>
+<span class="sourceLineNo">284</span>        }<a name="line.284"></a>
+<span class="sourceLineNo">285</span>      });<a name="line.285"></a>
+<span class="sourceLineNo">286</span><a name="line.286"></a>
+<span class="sourceLineNo">287</span>    // setup spying on the coordinator<a name="line.287"></a>
+<span class="sourceLineNo">288</span>    ForeignExceptionDispatcher coordinatorTaskErrorMonitor = Mockito<a name="line.288"></a>
+<span class="sourceLineNo">289</span>        .spy(new ForeignExceptionDispatcher());<a name="line.289"></a>
+<span class="sourceLineNo">290</span>    Procedure coordinatorTask = Mockito.spy(new Procedure(coordinator,<a name="line.290"></a>
+<span class="sourceLineNo">291</span>        coordinatorTaskErrorMonitor, WAKE_FREQUENCY, TIMEOUT,<a name="line.291"></a>
+<span class="sourceLineNo">292</span>        opName, data, expected));<a name="line.292"></a>
+<span class="sourceLineNo">293</span>    when(coordinator.createProcedure(any(), eq(opName), eq(data), anyListOf(String.class)))<a name="line.293"></a>
+<span class="sourceLineNo">294</span>      .thenReturn(coordinatorTask);<a name="line.294"></a>
+<span class="sourceLineNo">295</span>    // count down the error latch when we get the remote error<a name="line.295"></a>
+<span class="sourceLineNo">296</span>    Mockito.doAnswer(new Answer&lt;Void&gt;() {<a name="line.296"></a>
+<span class="sourceLineNo">297</span>      @Override<a name="line.297"></a>
+<span class="sourceLineNo">298</span>      public Void answer(InvocationOnMock invocation) throws Throwable {<a name="line.298"></a>
+<span class="sourceLineNo">299</span>        // pass on the error to the master<a name="line.299"></a>
+<span class="sourceLineNo">300</span>        invocation.callRealMethod();<a name="line.300"></a>
+<span class="sourceLineNo">301</span>        // then count down the got error latch<a name="line.301"></a>
+<span class="sourceLineNo">302</span>        coordinatorReceivedErrorLatch.countDown();<a name="line.302"></a>
+<span class="sourceLineNo">303</span>        return null;<a name="line.303"></a>
+<span class="sourceLineNo">304</span>      }<a name="line.304"></a>
+<span class="sourceLineNo">305</span>    }).when(coordinatorTask).receive(Mockito.any());<a name="line.305"></a>
+<span class="sourceLineNo">306</span><a name="line.306"></a>
+<span class="sourceLineNo">307</span>    // ----------------------------<a name="line.307"></a>
+<span class="sourceLineNo">308</span>    // start running the operation<a name="line.308"></a>
+<span class="sourceLineNo">309</span>    // ----------------------------<a name="line.309"></a>
+<span class="sourceLineNo">310</span><a name="line.310"></a>
+<span class="sourceLineNo">311</span>    Procedure task = coordinator.startProcedure(coordinatorTaskErrorMonitor, opName, data, expected);<a name="line.311"></a>
+<span class="sourceLineNo">312</span>    assertEquals("Didn't mock coordinator task", coordinatorTask, task);<a name="line.312"></a>
+<span class="sourceLineNo">313</span><a name="line.313"></a>
+<span class="sourceLineNo">314</span>    // wait for the task to complete<a name="line.314"></a>
+<span class="sourceLineNo">315</span>    try {<a name="line.315"></a>
+<span class="sourceLineNo">316</span>      task.waitForCompleted();<a name="line.316"></a>
+<span class="sourceLineNo">317</span>    } catch (ForeignException fe) {<a name="line.317"></a>
+<span class="sourceLineNo">318</span>      // this may get caught or may not<a name="line.318"></a>
+<span class="sourceLineNo">319</span>    }<a name="line.319"></a>
+<span class="sourceLineNo">320</span><a name="line.320"></a>
+<span class="sourceLineNo">321</span>    // -------------<a name="line.321"></a>
+<span class="sourceLineNo">322</span>    // verification<a name="line.322"></a>
+<span class="sourceLineNo">323</span>    // -------------<a name="line.323"></a>
+<span class="sourceLineNo">324</span><a name="line.324"></a>
+<span class="sourceLineNo">325</span>    // always expect prepared, never committed, and possible to have cleanup and finish (racy since<a name="line.325"></a>
+<span class="sourceLineNo">326</span>    // error case)<a name="line.326"></a>
+<span class="sourceLineNo">327</span>    waitAndVerifyProc(coordinatorTask, once, never(), once, atMost(1), true);<a name="line.327"></a>
+<span class="sourceLineNo">328</span>    verifyCohortSuccessful(expected, subprocFactory, cohortTasks, once, never(), once,<a name="line.328"></a>
+<span class="sourceLineNo">329</span>      once, true);<a name="line.329"></a>
+<span class="sourceLineNo">330</span><a name="line.330"></a>
+<span class="sourceLineNo">331</span>    // close all the open things<a name="line.331"></a>
+<span class="sourceLineNo">332</span>    closeAll(coordinator, coordinatorController, members);<a name="line.332"></a>
+<span class="sourceLineNo">333</span>  }<a name="line.333"></a>
+<span class="sourceLineNo">334</span><a name="line.334"></a>
+<span class="sourceLineNo">335</span>  /**<a name="line.335"></a>
+<span class="sourceLineNo">336</span>   * Wait for the coordinator task to complete, and verify all the mocks<a name="line.336"></a>
+<span class="sourceLineNo">337</span>   * @param task to wait on<a name="line.337"></a>
+<span class="sourceLineNo">338</span>   * @throws Exception on unexpected failure<a name="line.338"></a>
+<span class="sourceLineNo">339</span>   */<a name="line.339"></a>
+<span class="sourceLineNo">340</span>  private void waitAndVerifyProc(Procedure proc, VerificationMode prepare,<a name="line.340"></a>
+<span class="sourceLineNo">341</span>      VerificationMode commit, VerificationMode cleanup, VerificationMode finish, boolean opHasError)<a name="line.341"></a>
+<span class="sourceLineNo">342</span>      throws Exception {<a name="line.342"></a>
+<span class="sourceLineNo">343</span>    boolean caughtError = false;<a name="line.343"></a>
+<span class="sourceLineNo">344</span>    try {<a name="line.344"></a>
+<span class="sourceLineNo">345</span>      proc.waitForCompleted();<a name="line.345"></a>
+<span class="sourceLineNo">346</span>    } catch (ForeignException fe) {<a name="line.346"></a>
+<span class="sourceLineNo">347</span>      caughtError = true;<a name="line.347"></a>
+<span class="sourceLineNo">348</span>    }<a name="line.348"></a>
+<span class="sourceLineNo">349</span>    // make sure that the task called all the expected phases<a name="line.349"></a>
+<span class="sourceLineNo">350</span>    Mockito.verify(proc, prepare).sendGlobalBarrierStart();<a name="line.350"></a>
+<span class="sourceLineNo">351</span>    Mockito.verify(proc, commit).sendGlobalBarrierReached();<a name="line.351"></a>
+<span class="sourceLineNo">352</span>    Mockito.verify(proc, finish).sendGlobalBarrierComplete();<a name="line.352"></a>
+<span class="sourceLineNo">353</span>    assertEquals("Operation error state was unexpected", opHasError, proc.getErrorMonitor()<a name="line.353"></a>
+<span class="sourceLineNo">354</span>        .hasException());<a name="line.354"></a>
+<span class="sourceLineNo">355</span>    assertEquals("Operation error state was unexpected", opHasError, caughtError);<a name="line.355"></a>
+<span class="sourceLineNo">356</span><a name="line.356"></a>
+<span class="sourceLineNo">357</span>  }<a name="line.357"></a>
+<span class="sourceLineNo">358</span><a name="line.358"></a>
+<span class="sourceLineNo">359</span>  /**<a name="line.359"></a>
+<span class="sourceLineNo">360</span>   * Wait for the coordinator task to complete, and verify all the mocks<a name="line.360"></a>
+<span class="sourceLineNo">361</span>   * @param task to wait on<a name="line.361"></a>
+<span class="sourceLineNo">362</span>   * @throws Exception on unexpected failure<a name="line.362"></a>
+<span class="sourceLineNo">363</span>   */<a name="line.363"></a>
+<span class="sourceLineNo">364</span>  private void waitAndVerifySubproc(Subprocedure op, VerificationMode prepare,<a name="line.364"></a>
+<span class="sourceLineNo">365</span>      VerificationMode commit, VerificationMode cleanup, VerificationMode finish, boolean opHasError)<a name="line.365"></a>
+<span class="sourceLineNo">366</span>      throws Exception {<a name="line.366"></a>
+<span class="sourceLineNo">367</span>    boolean caughtError = false;<a name="line.367"></a>
+<span class="sourceLineNo">368</span>    try {<a name="line.368"></a>
+<span class="sourceLineNo">369</span>      op.waitForLocallyCompleted();<a name="line.369"></a>
+<span class="sourceLineNo">370</span>    } catch (ForeignException fe) {<a name="line.370"></a>
+<span class="sourceLineNo">371</span>      caughtError = true;<a name="line.371"></a>
+<span class="sourceLineNo">372</span>    }<a name="line.372"></a>
+<span class="sourceLineNo">373</span>    // make sure that the task called all the expected phases<a name="line.373"></a>
+<span class="sourceLineNo">374</span>    Mockito.verify(op, prepare).acquireBarrier();<a name="line.374"></a>
+<span class="sourceLineNo">375</span>    Mockito.verify(op, commit).insideBarrier();<a name="line.375"></a>
+<span class="sourceLineNo">376</span>    // We cannot guarantee that cleanup has run so we don't check it.<a name="line.376"></a>
+<span class="sourceLineNo">377</span><a name="line.377"></a>
+<span class="sourceLineNo">378</span>    assertEquals("Operation error state was unexpected", opHasError, op.getErrorCheckable()<a name="line.378"></a>
+<span class="sourceLineNo">379</span>        .hasException());<a name="line.379"></a>
+<span class="sourceLineNo">380</span>    assertEquals("Operation error state was unexpected", opHasError, caughtError);<a name="line.380"></a>
+<span class="sourceLineNo">381</span><a name="line.381"></a>
+<span class="sourceLineNo">382</span>  }<a name="line.382"></a>
+<span class="sourceLineNo">383</span><a name="line.383"></a>
+<span class="sourceLineNo">384</span>  private void verifyCohortSuccessful(List&lt;String&gt; cohortNames,<a name="line.384"></a>
+<span class="sourceLineNo">385</span>      SubprocedureFactory subprocFactory, Iterable&lt;Subprocedure&gt; cohortTasks,<a name="line.385"></a>
+<span class="sourceLineNo">386</span>      VerificationMode prepare, VerificationMode commit, VerificationMode cleanup,<a name="line.386"></a>
+<span class="sourceLineNo">387</span>      VerificationMode finish, boolean opHasError) throws Exception {<a name="line.387"></a>
+<span class="sourceLineNo">388</span><a name="line.388"></a>
+<span class="sourceLineNo">389</span>    // make sure we build the correct number of cohort members<a name="line.389"></a>
+<span class="sourceLineNo">390</span>    Mockito.verify(subprocFactory, Mockito.times(cohortNames.size())).buildSubprocedure(<a name="line.390"></a>
+<span class="sourceLineNo">391</span>      Mockito.eq(opName), (byte[]) Mockito.argThat(new ArrayEquals(data)));<a name="line.391"></a>
+<span class="sourceLineNo">392</span>    // verify that we ran each of the operations cleanly<a name="line.392"></a>
+<span class="sourceLineNo">393</span>    int j = 0;<a name="line.393"></a>
+<span class="sourceLineNo">394</span>    for (Subprocedure op : cohortTasks) {<a name="line.394"></a>
+<span class="sourceLineNo">395</span>      LOG.debug("Checking mock:" + (j++));<a name="line.395"></a>
+<span class="sourceLineNo">396</span>      waitAndVerifySubproc(op, prepare, commit, cleanup, finish, opHasError);<a name="line.396"></a>
+<span class="sourceLineNo">397</span>    }<a name="line.397"></a>
+<span class="sourceLineNo">398</span>  }<a name="line.398"></a>
+<span class="sourceLineNo">399</span><a name="line.399"></a>
+<span class="sourceLineNo">400</span>  private void closeAll(<a name="line.400"></a>
+<span class="sourceLineNo">401</span>      ProcedureCoordinator coordinator,<a name="line.401"></a>
+<span class="sourceLineNo">402</span>      ZKProcedureCoordinator coordinatorController,<a name="line.402"></a>
+<span class="sourceLineNo">403</span>      List&lt;Pair&lt;ProcedureMember, ZKProcedureMemberRpcs&gt;&gt; cohort)<a name="line.403"></a>
+<span class="sourceLineNo">404</span>      throws IOException {<a name="line.404"></a>
+<span class="sourceLineNo">405</span>    // make sure we close all the resources<a name="line.405"></a>
+<span class="sourceLineNo">406</span>    for (Pair&lt;ProcedureMember, ZKProcedureMemberRpcs&gt; member : cohort) {<a name="line.406"></a>
+<span class="sourceLineNo">407</span>      member.getFirst().close();<a name="line.407"></a>
+<span class="sourceLineNo">408</span>      member.getSecond().close();<a name="line.408"></a>
+<span class="sourceLineNo">409</span>    }<a name="line.409"></a>
+<span class="sourceLineNo">410</span>    coordinator.close();<a name="line.410"></a>
+<span class="sourceLineNo">411</span>    coordinatorController.close();<a name="line.411"></a>
+<span class="sourceLineNo">412</span>  }<a name="line.412"></a>
+<span class="sourceLineNo">413</span>}<a name="line.413"></a>