You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "tm_jee (JIRA)" <ji...@apache.org> on 2006/11/15 17:07:57 UTC
[jira] Commented: (WW-1506) Sitemesh plugin's struts-plugin.xml
uses incorrect filter for both freemarker and velocity
[ http://issues.apache.org/struts/browse/WW-1506?page=comments#action_38705 ]
tm_jee commented on WW-1506:
----------------------------
changes to sitemesh-plugin.
Sending src/main/resources/struts-plugin.xml
Transmitting file data .
Committed revision 475283.
changes to struts-core
Sending src/main/java/org/apache/struts2/config/BeanSelectionProvider.java
Sending src/main/java/org/apache/struts2/config/ClasspathConfigurationProvider.java
Sending src/main/java/org/apache/struts2/config/LegacyPropertiesConfigurationProvider.java
Sending src/main/java/org/apache/struts2/config/StrutsXmlConfigurationProvider.java
Sending src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
Sending src/test/java/org/apache/struts2/TestConfigurationProvider.java
Sending src/test/java/org/apache/struts2/interceptor/ExecuteAndWaitInterceptorTest.java
Transmitting file data .......
Committed revision 475284.
changes to xwork2
Sending src/java/com/opensymphony/xwork2/config/ConfigurationProvider.java
Sending src/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java
Sending src/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
Sending src/java/com/opensymphony/xwork2/inject/ContainerBuilder.java
Sending src/java/com/opensymphony/xwork2/inject/ContainerImpl.java
Sending src/test/com/opensymphony/xwork2/ActionNestingTest.java
Sending src/test/com/opensymphony/xwork2/config/providers/MockConfigurationProvider.java
Sending src/test/com/opensymphony/xwork2/interceptor/PreResultListenerTest.java
Transmitting file data ........
Committed revision 1196.
Please kindly review the code. Leaving this issue open until its being reviewed. Thanks
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> ------------------------------------------------------------------------------------------
>
> Key: WW-1506
> URL: http://issues.apache.org/struts/browse/WW-1506
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: tm_jee
> Assigned To: tm_jee
> Fix For: 2.0.2
>
>
> Sitemesh plugin's struts-plugin.xml uses incorrect filter for both freemarker and velocity
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerTemplatePageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityTemplatePageFilter" static="true" optional="true"/>
> </struts>
> should be
> <struts>
> <bean class="org.apache.struts2.sitemesh.FreeMarkerPageFilter" static="true" optional="true"/>
> <bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/>
> </struts>
> By changing this some problem arrises when either or both of those statically injected files (FreeMarkerPageFilter and VelocityPageFilter) doesn't exists in the classpath. It causes exception, cause Guice does static injection when creating the container, such that during building the container (using ContainerBuilder) the error could not be detected resulting in codes in XmlConfigurationProvider's register method pretty much have no effect.
> A way to simulate this is to use create a webapp using struts2-archetype-starter and try out the application.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira