[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss commented on a change in pull request #463: Provide support for Lean OpenWhisk configuration

[GitBox <gi...@apache.org>]

dgrove-oss commented on a change in pull request #463: Provide support for Lean OpenWhisk  configuration
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/463#discussion_r285634618
 
 

 ##########
 File path: helm/openwhisk/templates/controller-pod.yaml
 ##########
 @@ -30,15 +30,24 @@ spec:
 {{ include "openwhisk.affinity.selfAntiAffinity" ( printf "%s-controller" .Release.Name ) | indent 8 }}
       {{- end }}
 
+{{- if not .Values.controller.lean }}
       initContainers:
       # The controller must wait for kafka and couchdb to be ready before it starts
 {{ include "openwhisk.readiness.waitForKafka" . | indent 6 }}
 {{ include "openwhisk.readiness.waitForCouchDB" . | indent 6 }}
+{{- else }}
 
 Review comment:
   Please make mounting the volumes a separate `if` instead of an `else` of the init-containers

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services