You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "EduardAkhmetshin (via GitHub)" <gi...@apache.org> on 2026/01/06 20:20:10 UTC
[PR] Add union documentation [arrow-rs]
EduardAkhmetshin opened a new pull request, #9102:
URL: https://github.com/apache/arrow-rs/pull/9102
# Which issue does this PR close?
- Closes https://github.com/apache/arrow-rs/issues/9084.
# What changes are included in this PR?
Documentation on union types to https://arrow.apache.org/rust/arrow_row/struct.RowConverter.html.
# Are these changes tested?
Yes.
# Are there any user-facing changes?
Yes: https://arrow.apache.org/rust/arrow_row/struct.RowConverter.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Union encoding documentation [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #9102:
URL: https://github.com/apache/arrow-rs/pull/9102#discussion_r2669323143
##########
arrow-row/src/lib.rs:
##########
@@ -435,6 +470,11 @@ mod variable;
///
/// The order of a given column can be reversed by negating the encoded bytes of non-null values
///
+/// ## Union Ordering
+///
+/// Values of the same type are ordered according to the ordering of that type.
+/// Values of different types are ordered by their type id.
Review Comment:
Since I am trying to prepare the 57.2.0 I took the liberty of making this change directly to this PR in 08efd425348. If I got it wrong or you would like other changes, I will be happy to make a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Union encoding documentation [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9102:
URL: https://github.com/apache/arrow-rs/pull/9102#issuecomment-3720000925
Thanks again @EduardAkhmetshin @Jefffrey and @friendlymatthew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Union encoding documentation [arrow-rs]
Posted by "EduardAkhmetshin (via GitHub)" <gi...@apache.org>.
EduardAkhmetshin commented on PR #9102:
URL: https://github.com/apache/arrow-rs/pull/9102#issuecomment-3716186633
I tested union encoding myself, and the behaviour that I observed differed from the original proposal in https://github.com/apache/arrow-rs/issues/8828. I based my examples on the actual behaviour to the best of my knowledge. Please let me know if anything is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Union encoding documentation [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9102:
URL: https://github.com/apache/arrow-rs/pull/9102#issuecomment-3716522568
@friendlymatthew -- can you help review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Union encoding documentation [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on code in PR #9102:
URL: https://github.com/apache/arrow-rs/pull/9102#discussion_r2666622642
##########
arrow-row/src/lib.rs:
##########
@@ -435,6 +470,11 @@ mod variable;
///
/// The order of a given column can be reversed by negating the encoded bytes of non-null values
///
+/// ## Union Ordering
+///
+/// Values of the same type are ordered according to the ordering of that type.
+/// Values of different types are ordered by their type id.
Review Comment:
Would be good to mention reversing via negating the `type_id` here:
https://github.com/apache/arrow-rs/blob/2507946be697d511689a8f59b6a7db45ef40854b/arrow-row/src/lib.rs#L1742-L1747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Union encoding documentation [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9102:
URL: https://github.com/apache/arrow-rs/pull/9102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org