You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/03 23:09:46 UTC

[GitHub] [superset] junlincc edited a comment on pull request #12918: feat(style): hide dashboard header by url parameter

junlincc edited a comment on pull request #12918:
URL: https://github.com/apache/superset/pull/12918#issuecomment-772889577


   thanks for the PR @simcha90 ! User will still be able to add filters after hiding header and edit button since the actions take place in the view mode. is this intended? 
   @mihir174 I think this is a valid user need - sharing a dashboard to other that should not be editing it. this solution to me is a bit "hacky" though. any idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org