[DISCUSS] issue 2541: Lack of HealthCheck ,we need it

[Ian Luo <ia...@gmail.com>]

Hi Folks,

Recently Longfei (@stoneapple) from ICBU SDC raised one interesting topic
against health check on issue 2541 [1]. Here below I list the brief
discussion thread on this issue:

@stoneapple:

> Currently Dubbo does not have the ability of readiness check and that is
> somehow very helpful and needed in production env.
> Does dubbo team has any plans on it ? can you show some detail design
> drafts ?
> Our team currently is planing to add the healthcheck ability on dubbo , so
> we want to know dubbo team's opinion , if ok , we may give a pr on this
> topic.


@kimmking

> @stoneapple It's a nice way to describe more details for your idea.


@stoneapple

> we know dubbo have the delay exposed ability, sometimes delay time is not
> easy to figure out. Also we may want to check other resources like db,cache
> before we exposed our service to meet the business trade.


@beiwei30

> @stoneapple if you have good idea for builtin /health service, pls. simply
> submit a pull request :) From the point of view of Dubbo, it sounds like
> Dubbo can only provide readiness for dubbo services only.


@zonghaishang

> 我这边提供一个思路看看是否可行，实现一个最低优先级的ServiceBean,
> 在这里拿到所有spring上下文ServiceBean的名字(BeanFactoryUtils.beansOfTypeIncludingAncestors(applicationContext,
> ServiceBean.class, false, false)),
> 每次在服务export时把成功暴露的bean从map剔除，在最后一个低优先级servicebean中检查没有正确暴露服务。


@beiwei30

> what I propose is to provide a builtin health service which expose metrics
> data to the user, from which at lease user can easily to learn whether all
> other services are UP or not.


If you are interested in this, pls. check the whole discussion directly on
GitHub.

Longfei, if you happen to read this mail, would you like to share us your
design here, then we can further discuss based on your proposal?

Others, this feature is quite critical for micro service governance, I'd
like also hear from you. Feel free to discuss in mailing list, or propose
your thought directly on GitHub issue.

Thanks,
-Ian.


1. https://github.com/apache/incubator-dubbo/issues/2541

Re: [DISCUSS] issue 2541: Lack of HealthCheck ,we need it

[jun liu <ke...@gmail.com>]

I left my opinions on Github issue#2541. Since the initial user of this issue seems to more likely to have this discussion on Github, it would be more convenient for him to notice that.

Briefly conclude, I raised two questions:
1. In what condition would we consider a service is ready for use?
1. How to export the health check service to end users, monitor systems or peer Dubbo Consumers? http, telnet or Dubbo?


Best regards,
Jun

> On Nov 1, 2018, at 3:02 PM, Ian Luo <ia...@gmail.com> wrote:
> 
> Hi Folks,
> 
> Recently Longfei (@stoneapple) from ICBU SDC raised one interesting topic
> against health check on issue 2541 [1]. Here below I list the brief
> discussion thread on this issue:
> 
> @stoneapple:
> 
>> Currently Dubbo does not have the ability of readiness check and that is
>> somehow very helpful and needed in production env.
>> Does dubbo team has any plans on it ? can you show some detail design
>> drafts ?
>> Our team currently is planing to add the healthcheck ability on dubbo , so
>> we want to know dubbo team's opinion , if ok , we may give a pr on this
>> topic.
> 
> 
> @kimmking
> 
>> @stoneapple It's a nice way to describe more details for your idea.
> 
> 
> @stoneapple
> 
>> we know dubbo have the delay exposed ability, sometimes delay time is not
>> easy to figure out. Also we may want to check other resources like db,cache
>> before we exposed our service to meet the business trade.
> 
> 
> @beiwei30
> 
>> @stoneapple if you have good idea for builtin /health service, pls. simply
>> submit a pull request :) From the point of view of Dubbo, it sounds like
>> Dubbo can only provide readiness for dubbo services only.
> 
> 
> @zonghaishang
> 
>> 我这边提供一个思路看看是否可行，实现一个最低优先级的ServiceBean,
>> 在这里拿到所有spring上下文ServiceBean的名字(BeanFactoryUtils.beansOfTypeIncludingAncestors(applicationContext,
>> ServiceBean.class, false, false)),
>> 每次在服务export时把成功暴露的bean从map剔除，在最后一个低优先级servicebean中检查没有正确暴露服务。
> 
> 
> @beiwei30
> 
>> what I propose is to provide a builtin health service which expose metrics
>> data to the user, from which at lease user can easily to learn whether all
>> other services are UP or not.
> 
> 
> If you are interested in this, pls. check the whole discussion directly on
> GitHub.
> 
> Longfei, if you happen to read this mail, would you like to share us your
> design here, then we can further discuss based on your proposal?
> 
> Others, this feature is quite critical for micro service governance, I'd
> like also hear from you. Feel free to discuss in mailing list, or propose
> your thought directly on GitHub issue.
> 
> Thanks,
> -Ian.
> 
> 
> 1. https://github.com/apache/incubator-dubbo/issues/2541