You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@river.apache.org by "Peter Firmstone (JIRA)" <ji...@apache.org> on 2009/04/21 22:32:47 UTC
[jira] Created: (RIVER-303) Add "test" directory to the jtsk trunk
for unit tests
Add "test" directory to the jtsk trunk for unit tests
-----------------------------------------------------
Key: RIVER-303
URL: https://issues.apache.org/jira/browse/RIVER-303
Project: River
Issue Type: New Feature
Environment: All
Reporter: Peter Firmstone
>From our discussion on river-dev:
> Good idea, can someone create a "unit-test" directory in the main
> > trunk? Should I raise an issue on Jira? A bit off topic, but related,
> > I noticed there two directory trees, one called integrationtests and the
> > other called qa, if we create a "unit-test" directory, it would be nice
> > to have an "integration-test" directory for clarity.
Yes, please open an issue, and lets continue this discussion there.
The latest revision of the jtsk trunk contains:
DISCLAIMER
KEYS
LICENSE
NOTICE
build.xml
common.xml
doc/
index.html
qa/
src/
tools/
No more "integrationtests" dir there.
What I would propose is this add a "test" (I guess naming is not so
important) directory (like most standard project directory layouts store
their unit tests) and add some test targets to the main build.xml for
it.
so:
build.xml (add test targets here)
common.xml
...
src
test
- src
qa
- build.xml
- src
- ...
IMHO, the difference with the QA "subproject" would be that the latter
has its own build file and will be distributed separately. Technically
one could add unit tests to the QA harness too, they would go in
qa/test ;-)
That said, everybody is of course free to send in patches to add some
unit tests any way they feel is best!
Best
Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (RIVER-303) Add "test" directory to the jtsk trunk
for unit tests
Posted by "Tom Hobbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom Hobbs resolved RIVER-303.
-----------------------------
Resolution: Fixed
Requested directory created and committed.
> Add "test" directory to the jtsk trunk for unit tests
> -----------------------------------------------------
>
> Key: RIVER-303
> URL: https://issues.apache.org/jira/browse/RIVER-303
> Project: River
> Issue Type: New Feature
> Environment: All
> Reporter: Peter Firmstone
>
> From our discussion on river-dev:
> > Good idea, can someone create a "unit-test" directory in the main
> > > trunk? Should I raise an issue on Jira? A bit off topic, but related,
> > > I noticed there two directory trees, one called integrationtests and the
> > > other called qa, if we create a "unit-test" directory, it would be nice
> > > to have an "integration-test" directory for clarity.
> Yes, please open an issue, and lets continue this discussion there.
> The latest revision of the jtsk trunk contains:
> DISCLAIMER
> KEYS
> LICENSE
> NOTICE
> build.xml
> common.xml
> doc/
> index.html
> qa/
> src/
> tools/
> No more "integrationtests" dir there.
> What I would propose is this add a "test" (I guess naming is not so
> important) directory (like most standard project directory layouts store
> their unit tests) and add some test targets to the main build.xml for
> it.
> so:
> build.xml (add test targets here)
> common.xml
> ...
> src
> test
> - src
> qa
> - build.xml
> - src
> - ...
> IMHO, the difference with the QA "subproject" would be that the latter
> has its own build file and will be distributed separately. Technically
> one could add unit tests to the QA harness too, they would go in
> qa/test ;-)
> That said, everybody is of course free to send in patches to add some
> unit tests any way they feel is best!
> Best
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-303) Add "test" directory to the jtsk
trunk for unit tests
Posted by "Tom Hobbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703820#action_12703820 ]
Tom Hobbs commented on RIVER-303:
---------------------------------
Created the test directory as requested.
> Add "test" directory to the jtsk trunk for unit tests
> -----------------------------------------------------
>
> Key: RIVER-303
> URL: https://issues.apache.org/jira/browse/RIVER-303
> Project: River
> Issue Type: New Feature
> Environment: All
> Reporter: Peter Firmstone
>
> From our discussion on river-dev:
> > Good idea, can someone create a "unit-test" directory in the main
> > > trunk? Should I raise an issue on Jira? A bit off topic, but related,
> > > I noticed there two directory trees, one called integrationtests and the
> > > other called qa, if we create a "unit-test" directory, it would be nice
> > > to have an "integration-test" directory for clarity.
> Yes, please open an issue, and lets continue this discussion there.
> The latest revision of the jtsk trunk contains:
> DISCLAIMER
> KEYS
> LICENSE
> NOTICE
> build.xml
> common.xml
> doc/
> index.html
> qa/
> src/
> tools/
> No more "integrationtests" dir there.
> What I would propose is this add a "test" (I guess naming is not so
> important) directory (like most standard project directory layouts store
> their unit tests) and add some test targets to the main build.xml for
> it.
> so:
> build.xml (add test targets here)
> common.xml
> ...
> src
> test
> - src
> qa
> - build.xml
> - src
> - ...
> IMHO, the difference with the QA "subproject" would be that the latter
> has its own build file and will be distributed separately. Technically
> one could add unit tests to the QA harness too, they would go in
> qa/test ;-)
> That said, everybody is of course free to send in patches to add some
> unit tests any way they feel is best!
> Best
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RIVER-303) Add "test" directory to the jtsk
trunk for unit tests
Posted by "Peter Firmstone (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702355#action_12702355 ]
Peter Firmstone commented on RIVER-303:
---------------------------------------
After reading the discussion between Jonathan Costers and Peter Jones on river-dev: Re: Build failed in Hudson: River-trunk #163, I no longer think it advisable to implement unit testing with JUnit.
There are a significant number of Unit and Regression tests inherited by the River project in qa/jtreg/ that require jtreg tool, which originates from Sun's JDK.
Jonathan has done an excellent job making the regression tests work correctly using Ant, the previous usability issue of running the tests using gmake appears resolved in River-301.
I have raised an issue under River-304 for jtreg
I'd like to close this issue, but before doing so want to hear other developer opinions.
Cheers,
Peter.
> Add "test" directory to the jtsk trunk for unit tests
> -----------------------------------------------------
>
> Key: RIVER-303
> URL: https://issues.apache.org/jira/browse/RIVER-303
> Project: River
> Issue Type: New Feature
> Environment: All
> Reporter: Peter Firmstone
>
> From our discussion on river-dev:
> > Good idea, can someone create a "unit-test" directory in the main
> > > trunk? Should I raise an issue on Jira? A bit off topic, but related,
> > > I noticed there two directory trees, one called integrationtests and the
> > > other called qa, if we create a "unit-test" directory, it would be nice
> > > to have an "integration-test" directory for clarity.
> Yes, please open an issue, and lets continue this discussion there.
> The latest revision of the jtsk trunk contains:
> DISCLAIMER
> KEYS
> LICENSE
> NOTICE
> build.xml
> common.xml
> doc/
> index.html
> qa/
> src/
> tools/
> No more "integrationtests" dir there.
> What I would propose is this add a "test" (I guess naming is not so
> important) directory (like most standard project directory layouts store
> their unit tests) and add some test targets to the main build.xml for
> it.
> so:
> build.xml (add test targets here)
> common.xml
> ...
> src
> test
> - src
> qa
> - build.xml
> - src
> - ...
> IMHO, the difference with the QA "subproject" would be that the latter
> has its own build file and will be distributed separately. Technically
> one could add unit tests to the QA harness too, they would go in
> qa/test ;-)
> That said, everybody is of course free to send in patches to add some
> unit tests any way they feel is best!
> Best
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.