You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/02/06 04:08:55 UTC
Review Request 65520: Reverted plugin name randomization in SLRP
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65520/
-----------------------------------------------------------
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Repository: mesos
Description
-------
The plugin name is no longer randomized since it is no longer needed
for test isolation. Also removed an unnecessary member variable in the
SLRP test class.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp ce241617ee555e5a67e552dd30b0e7afee161386
Diff: https://reviews.apache.org/r/65520/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65520: Reverted plugin name randomization in SLRP
tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65520/#review196923
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 6, 2018, 4:08 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65520/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 4:08 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The plugin name is no longer randomized since it is no longer needed
> for test isolation. Also removed an unnecessary member variable in the
> SLRP test class.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp ce241617ee555e5a67e552dd30b0e7afee161386
>
>
> Diff: https://reviews.apache.org/r/65520/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65520: Reverted plugin name randomization in SLRP
tests.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65520/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 12:01 a.m.)
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Changes
-------
Rebased.
Repository: mesos
Description
-------
The plugin name is no longer randomized since it is no longer needed
for test isolation. Also removed an unnecessary member variable in the
SLRP test class.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp ce241617ee555e5a67e552dd30b0e7afee161386
Diff: https://reviews.apache.org/r/65520/diff/2/
Changes: https://reviews.apache.org/r/65520/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao