[jira] [Comment Edited] (FLEX-18697) ObjectUtil.getCacheKey does not make cache key correctly

["Justin Mclean (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLEX-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637439#comment-13637439 ] 

Justin Mclean edited comment on FLEX-18697 at 4/21/13 2:13 AM:
---------------------------------------------------------------

Not 100% sure if it's correctly fixed. 

Think fix should be:
                var value:String = options[flag].toString();
                if (value != null)
                    key += value;

                
      was (Author: jmclean):
    Not 100% it's correctly fixed. 

Think fix should be:
                var value:String = options[flag].toString();
                if (value != null)
                    key += value;

                  
> ObjectUtil.getCacheKey does not make cache key correctly
> --------------------------------------------------------
>
>                 Key: FLEX-18697
>                 URL: https://issues.apache.org/jira/browse/FLEX-18697
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: .Unspecified - Framework
>    Affects Versions: Adobe Flex SDK 3.2 (Release)
>         Environment: Affected OS(s): All OS Platforms
> Affected OS(s): All OS Platforms
> Language Found: English
>            Reporter: Adobe JIRA
>            Assignee: Nick Kwiatkowski
>              Labels: easyfix, easytest
>             Fix For: Apache Flex 4.10.0
>
>
> affected class: mx.utils.ObjectUtil
> 1. call ObjectUtil.getClassInfo with options.includeReadonly = true 
> 2. call ObjectUtil.getClassInfo with options.includeReadonly = false 
> The result of step2 is same as the result of step1. 
> Because step2 just return cached result of step1. 
> see source code of getCacheKey function of ObjectUtil class 
> /* ---------+---------+---------+---------+---------+ */ 
> var value:String = options[flag] as String; 
> if (value != null) 
>     key += value; 
> /* ---------+---------+---------+---------+---------+ */ 
> code of "options["includeReadOnly"] as String" is always null 
> Replacing that code to the following line will fix the problem:
> key += options[flag].toString();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira