You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/04/04 21:06:39 UTC
[PR] Fix datafusion-cli publishing [arrow-datafusion]
alamb opened a new pull request, #9955:
URL: https://github.com/apache/arrow-datafusion/pull/9955
## Which issue does this PR close?
Part of #9682
## Rationale for this change
I had to add a `version` field to the datafusion-cli `Cargo.toml` file to correctly publish to crates.io as `datafusion-common` did not specify a version
## What changes are included in this PR?
1. Remove direct datafuson_common and use existing `datafusion` dependency
## Are these changes tested?
By C
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix datafusion-cli publishing [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #9955:
URL: https://github.com/apache/arrow-datafusion/pull/9955#discussion_r1552445101
##########
datafusion-cli/Cargo.toml:
##########
@@ -45,7 +45,6 @@ datafusion = { path = "../datafusion/core", version = "37.0.0", features = [
"unicode_expressions",
"compression",
] }
-datafusion-common = { path = "../datafusion/common" }
Review Comment:
I had to change this to
```toml
datafusion-common = { path = "../datafusion/common", version="37.0.0" }
```
to get `datafusion-cli` to publish. I think removing the whole dependency is cleaner that adding a version that needs to be kept in sync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix datafusion-cli publishing [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #9955:
URL: https://github.com/apache/arrow-datafusion/pull/9955#discussion_r1552444361
##########
datafusion-cli/src/command.rs:
##########
@@ -26,9 +26,9 @@ use datafusion::arrow::array::{ArrayRef, StringArray};
use datafusion::arrow::datatypes::{DataType, Field, Schema};
use datafusion::arrow::record_batch::RecordBatch;
use datafusion::common::exec_err;
+use datafusion::common::instant::Instant;
Review Comment:
the whole change is `datafusion_common` --> `datafusion::common`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix datafusion-cli publishing [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9955:
URL: https://github.com/apache/arrow-datafusion/pull/9955#issuecomment-2039850264
Thank you @Jefffrey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix datafusion-cli publishing [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9955:
URL: https://github.com/apache/arrow-datafusion/pull/9955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org