You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/09 08:13:28 UTC

[GitHub] williaster opened a new pull request #6350: [dashboard] fix save/save-as flow

williaster opened a new pull request #6350: [dashboard] fix save/save-as flow
URL: https://github.com/apache/incubator-superset/pull/6350
 
 
   Previously #6189 fixed a dashboard `save as` redirect bug, but introduced a dashboard `save` bug which was fixed today by #6349. However fixing the `save` bug re-introduced the `save as` bug 🙉 
   
   Basically `save-as` returns the new `id` for the redirect as `json`, but `save` returns `HTML` which throws if you parse it as `json` 🙄Putting the two together, this PR keeps `parseMethod: null`, and handles the json parsing within the `save-as` handler.
   
   Tested BOTH locally.
   
   @michellethomas @graceguo-supercat @kristw @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org