You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/10/14 07:40:22 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #343: move to java 17, use Gradle 7.3 RC1
atoulme opened a new pull request #343:
URL: https://github.com/apache/incubator-tuweni/pull/343
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/main/CONTRIBUTING.md -->
## PR description
Move to Java 17 with the latest Gradle, upgrade dependencies and build to match.
## Fixed Issue(s)
<!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->
<!-- Example: "fixes #2" -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] ajsutton commented on a change in pull request #343: move to java 17, use Gradle 7.3
Posted by GitBox <gi...@apache.org>.
ajsutton commented on a change in pull request #343:
URL: https://github.com/apache/incubator-tuweni/pull/343#discussion_r775173156
##########
File path: build.gradle
##########
@@ -20,18 +20,19 @@ buildscript {
mavenCentral()
}
- dependencies { classpath "org.ajoberstar.grgit:grgit-core:3.1.1" }
+ dependencies {
+ classpath "org.ajoberstar.grgit:grgit-core:3.1.1"
+ }
}
plugins {
- id 'com.diffplug.spotless' version '5.8.2'
- id 'net.ltgt.errorprone' version '1.2.1'
+ id 'com.diffplug.spotless' version '5.17.0'
+ id 'net.ltgt.errorprone' version '2.0.2'
id 'org.springframework.boot' version '2.4.3'
id 'io.spring.dependency-management' version '1.0.6.RELEASE'
- id 'com.github.hierynomus.license' version '0.15.0'
id 'org.gradle.crypto.checksum' version '1.1.0'
- id 'org.jetbrains.kotlin.jvm' version '1.4.20'
- id 'org.jetbrains.kotlin.plugin.spring' version '1.4.20'
+ id 'org.jetbrains.kotlin.jvm' version '1.6.0-RC2'
+ id 'org.jetbrains.kotlin.plugin.spring' version '1.6.0-RC2'
Review comment:
Not sure we want to be adding an RC as a dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme commented on a change in pull request #343: move to java 17, use Gradle 7.3
Posted by GitBox <gi...@apache.org>.
atoulme commented on a change in pull request #343:
URL: https://github.com/apache/incubator-tuweni/pull/343#discussion_r775189208
##########
File path: build.gradle
##########
@@ -20,18 +20,19 @@ buildscript {
mavenCentral()
}
- dependencies { classpath "org.ajoberstar.grgit:grgit-core:3.1.1" }
+ dependencies {
+ classpath "org.ajoberstar.grgit:grgit-core:3.1.1"
+ }
}
plugins {
- id 'com.diffplug.spotless' version '5.8.2'
- id 'net.ltgt.errorprone' version '1.2.1'
+ id 'com.diffplug.spotless' version '5.17.0'
+ id 'net.ltgt.errorprone' version '2.0.2'
id 'org.springframework.boot' version '2.4.3'
id 'io.spring.dependency-management' version '1.0.6.RELEASE'
- id 'com.github.hierynomus.license' version '0.15.0'
id 'org.gradle.crypto.checksum' version '1.1.0'
- id 'org.jetbrains.kotlin.jvm' version '1.4.20'
- id 'org.jetbrains.kotlin.plugin.spring' version '1.4.20'
+ id 'org.jetbrains.kotlin.jvm' version '1.6.0-RC2'
+ id 'org.jetbrains.kotlin.plugin.spring' version '1.6.0-RC2'
Review comment:
Nice catch. I think 1.6 came out since. I’ll change ti it. The problem was that 1.5.x didn’t support 17 at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #343: move to support java 17, use Gradle 7.3
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #343:
URL: https://github.com/apache/incubator-tuweni/pull/343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme commented on pull request #343: move to java 17, use Gradle 7.3
Posted by GitBox <gi...@apache.org>.
atoulme commented on pull request #343:
URL: https://github.com/apache/incubator-tuweni/pull/343#issuecomment-1001099473
Merry Christmas! I can revert that part snd make sure we build with 11, indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme commented on a change in pull request #343: move to support java 17, use Gradle 7.3
Posted by GitBox <gi...@apache.org>.
atoulme commented on a change in pull request #343:
URL: https://github.com/apache/incubator-tuweni/pull/343#discussion_r775675736
##########
File path: build.gradle
##########
@@ -20,18 +20,19 @@ buildscript {
mavenCentral()
}
- dependencies { classpath "org.ajoberstar.grgit:grgit-core:3.1.1" }
+ dependencies {
+ classpath "org.ajoberstar.grgit:grgit-core:3.1.1"
+ }
}
plugins {
- id 'com.diffplug.spotless' version '5.8.2'
- id 'net.ltgt.errorprone' version '1.2.1'
+ id 'com.diffplug.spotless' version '5.17.0'
+ id 'net.ltgt.errorprone' version '2.0.2'
id 'org.springframework.boot' version '2.4.3'
id 'io.spring.dependency-management' version '1.0.6.RELEASE'
- id 'com.github.hierynomus.license' version '0.15.0'
id 'org.gradle.crypto.checksum' version '1.1.0'
- id 'org.jetbrains.kotlin.jvm' version '1.4.20'
- id 'org.jetbrains.kotlin.plugin.spring' version '1.4.20'
+ id 'org.jetbrains.kotlin.jvm' version '1.6.0-RC2'
+ id 'org.jetbrains.kotlin.plugin.spring' version '1.6.0-RC2'
Review comment:
OK fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org