You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by Stanton Sievers <si...@gmail.com> on 2012/05/14 13:59:53 UTC

Re: Review Request: Fix for SHINDIG-1776

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5098/#review7836
-----------------------------------------------------------


The code LGTM.  Is this something we could add a test for in gadget_holder_test.js?

- Stanton


On 2012-05-12 02:06:16, Matt Franklin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5098/
> -----------------------------------------------------------
> 
> (Updated 2012-05-12 02:06:16)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> Fix for pubsub2 duplicate error on second navigation of site SHINDIG-1776
> 
> 
> This addresses bug SHINDIG-1776.
>     https://issues.apache.org/jira/browse/SHINDIG-1776
> 
> 
> Diffs
> -----
> 
>   trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1337392 
> 
> Diff: https://reviews.apache.org/r/5098/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>