You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "chia7712 (via GitHub)" <gi...@apache.org> on 2023/02/25 22:24:59 UTC
[GitHub] [kafka] chia7712 opened a new pull request, #13308: MINOR: update docs of 'replica.socket.receive.buffer.bytes'
chia7712 opened a new pull request, #13308:
URL: https://github.com/apache/kafka/pull/13308
as title. make the doc more readable.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a diff in pull request #13308: MINOR: update docs of 'replica.socket.receive.buffer.bytes'
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #13308:
URL: https://github.com/apache/kafka/pull/13308#discussion_r1117987586
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -888,7 +888,7 @@ object KafkaConfig {
val ReplicaLagTimeMaxMsDoc = "If a follower hasn't sent any fetch requests or hasn't consumed up to the leaders log end offset for at least this time," +
" the leader will remove the follower from isr"
val ReplicaSocketTimeoutMsDoc = "The socket timeout for network requests. Its value should be at least replica.fetch.wait.max.ms"
- val ReplicaSocketReceiveBufferBytesDoc = "The socket receive buffer for network requests"
+ val ReplicaSocketReceiveBufferBytesDoc = "The socket receive buffer for network requests to the leader for replicating data"
Review Comment:
I copy the description from our 0.8.2 doc (https://svn.apache.org/repos/asf/kafka/site/082/configuration.html#topic-config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #13308: MINOR: update docs of 'replica.socket.receive.buffer.bytes'
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang merged PR #13308:
URL: https://github.com/apache/kafka/pull/13308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #13308: MINOR: update docs of 'replica.socket.receive.buffer.bytes'
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang commented on PR #13308:
URL: https://github.com/apache/kafka/pull/13308#issuecomment-1446938946
LGTM. Merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org