You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/10/17 19:37:36 UTC

[kudu-CR](branch-1.11.x) [java] Fix TestKuduPartitioner errorprone warning 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14496


Change subject: [java] Fix TestKuduPartitioner errorprone warning
......................................................................

[java] Fix TestKuduPartitioner errorprone warning

This fixes the following errorprone warning:

Expression of type int may overflow before being assigned to a long
long upperBound = timeoutMs * 2; // Add 100% to avoid flakiness.

Change-Id: I9fd41b7cae9502468728efbdf51e3d7191447371
Reviewed-on: http://gerrit.cloudera.org:8080/14488
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit fd66fc5ec83bf0d14fe391dddd74793bde532e5f)
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/14496/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fd41b7cae9502468728efbdf51e3d7191447371
Gerrit-Change-Number: 14496
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR](branch-1.11.x) [java] Fix TestKuduPartitioner errorprone warning

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14496 )

Change subject: [java] Fix TestKuduPartitioner errorprone warning
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fd41b7cae9502468728efbdf51e3d7191447371
Gerrit-Change-Number: 14496
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Oct 2019 01:31:36 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.11.x) [java] Fix TestKuduPartitioner errorprone warning

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14496 )

Change subject: [java] Fix TestKuduPartitioner errorprone warning
......................................................................

[java] Fix TestKuduPartitioner errorprone warning

This fixes the following errorprone warning:

Expression of type int may overflow before being assigned to a long
long upperBound = timeoutMs * 2; // Add 100% to avoid flakiness.

Change-Id: I9fd41b7cae9502468728efbdf51e3d7191447371
Reviewed-on: http://gerrit.cloudera.org:8080/14488
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit fd66fc5ec83bf0d14fe391dddd74793bde532e5f)
Reviewed-on: http://gerrit.cloudera.org:8080/14496
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fd41b7cae9502468728efbdf51e3d7191447371
Gerrit-Change-Number: 14496
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)