[GitHub] [beam] apilloud commented on a change in pull request #17190: [BEAM-14190] Python sends dataflow schema field for pre-portability pipelines

[GitBox <gi...@apache.org>]

apilloud commented on a change in pull request #17190:
URL: https://github.com/apache/beam/pull/17190#discussion_r836715152



##########
File path: sdks/python/apache_beam/coders/row_coder.py
##########
@@ -85,6 +87,13 @@ def as_deterministic_coder(self, step_label, error_message=None):
   def to_type_hint(self):
     return self._type_hint
 
+  def as_cloud_object(self, coders_context=None):

Review comment:
       I agree they are pre-portability, I don't know where we are on them being deprecated long term. My understanding is that for portability their generation is moved from the Beam SDK to the Dataflow Service.
   
   This PR is bringing Python up to feature parity with Java. My understanding is that there is no support for Schema metadata in portability yet, but I'll be looking into that next.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org