You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/06/02 13:07:20 UTC
[GitHub] [iotdb] LIU-WEI-git opened a new pull request, #6154: [IOTDB-3388] Let MQTT Service could parse JSON array of existed format
LIU-WEI-git opened a new pull request, #6154:
URL: https://github.com/apache/iotdb/pull/6154
See [IOTDB-3388](https://issues.apache.org/jira/browse/IOTDB-3388).
Optimize JSONPayloadFormatter. Now MQTT Service could parse not only JSON object, but JSON array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LIU-WEI-git commented on pull request #6154: [IOTDB-3388] Let MQTT Service could parse JSON array of existed format
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on PR #6154:
URL: https://github.com/apache/iotdb/pull/6154#issuecomment-1145748075
> Hi, consider adding an example in https://github.com/apache/iotdb/tree/master/example/mqtt/src/main/java/org/apache/iotdb/mqtt ?
>
> And test cases as well.
Done. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LIU-WEI-git commented on pull request #6154: [IOTDB-3388] Let MQTT Service could parse JSON array of existed format
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on PR #6154:
URL: https://github.com/apache/iotdb/pull/6154#issuecomment-1146984400
Something I have to say is that this feature has been add in the PR #3251 by my mistake, you could see that in the [code](https://github.com/apache/iotdb/blob/7f1b0a74de4147b1750c2912f8fe6aab43779fb2/server/src/main/java/org/apache/iotdb/db/protocol/mqtt/JSONPayloadFormatter.java#L65). It's an ugly implementation, so I commit this PR to polish it with test and doc. If this feature is not need, please let me revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #6154: [IOTDB-3388] Let MQTT Service could parse JSON array of existed format
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #6154:
URL: https://github.com/apache/iotdb/pull/6154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #6154: [IOTDB-3388] Let MQTT Service could parse JSON array of existed format
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on PR #6154:
URL: https://github.com/apache/iotdb/pull/6154#issuecomment-1146930851
hi wei, Will MQTT Be support in 0.14 version ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LIU-WEI-git commented on pull request #6154: [IOTDB-3388] Let MQTT Service could parse JSON array of existed format
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on PR #6154:
URL: https://github.com/apache/iotdb/pull/6154#issuecomment-1146979473
> hi wei, Will MQTT Be support in 0.14 version ?
Hi, MQTT service has already been supported in 0.13.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #6154: [IOTDB-3388] Let MQTT Service could parse JSON array of existed format
Posted by GitBox <gi...@apache.org>.
HTHou commented on PR #6154:
URL: https://github.com/apache/iotdb/pull/6154#issuecomment-1144999135
Hi, consider adding an example in https://github.com/apache/iotdb/tree/master/example/mqtt/src/main/java/org/apache/iotdb/mqtt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org