You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/16 13:29:39 UTC
[GitHub] [hbase-operator-tools] wchevreuil opened a new pull request #65: HBASE-24571 HBCK2 fix addFsRegionsMissingInMeta to add regions in CLO…
wchevreuil opened a new pull request #65:
URL: https://github.com/apache/hbase-operator-tools/pull/65
…SED state again
This PR fix implementation of HBCKMetaTableAccessor.addRegionToMeta to insert new regions with CLOSED state, and also adds extra checks for this behaviour on both TestHBCKMetaTableAccessor and TestFsRegionsMetaRecoverer UTs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] virajjasani commented on a change in pull request #65: HBASE-24571 HBCK2 fix addFsRegionsMissingInMeta to add regions in CLO…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #65:
URL: https://github.com/apache/hbase-operator-tools/pull/65#discussion_r441494478
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCKMetaTableAccessor.java
##########
@@ -454,6 +457,18 @@ public static Put makePutFromRegionInfo(RegionInfo region, long ts) throws IOExc
return put;
}
+ private static Put addRegionStateToPut(Put put, RegionState.State state) throws IOException {
Review comment:
This could be `void addRegionStateToPut` since return value is of no use as we are mutating `Put`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil commented on pull request #65: HBASE-24571 HBCK2 fix addFsRegionsMissingInMeta to add regions in CLO…
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on pull request #65:
URL: https://github.com/apache/hbase-operator-tools/pull/65#issuecomment-645281927
retest build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #65: HBASE-24571 HBCK2 fix addFsRegionsMissingInMeta to add regions in CLO…
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on a change in pull request #65:
URL: https://github.com/apache/hbase-operator-tools/pull/65#discussion_r441530776
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCKMetaTableAccessor.java
##########
@@ -454,6 +457,18 @@ public static Put makePutFromRegionInfo(RegionInfo region, long ts) throws IOExc
return put;
}
+ private static Put addRegionStateToPut(Put put, RegionState.State state) throws IOException {
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil commented on pull request #65: HBASE-24571 HBCK2 fix addFsRegionsMissingInMeta to add regions in CLO…
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on pull request #65:
URL: https://github.com/apache/hbase-operator-tools/pull/65#issuecomment-644845600
The failure is not related to this commit. It seems the test added in HBASE-23927 is creating an _inputForAssignsTest_ file under project root dir, which causes asflicense checks to fail: https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/175/artifact/patchprocess/patch-asflicense-problems.txt.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] virajjasani commented on a change in pull request #65: HBASE-24571 HBCK2 fix addFsRegionsMissingInMeta to add regions in CLO…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #65:
URL: https://github.com/apache/hbase-operator-tools/pull/65#discussion_r441494478
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCKMetaTableAccessor.java
##########
@@ -454,6 +457,18 @@ public static Put makePutFromRegionInfo(RegionInfo region, long ts) throws IOExc
return put;
}
+ private static Put addRegionStateToPut(Put put, RegionState.State state) throws IOException {
Review comment:
This could be `void addRegionStateToPut` since return value is of no use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil merged pull request #65: HBASE-24571 HBCK2 fix addFsRegionsMissingInMeta to add regions in CLO…
Posted by GitBox <gi...@apache.org>.
wchevreuil merged pull request #65:
URL: https://github.com/apache/hbase-operator-tools/pull/65
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org