[mynewt-nimble] branch master updated: nimble/ll: Fix HCI_Le_Set_Host_Features

[an...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

andk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git


The following commit(s) were added to refs/heads/master by this push:
     new 1f52f1e  nimble/ll: Fix HCI_Le_Set_Host_Features
1f52f1e is described below

commit 1f52f1e7c599eb286fe3427a560a8d0ae2dbceb8
Author: Andrzej Kaczmarek <an...@codecoup.pl>
AuthorDate: Thu May 14 12:54:37 2020 +0200

    nimble/ll: Fix HCI_Le_Set_Host_Features
    
    This fixes returned error in 2 cases:
    - if given bit refers to feature that is not host-controlled, we should
      return unsupported feature error instead of invalid parameters,
    - we probably should always allow host to set host-controller feature
      bit even if related LL feature is not enabled; it probably does not
      make much sense, but Core spec does not say anything that it should
      not be allowed.
---
 nimble/controller/src/ble_ll.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/nimble/controller/src/ble_ll.c b/nimble/controller/src/ble_ll.c
index b0eced6..6fc6ad9 100644
--- a/nimble/controller/src/ble_ll.c
+++ b/nimble/controller/src/ble_ll.c
@@ -247,9 +247,6 @@ uint8_t g_dev_addr[BLE_DEV_ADDR_LEN];
 /** Our random address */
 uint8_t g_random_addr[BLE_DEV_ADDR_LEN];
 
-/** Our supported features which can be controller by the host */
-uint64_t g_ble_ll_supported_host_features = 0;
-
 static const uint16_t g_ble_ll_pdu_header_tx_time[BLE_PHY_NUM_MODE] =
 {
     [BLE_PHY_MODE_1M] =
@@ -1305,10 +1302,6 @@ ble_ll_set_host_feat(const uint8_t *cmdbuf, uint8_t len)
 
     mask = (uint64_t)1 << (cmd->bit_num);
     if (!(mask & BLE_LL_HOST_CONTROLLED_FEATURES)) {
-        return BLE_ERR_INV_HCI_CMD_PARMS;
-    }
-
-    if (!(mask & g_ble_ll_supported_host_features)) {
         return BLE_ERR_UNSUPPORTED;
     }
 
@@ -1687,9 +1680,6 @@ ble_ll_init(void)
     features |= BLE_LL_FEAT_CIS_SLAVE;
     features |= BLE_LL_FEAT_ISO_BROADCASTER;
     features |= BLE_LL_FEAT_ISO_HOST_SUPPORT;
-
-    /* Set features controller by the Host */
-    g_ble_ll_supported_host_features |= BLE_LL_FEAT_ISO_HOST_SUPPORT;
 #endif
 
     /* Initialize random number generation */