[jira] [Commented] (AIRFLOW-6708) Set unique logger names

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028224#comment-17028224 ] 

ASF GitHub Bot commented on AIRFLOW-6708:
-----------------------------------------

mik-laj commented on pull request #7330: [AIRFLOW-6708] Set unique logger names
URL: https://github.com/apache/airflow/pull/7330
 
 
   LoggingMixin is intended for configuring the logger for classes. If it is used incorrectly then all loggers are configured for one name - `airflow.utils.log.logging_mixin.LoggingMixin`
   
   Before:
   ```
   $ AIRFLOW__LOGGING__COLORED_LOG_FORMAT='%(name)s: %(message)s'  python -c 'from airflow.logging_config import configure_logging; from airflow.executors.celery_executor import execute_command; configure_logging(); execute_command(["bash", "-c", "echo 1"]);'
   airflow.utils.log.logging_mixin.LoggingMixin: Executing command in Celery: ['bash', '-c', 'echo 1']
   1
   ```
   After: 
   ```
   23:33 $ AIRFLOW__LOGGING__COLORED_LOG_FORMAT='%(name)s: %(message)s'  python -c 'from airflow.logging_config import configure_logging; from airflow.executors.celery_executor import execute_command; configure_logging(); execute_command(["bash", "-c", "echo 1"]);'
   airflow.executors.celery_executor: Executing command in Celery: ['bash', '-c', 'echo 1']
   `
   ```
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Set unique logger names
> -----------------------
>
>                 Key: AIRFLOW-6708
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6708
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: core, logging
>    Affects Versions: 1.10.7
>            Reporter: Kamil Bregula
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)