You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Krishna (Code Review)" <ge...@cloudera.org> on 2019/04/17 16:25:45 UTC
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Bharath Krishna has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13056
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
IMPALA-8426: Logging error in DROP_TABLE event processing
Fixing the bug in condition check while logging in
DROP_TABLE event processing. Also updating EVENTS_SKIPPED
metric to keep track of the number of drop table events
skipped when CREATION_TIME matches.
Testing:
- Added metric check to unit test.
- Ran existing unit tests.
Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
2 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/13056/1
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 20:18:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:
http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@724
PS1, Line 724: assertEquals(1,
: eventsProcessor_.getMetrics()
: .getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).getCount()
: - numFilteredEvents);
> nit: assertEquals(numFilteredevents +1 , ..getCount() ?
+1 to above suggestion.
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 19:03:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Bharath Krishna (Code Review)" <ge...@cloudera.org>.
Bharath Krishna has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
IMPALA-8426: Logging error in DROP_TABLE event processing
Fixing the bug in condition check while logging in
DROP_TABLE event processing. Also updating EVENTS_SKIPPED
metric to keep track of the number of drop table events
skipped when CREATION_TIME matches.
Testing:
- Added metric check to unit test.
- Ran existing unit tests.
Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
2 files changed, 14 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/13056/2
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 20:18:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2825/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 20:39:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
IMPALA-8426: Logging error in DROP_TABLE event processing
Fixing the bug in condition check while logging in
DROP_TABLE event processing. Also updating EVENTS_SKIPPED
metric to keep track of the number of drop table events
skipped when CREATION_TIME matches.
Testing:
- Added metric check to unit test.
- Ran existing unit tests.
Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Reviewed-on: http://gerrit.cloudera.org:8080/13056
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
2 files changed, 14 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 4
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2823/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 17:15:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 19:03:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4038/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 20:18:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 01:20:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:
http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@724
PS1, Line 724: assertEquals(1,
: eventsProcessor_.getMetrics()
: .getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).getCount()
: - numFilteredEvents);
nit: assertEquals(numFilteredevents +1 , ..getCount() ?
I think that is more readable.
--
To view, visit http://gerrit.cloudera.org:8080/13056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Krishna <bh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 19:00:10 +0000
Gerrit-HasComments: Yes