You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/09 03:05:12 UTC
[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #79: Fix the bug that can't query JVM instance metrics
fgksgf commented on a change in pull request #79:
URL: https://github.com/apache/skywalking-cli/pull/79#discussion_r538970075
##########
File path: commands/interceptor/scope.go
##########
@@ -31,7 +31,7 @@ func ParseScope(name string) schema.Scope {
ret = schema.ScopeServiceRelation
} else if strings.HasPrefix(name, "service_instance_relation") {
ret = schema.ScopeServiceInstanceRelation
- } else if strings.HasPrefix(name, "service_instance") {
+ } else if strings.HasPrefix(name, "service_instance") || strings.HasPrefix(name, "instance_") {
Review comment:
Ok, I thought your "auto-scope logic" referred this..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org