You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2008/06/02 13:31:50 UTC
[jira] Created: (DERBY-3700) Get rid of tools/java/empty.jar
Get rid of tools/java/empty.jar
-------------------------------
Key: DERBY-3700
URL: https://issues.apache.org/jira/browse/DERBY-3700
Project: Derby
Issue Type: Improvement
Components: Build tools
Reporter: Knut Anders Hatlen
Assignee: Knut Anders Hatlen
Priority: Trivial
empty.jar is used to prevent the Java compiler from putting the default Java runtime libraries in the boot classpath. An empty directory would also work, so we could remove the jar file from the source repository and instead let the build scripts create an empty directory for us.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3700) Get rid of tools/java/empty.jar
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-3700:
--------------------------------------
Derby Info: (was: [Patch Available])
Committed revision 662789.
> Get rid of tools/java/empty.jar
> -------------------------------
>
> Key: DERBY-3700
> URL: https://issues.apache.org/jira/browse/DERBY-3700
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Trivial
> Attachments: d3700.diff
>
>
> empty.jar is used to prevent the Java compiler from putting the default Java runtime libraries in the boot classpath. An empty directory would also work, so we could remove the jar file from the source repository and instead let the build scripts create an empty directory for us.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3700) Get rid of tools/java/empty.jar
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen resolved DERBY-3700.
---------------------------------------
Resolution: Fixed
Fix Version/s: 10.5.0.0
Also removed the mentioning of empty.jar in BUILDING.txt and committed revision 662797.
> Get rid of tools/java/empty.jar
> -------------------------------
>
> Key: DERBY-3700
> URL: https://issues.apache.org/jira/browse/DERBY-3700
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Trivial
> Fix For: 10.5.0.0
>
> Attachments: d3700.diff
>
>
> empty.jar is used to prevent the Java compiler from putting the default Java runtime libraries in the boot classpath. An empty directory would also work, so we could remove the jar file from the source repository and instead let the build scripts create an empty directory for us.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3700) Get rid of tools/java/empty.jar
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601633#action_12601633 ]
Knut Anders Hatlen commented on DERBY-3700:
-------------------------------------------
The point is that we'll have one less *binary* file under source
control. Since it's a source code repository, I think we should try to
have as few binary files as possible. The patch basically replaces a
binary file with one line of source code that generates a replacement
for it at build-time. Whether it generates an empty jar or an empty
directory is not important, but the ant command for making a directory
was shorter. :)
> Get rid of tools/java/empty.jar
> -------------------------------
>
> Key: DERBY-3700
> URL: https://issues.apache.org/jira/browse/DERBY-3700
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Trivial
> Attachments: d3700.diff
>
>
> empty.jar is used to prevent the Java compiler from putting the default Java runtime libraries in the boot classpath. An empty directory would also work, so we could remove the jar file from the source repository and instead let the build scripts create an empty directory for us.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3700) Get rid of tools/java/empty.jar
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601627#action_12601627 ]
Bryan Pendleton commented on DERBY-3700:
----------------------------------------
Is an empty directory better than an empty jar? Or is the point that we'd have
one less file under source control (and a somewhat confusing file, at that)?
> Get rid of tools/java/empty.jar
> -------------------------------
>
> Key: DERBY-3700
> URL: https://issues.apache.org/jira/browse/DERBY-3700
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Trivial
> Attachments: d3700.diff
>
>
> empty.jar is used to prevent the Java compiler from putting the default Java runtime libraries in the boot classpath. An empty directory would also work, so we could remove the jar file from the source repository and instead let the build scripts create an empty directory for us.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3700) Get rid of tools/java/empty.jar
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen closed DERBY-3700.
-------------------------------------
> Get rid of tools/java/empty.jar
> -------------------------------
>
> Key: DERBY-3700
> URL: https://issues.apache.org/jira/browse/DERBY-3700
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Trivial
> Fix For: 10.5.0.0
>
> Attachments: d3700.diff
>
>
> empty.jar is used to prevent the Java compiler from putting the default Java runtime libraries in the boot classpath. An empty directory would also work, so we could remove the jar file from the source repository and instead let the build scripts create an empty directory for us.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3700) Get rid of tools/java/empty.jar
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-3700:
--------------------------------------
Derby Info: [Patch Available]
suites.All passed on both 1.6 and 1.4.2. I also have derbyall running on 1.6.
> Get rid of tools/java/empty.jar
> -------------------------------
>
> Key: DERBY-3700
> URL: https://issues.apache.org/jira/browse/DERBY-3700
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Trivial
> Attachments: d3700.diff
>
>
> empty.jar is used to prevent the Java compiler from putting the default Java runtime libraries in the boot classpath. An empty directory would also work, so we could remove the jar file from the source repository and instead let the build scripts create an empty directory for us.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3700) Get rid of tools/java/empty.jar
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-3700:
--------------------------------------
Attachment: d3700.diff
The attached patch (d3700.diff) makes the build scripts create an empty directory under classes when the engine target is invoked, and changes the variable empty so that it points to the directory instead of the jar. I'm able to build Derby with JAVA_HOME set to 1.5 or 1.6 with these changes. I have also started the regression tests using both Java version 1.4.2 and version 1.6 to see if this change introduces dependencies on a specific Java version.
Output from svn stat:
M build.xml
D tools/java/empty.jar
M tools/ant/properties/compilepath.properties
> Get rid of tools/java/empty.jar
> -------------------------------
>
> Key: DERBY-3700
> URL: https://issues.apache.org/jira/browse/DERBY-3700
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Trivial
> Attachments: d3700.diff
>
>
> empty.jar is used to prevent the Java compiler from putting the default Java runtime libraries in the boot classpath. An empty directory would also work, so we could remove the jar file from the source repository and instead let the build scripts create an empty directory for us.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.