[GitHub] [pinot] deemoliu commented on a diff in pull request #10826: Upsert snapshot should be taken before new a consuming segment created

["deemoliu (via GitHub)" <gi...@apache.org>]

deemoliu commented on code in PR #10826:
URL: https://github.com/apache/pinot/pull/10826#discussion_r1212435986


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1071,6 +1075,21 @@ private void closeStreamConsumers() {
     if (_acquiredConsumerSemaphore.compareAndSet(true, false)) {
       _partitionGroupConsumerSemaphore.release();
     }
+    if (_tableConfig.getUpsertConfig().isEnableSnapshot()) {

Review Comment:
   @Jackie-Jiang thanks for review. When acquiring the consumer semaphore, does it guarantee the previous segment is sealed?
   
   I plan to acquire all segments and persist snapshot for all sealed segments, is it possible that the last segment is not sealed yet?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org