[GitHub] [spark] AngersZhuuuu commented on a change in pull request #26172: [WIP][SPARK-29516][SQL][TEST] Test ThriftServerQueryTestSuite asynchronously

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #26172: [WIP][SPARK-29516][SQL][TEST] Test ThriftServerQueryTestSuite asynchronously
URL: https://github.com/apache/spark/pull/26172#discussion_r336942347
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
 ##########
 @@ -600,6 +600,7 @@ class SparkSession private(
    * @since 2.0.0
    */
   def sql(sqlText: String): DataFrame = {
+    SparkSession.setActiveSession(this)
 
 Review comment:
   > To keep it in scope of thriftserver, could we set it in SparkExecuteStatementOperation.execute, using the sqlContext available there?
   > I'm not sure what other implications it can have here, it would be safer to set there.
   
   It's ok  to set in SparkExecuteStatementOperation.execute.
   https://github.com/apache/spark/pull/26187#discussion_r336877350
   I think it ok to set this before parse sql, It was the right thing to do

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org