[GitHub] [openwhisk] rabbah commented on a change in pull request #4704: Added more details for unsupported runtimes exception

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4704: Added more details for unsupported runtimes exception
URL: https://github.com/apache/openwhisk/pull/4704#discussion_r340393163
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/Exec.scala
 ##########
 @@ -323,7 +323,10 @@ object Exec extends ArgNormalizer[Exec] with DefaultJsonProtocol {
           // map "default" virtual runtime versions to the currently blessed actual runtime version
           val manifest = execManifests.resolveDefaultRuntime(kind) match {
             case Some(k) => k
-            case None    => throw new DeserializationException(s"kind '$kind' not in $runtimes")
+            case None =>
+              throw new DeserializationException(
+                s"the specified runtime '$kind' is not supported by this platform. Valid values are: ${runtimes
+                  .mkString("'", "', '", "'")}")
 
 Review comment:
   I would opt for no brackets. The ‘’ around each and comma separated list I think gets the point across. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services