You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/06/16 19:59:24 UTC
Re: Review Request 20987: Added sanitize method to clean up potential metric
names.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20987/
-----------------------------------------------------------
(Updated June 16, 2014, 10:59 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased
Bugs: MESOS-1285
https://issues.apache.org/jira/browse/MESOS-1285
Repository: mesos-git
Description
-------
see summary
this will become important when we start adding metrics to Process as we'll use the generated id which might include ()s.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 00ace49bc5ef3914704c6247ece99474444960c9
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
Diff: https://reviews.apache.org/r/20987/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20987: Added sanitize method to clean up potential metric
names.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20987/#review45899
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20987]
All tests passed.
- Mesos ReviewBot
On June 16, 2014, 5:59 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20987/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 5:59 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1285
> https://issues.apache.org/jira/browse/MESOS-1285
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
> this will become important when we start adding metrics to Process as we'll use the generated id which might include ()s.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp 00ace49bc5ef3914704c6247ece99474444960c9
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
>
> Diff: https://reviews.apache.org/r/20987/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>