You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by combineads <gi...@git.apache.org> on 2016/08/02 03:32:42 UTC
[GitHub] tajo pull request #1044: TAJO-1488: Implement KafkaTablespace
GitHub user combineads opened a pull request:
https://github.com/apache/tajo/pull/1044
TAJO-1488: Implement KafkaTablespace
KafkaTablespace provides the split information, this is KafkaFragment, using getSplits.
The issue is related to TAJO-1487. So first, must be commit TAJO-1487.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/combineads/tajo TAJO-1488
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/1044.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1044
----
commit 45a4dd2d4bee3643bfcb4c68d8ba5ed161375382
Author: Byunghwa Yun <co...@combineads.co.kr>
Date: 2016-08-02T03:30:25Z
TAJO-1488: Implement KafkaTablespace
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the issue:
https://github.com/apache/tajo/pull/1044
Thanks for your quick fix. I'll review soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace
Posted by combineads <gi...@git.apache.org>.
Github user combineads commented on the issue:
https://github.com/apache/tajo/pull/1044
@jinossy Thanks for your review.
I solved the error to add the kafka storage in the pom.xml of tajo-storage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace
Posted by combineads <gi...@git.apache.org>.
Github user combineads commented on the issue:
https://github.com/apache/tajo/pull/1044
I will modify the hBaseTablespace variable name to kafkaTablespace in TestKafkaTablespace.java.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the issue:
https://github.com/apache/tajo/pull/1044
rebase please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the issue:
https://github.com/apache/tajo/pull/1044
@combineads Hi Thanks for your contirbution!
Could you fix broken build ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the issue:
https://github.com/apache/tajo/pull/1044
+1 travis failure is not related this PR.
I was create to https://issues.apache.org/jira/browse/TAJO-1635
Thank you for your contribution!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request #1044: TAJO-1488: Implement KafkaTablespace
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/1044
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace
Posted by combineads <gi...@git.apache.org>.
Github user combineads commented on the issue:
https://github.com/apache/tajo/pull/1044
@jinossy Done rebase.
Thanks for your reviews.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---