You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ozone.apache.org by ra...@apache.org on 2022/05/24 06:36:57 UTC
[ozone] branch master updated: HDDS-6765. Get snapshot of write OMLockMetrics (#3427)
This is an automated email from the ASF dual-hosted git repository.
rakeshr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 4f35293124 HDDS-6765. Get snapshot of write OMLockMetrics (#3427)
4f35293124 is described below
commit 4f352931249aed3eac7de8c4080af29a54848a88
Author: tanvipenumudy <46...@users.noreply.github.com>
AuthorDate: Tue May 24 12:06:52 2022 +0530
HDDS-6765. Get snapshot of write OMLockMetrics (#3427)
---
.../apache/hadoop/ozone/om/lock/OMLockMetrics.java | 2 ++
.../hadoop/ozone/om/lock/TestOzoneManagerLock.java | 23 ++++++++++++++++++++++
2 files changed, 25 insertions(+)
diff --git a/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OMLockMetrics.java b/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OMLockMetrics.java
index a522ac2a73..09c6b5efe3 100644
--- a/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OMLockMetrics.java
+++ b/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OMLockMetrics.java
@@ -203,5 +203,7 @@ public final class OMLockMetrics implements MetricsSource {
MetricsRecordBuilder builder = collector.addRecord(SOURCE_NAME);
readLockHeldTimeMsStat.snapshot(builder, all);
readLockWaitingTimeMsStat.snapshot(builder, all);
+ writeLockHeldTimeMsStat.snapshot(builder, all);
+ writeLockWaitingTimeMsStat.snapshot(builder, all);
}
}
diff --git a/hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java b/hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java
index 4053e66dfa..f8093112dc 100644
--- a/hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java
+++ b/hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java
@@ -25,6 +25,7 @@ import java.util.UUID;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.atomic.AtomicBoolean;
+import org.apache.hadoop.metrics2.impl.MetricsCollectorImpl;
import org.apache.ozone.test.GenericTestUtils;
import org.junit.Assert;
import org.junit.Rule;
@@ -893,4 +894,26 @@ public class TestOzoneManagerLock {
Assert.assertTrue(ex.getMessage(), ex.getMessage().contains(message));
}
}
+
+ @Test
+ public void testOMLockMetricsRecords() {
+ OMLockMetrics omLockMetrics = OMLockMetrics.create();
+ try {
+ MetricsCollectorImpl metricsCollector = new MetricsCollectorImpl();
+ omLockMetrics.getMetrics(metricsCollector, true);
+ Assert.assertEquals(1, metricsCollector.getRecords().size());
+
+ String omLockMetricsRecords = metricsCollector.getRecords().toString();
+ Assert.assertTrue(omLockMetricsRecords,
+ omLockMetricsRecords.contains("ReadLockWaitingTime"));
+ Assert.assertTrue(omLockMetricsRecords,
+ omLockMetricsRecords.contains("ReadLockHeldTime"));
+ Assert.assertTrue(omLockMetricsRecords,
+ omLockMetricsRecords.contains("WriteLockWaitingTime"));
+ Assert.assertTrue(omLockMetricsRecords,
+ omLockMetricsRecords.contains("WriteLockHeldTime"));
+ } finally {
+ omLockMetrics.unRegister();
+ }
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ozone.apache.org
For additional commands, e-mail: commits-help@ozone.apache.org