You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/05/09 23:45:57 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml

Abacn commented on code in PR #26441:
URL: https://github.com/apache/beam/pull/26441#discussion_r1189224556


##########
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/RecommendationAIWriteUserEvent.java:
##########
@@ -60,13 +58,13 @@ static Builder newBuilder() {
   }
 
   /** @return ID of Google Cloud project to be used for creating user events. */
-  public abstract @Nullable String projectId();

Review Comment:
   Due to the change here.
   
   In general it is possible breakage could happen elsewhere forcing previously nullable parameters to nonnull



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org