You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2011/03/15 13:37:30 UTC

[jira] Created: (WICKET-3536) Cache the value from Application.getConfigurationType()

Cache the value from Application.getConfigurationType()
-------------------------------------------------------

                 Key: WICKET-3536
                 URL: https://issues.apache.org/jira/browse/WICKET-3536
             Project: Wicket
          Issue Type: Improvement
    Affects Versions: 1.5-RC2, 1.4.16
            Reporter: Martin Grigorov


org.apache.wicket.protocol.http.WebApplication.getConfigurationType() tries to read the config type from System properties table, web.xml init/context parameter every time the application needs to know whether it is running in Development or Deployment mode.
When the user application overrides this method everything is OK, but when it uses -Dwicket.configuration or init/context parameter then it is a bit overkill to "parse" it again and again.
The value will not change at runtime so it is better to cache it once read.

Spotted-by: Reiner Jung (Apache Tomcat committer)  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Resolved: (WICKET-3536) Cache the value from Application.getConfigurationType()

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3536.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-RC3
         Assignee: Martin Grigorov

Improved with r1082283.

> Cache the value from Application.getConfigurationType()
> -------------------------------------------------------
>
>                 Key: WICKET-3536
>                 URL: https://issues.apache.org/jira/browse/WICKET-3536
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 1.4.16, 1.5-RC2
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC3
>
>
> org.apache.wicket.protocol.http.WebApplication.getConfigurationType() tries to read the config type from System properties table, web.xml init/context parameter every time the application needs to know whether it is running in Development or Deployment mode.
> When the user application overrides this method everything is OK, but when it uses -Dwicket.configuration or init/context parameter then it is a bit overkill to "parse" it again and again.
> The value will not change at runtime so it is better to cache it once read.
> Spotted-by: Reiner Jung (Apache Tomcat committer)  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira