[GitHub] [spark] mridulm commented on a change in pull request #28094: [SPARK-29303][Web UI] Add UI support for stage level scheduling

[GitBox <gi...@apache.org>]

mridulm commented on a change in pull request #28094:
URL: https://github.com/apache/spark/pull/28094#discussion_r424829593



##########
File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala
##########
@@ -109,7 +114,8 @@ class ExecutorSummary private[spark](
     @JsonDeserialize(using = classOf[ExecutorMetricsJsonDeserializer])
     val peakMemoryMetrics: Option[ExecutorMetrics],
     val attributes: Map[String, String],
-    val resources: Map[String, ResourceInformation])
+    val resources: Map[String, ResourceInformation],
+    val resourceProfileId: Int)

Review comment:
       While deserializing existing history files, which wont have resource profile related events, will it default to using ResourceProfile.DEFAULT_RESOURCE_PROFILE_ID ?
   Or is it backwardly incompatible ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org