[GitHub] [ozone] wzhallright commented on a change in pull request #2319: HDDS-5324. Shouldn't decNumKeys when delete keys fail

[GitBox <gi...@apache.org>]

wzhallright commented on a change in pull request #2319:
URL: https://github.com/apache/ozone/pull/2319#discussion_r648179694



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java
##########
@@ -220,7 +220,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
       }
       break;
     case FAILURE:
-      omMetrics.decNumKeys(deleteKeys.size());

Review comment:
       Thanks for review, sorry for  i overlooked it in catch.
   If in order to avoid unnecessary calls to decNumKeys, is it necessary to delete it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org