You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/11/24 09:58:46 UTC
[GitHub] [incubator-brpc] wasphin opened a new pull request #1293: Fix problem of fetching nodes from discovery naming service
wasphin opened a new pull request #1293:
URL: https://github.com/apache/incubator-brpc/pull/1293
根据 [获取实例fetch](https://github.com/bilibili/discovery/blob/master/doc/api.md#%E8%8E%B7%E5%8F%96%E5%AE%9E%E4%BE%8Bfetch), instances 下面有一级 zones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #1293: Fix problem of fetching nodes from discovery naming service
Posted by GitBox <gi...@apache.org>.
zyearn commented on pull request #1293:
URL: https://github.com/apache/incubator-brpc/pull/1293#issuecomment-732813282
改这个的背景是什么？在内部discovery返回的instances下面是一个array，是内外版本不一致导致的么
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wasphin commented on pull request #1293: Fix problem of fetching nodes from discovery naming service
Posted by GitBox <gi...@apache.org>.
wasphin commented on pull request #1293:
URL: https://github.com/apache/incubator-brpc/pull/1293#issuecomment-735019707
> 这个要在discovery issue区确认一下，如果不一样的话，最好在discovery解决（或许是内部版本没及时更新到github上）
https://github.com/bilibili/discovery/issues/70
已经提 issue 了，但是貌似没什么回应，QQ 群也一样，不是很活跃，@zyearn 内部有没有什么其他的沟通渠道？
另外如果 discovery 对外的接口不做更新，brpc 是不是可以通过编译选项之类的对外先保持一致？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #1293: Fix problem of fetching nodes from discovery naming service
Posted by GitBox <gi...@apache.org>.
zyearn commented on pull request #1293:
URL: https://github.com/apache/incubator-brpc/pull/1293#issuecomment-735462987
不太清楚还有其它的沟通渠道。
最好等等他们回复吧，否则在brpc维护两套代码比较奇怪。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #1293: Fix problem of fetching nodes from discovery naming service
Posted by GitBox <gi...@apache.org>.
zyearn commented on pull request #1293:
URL: https://github.com/apache/incubator-brpc/pull/1293#issuecomment-733730005
这个要在discovery issue区确认一下，如果不一样的话，最好在discovery解决（或许是内部版本没及时更新到github上）
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wasphin commented on pull request #1293: Fix problem of fetching nodes from discovery naming service
Posted by GitBox <gi...@apache.org>.
wasphin commented on pull request #1293:
URL: https://github.com/apache/incubator-brpc/pull/1293#issuecomment-732850203
> 改这个的背景是什么？在内部discovery返回的instances下面是一个array，是内外版本不一致导致的么
从 GitHub 上开放的 discovery 返回的 instances 下有一级 zone，项目里 API 文档介绍也是有的，不确定内部接口是什么样的，如果是不一致那应该判断或说明一下。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wasphin commented on pull request #1293: Fix problem of fetching nodes from discovery naming service
Posted by GitBox <gi...@apache.org>.
wasphin commented on pull request #1293:
URL: https://github.com/apache/incubator-brpc/pull/1293#issuecomment-732852637
另外如果需要改就再补一下单元测试部分
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org