You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/05/28 10:36:59 UTC
[Bug 119443] New: the shape 3D property effect in MS PPT can't be
load correctly.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Priority: P3
Bug ID: 119443
Assignee: ooo-issues@incubator.apache.org
Summary: the shape 3D property effect in MS PPT can't be load
correctly.
Severity: normal
Issue Type: DEFECT
Classification: Application
OS: All
Reporter: bjdujing@gmail.com
Hardware: PC
Status: UNCONFIRMED
Version: AOO 3.4.0
Component: ui
Product: presentation
build info:AOO3.4_1327774
Steps:
1. open the attachment sample file in AOO3.4
2. check the shape display
defect:
it looks different with MS office,and the 3D effect of shape can't be loaded in
AOO3.4
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Jianyuan Li <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lijianyuan1983@gmail.com
--- Comment #5 from Jianyuan Li <li...@gmail.com> ---
Investigating this issue...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Shenfeng Liu <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liushenf@gmail.com
Target Milestone|--- |AOO 4.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
--- Comment #8 from Jianyuan Li <li...@gmail.com> ---
@Armin:
In the patch, "EnhancedCustomShape3d::Create3DObject" is called to apply 3D
effect. In this function, geometry properties(containing 3D) will be obtained
directly from SdrObject(custom shape). But those properties cannot be obtained
from new created 3D SdrObject(pRet). Actually those props have been set into
the SdrObject(its itemset) in "ApplyCustomShapeGeometryAttributes". And then
the itemset will be set into SdrObject with "SetMergedItemSet". I have tracked
this function, seems that the SdrCustomShapeGeometryItem(directly related to
the 3D effect) cannot be set into SdrObject because it is a SFX_ITEM_DEFAULT
item(confused). So here I add a parameter for
"EnhancedCustomShape3d::Create3DObject" to pass the correct geometry
item(SdrCustomShapeGeometryItem).
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
liupingtan <do...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Du Jing <bj...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
--- Comment #4 from Du Jing <bj...@gmail.com> ---
change its status~
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] the shape 3D property effect in MS PPT can't be load
correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
--- Comment #1 from bjdujing@gmail.com ---
Created attachment 77628
--> https://issues.apache.org/ooo/attachment.cgi?id=77628&action=edit
sample file
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Jianyuan Li <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #78900| |review?(Armin.Le.Grand@me.c
Flags| |om)
--- Comment #7 from Jianyuan Li <li...@gmail.com> ---
Created attachment 78900
--> https://issues.apache.org/ooo/attachment.cgi?id=78900&action=edit
Patch for this issue
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
--- Comment #15 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1372832 into trunk:
#119443# Import lines from ppt as one poin connectorsPatch by: Jianjuan
LiRev...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Lei Debin <de...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |debin.lei@gmail.com
--- Comment #3 from Lei Debin <de...@gmail.com> ---
I am looking at it
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com
--- Comment #2 from Armin Le Grand <Ar...@me.com> ---
ALG: Same in OOo3.3.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #16 from Armin Le Grand <Ar...@me.com> ---
ALG: Comitted, done. For the bad 3D visualisation I wrote follow-up task
#120569#.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
--- Comment #6 from Jianyuan Li <li...@gmail.com> ---
Root cause: For line(with arrow) in AOO, 3D effect is not supported. While MS
2003 support this.
Resolution: When import, transform line into poly object and then apply 3D
effect to it.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
bjdujing@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|the shape 3D property |[From Symphony]the shape 3D
|effect in MS PPT can't be |property effect in MS PPT
|load correctly. |can't be load correctly.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
--- Comment #12 from Armin Le Grand <Ar...@me.com> ---
ALG: Hi Jianyuan Li,
I think the second patch is much better, keeping the data as standard custom
shape is the best solution I think, the export will be better and the roundtrip
is better. When it is not showing the same as in PPT it is another bug. I would
use this patch, set this task to fixed and open another one for the wrong
display. What do you think?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
--- Comment #17 from liupingtan <do...@gmail.com> ---
Created attachment 79006
--> https://issues.apache.org/ooo/attachment.cgi?id=79006&action=edit
capture.png
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
--- Comment #14 from Jianyuan Li <li...@gmail.com> ---
@Armin:
I agree. Please go ahead. Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
ALG: Hi Jianyuan Li, what items can be set at an SdrObject depends on the range
it did use when constructing it's ItemSet. An ItemSet cannot simply store all
SfxItems which are registered at the SfxItemPool, but uses a sequence of range
values which correspond to Item-IDs.
The ItemSet containing the SdrObjects properties is separated from SdrObject in
sdr::properties::BaseProperties. The kind of BaseProperties constructed for an
SdrObject depends on it's implementation of CreateObjectSpecificProperties().
The SdrCustomShapeGeometryItem uses the ID SDRATTR_CUSTOMSHAPE_GEOMETRY which
is in the SDRATTR_CUSTOMSHAPE_FIRST .. SDRATTR_CUSTOMSHAPE_LAST range. That
range is supported in CustomShapeProperties::CreateObjectSpecificItemSet where
sdr::properties::CustomShapeProperties get created from
SdrObjCustomShape::CreateObjectSpecificProperties(). Thus, your SdrObject needs
to be a SdrObjCustomShape to hold a SdrCustomShapeGeometryItem. I would guess
that the SdrShape you are using is not of that type. If the SfxItem is not
supported by the SdrObject's SfxItemSet, it will be filtered out when SfxItems
are put to that SfxItemSet. This is wanted and often used functionality of
SfxItemSets.
So please check if the SdrObject where SdrCustomShapeGeometryItem is set is of
type SdrObjCustomShape. If not, this is the problem. It should be of that type,
other SdrObject types cannot handle this type of item.
HTH! I'll try to look into this issue...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
liupingtan <do...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |doneyourself@gmail.com
--- Comment #18 from liupingtan <do...@gmail.com> ---
Verified on Windows7-64bit with AOO trunk r1374181
the 3-D transparency shape change to black shape,please refer capture.png
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
--- Comment #10 from Jianyuan Li <li...@gmail.com> ---
@Armin:
Thanks for the clue. I have checked the SdrObject. It is an SdrPathObj which
cannot contain a SdrCustomShapeGeometryItem.
According to this hint, I have another solution for this issue. I want to
import the line with 3D effects as a SdrObjCustomShape. For its geometry, I
simply used msoStraightConnector1. For this, below two advantages
appears(comparing the first patch):
1. SdrCustomShapeGeometryItem will be set into item set by
ApplyCustomShapeGeometryAttributes. So nothing additional needs be done for
filter code.
2. No need to call EnhancedCustomShape3d::Create3DObject because it will be
called for custom shape by core(not for line).
I also created the second patch for this. It is new patch which is not based on
the first one.
But this patch still cannot import the 3D correctly. 3D effect has been
imported. But the effect is not the same like in MS 2003. There are two
possibilities:
1. Custom object should be converted into a poly object. I have tried this with
SdrObjCustomShape::ConvertToPolyObj(like the call in first patch). But it does
not work. At the same time I think it is not reasonable to convert it into a
poly because this will impact the line export for MS 2003(not a line any more).
Just with the second patch, the imported 3D line can be exported correctly. Its
3D effect and shape type is the same as original line.
2. For line(custom), it seems that core function will not consider line width
when applying 3D effects like MS 2003. Can you help check whether it is
possible to consider line width(just for line shape) in
EnhancedCustomShape3d::Create3DObject?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Jianyuan Li <li...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lijiany@apache.org
--- Comment #19 from Jianyuan Li <li...@apache.org> ---
@liupingtan:
The issue you mentioned has been fixed by an extension fix for Bug 120569.
Please see the comments in it by me and Armin. Please verify this one. Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
--- Comment #13 from Armin Le Grand <Ar...@me.com> ---
ALG: Hi Jianyuan Li,
checked the 2nd patch, it does what it should do, import the lines as line
custom shapes. Only the first black one does not show the same. The original
has only an outline, something we cannot (yet) do for lines. Looking with
PPT2007 it seems to be a special style for 3D.
Besides from that when switching off 3d it looks as in the original (also
switching off 3D).
I suggest to commit patch two and write a task for the remaining error (3D
applied to line custom shapes does not take line attributes into account, or
similar).
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Jianyuan Li <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #78911| |review?
Flags| |
--- Comment #11 from Jianyuan Li <li...@gmail.com> ---
Created attachment 78911
--> https://issues.apache.org/ooo/attachment.cgi?id=78911&action=edit
The second patch for this issue
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 119443] [From Symphony]the shape 3D property effect in MS PPT
can't be load correctly.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119443
Yan Ji <ya...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|VERIFIED |CLOSED
--- Comment #20 from Yan Ji <ya...@gmail.com> ---
Verified against rev r1377620 on windows 7. The problem is fixed.
--
You are receiving this mail because:
You are the assignee for the bug.